arm: mach-omap2: Kconfig: fix incorrect option
Subsystems (3)
PATCH 1/2 arm: mach-omap2: Kconfig: fix incorrect option
There is no MFD config option, MFD_SUPPORT should be selected instead. This will prevent build errors when trying out different configurations.
--- arch/arm/mach-omap2/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/Kconfig +1 -1
@@ -15,7 +15,7 @@ config ARCH_OMAP2PLUS_TYPICAL select SERIAL_OMAP_CONSOLE select I2C select I2C_OMAP - select MFD + select MFD_SUPPORT select MENELAUS if ARCH_OMAP2 select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4 select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
Signature · 1 line
1.5.6.5
PATCH 2/2 arm: mach-omap2: Kconfig: devkit8000 should select needed options
It's not possible to compile a kernel for this board without I2C, MFD_SUPPORT and TWL4030_CORE, so those should be selected. This will prevent build errors when trying out different configurations.
--- arch/arm/mach-omap2/Kconfig | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/Kconfig +4 -0
@@ -129,6 +129,10 @@ config MACH_DEVKIT8000 default y select OMAP_PACKAGE_CUS select OMAP_MUX + select I2C + select I2C_OMAP + select MFD_SUPPORT + select TWL4030_CORE config MACH_OMAP_LDP bool "OMAP3 LDP board"
Signature · 1 line
1.5.6.5
Tony Lindgren
maintainerPATCH 2/2 arm: mach-omap2: Kconfig: devkit8000 should select needed options
Hi Aaro,
Quoted 3 lines · Aaro Koskinen
It's not possible to compile a kernel for this board without I2C,
MFD_SUPPORTandTWL4030_CORE, so those should be selected. This will prevent build errors when trying out different configurations.
This one I'm not so convinced about. We should be able to compile support for each board and enable and disable these kind of options just fine if CONFIG_ARCH_OMAP2PLUS_TYPICAL is disabled.
In the long run we really want to have just a minimal kernel and have everything else as modules for the default configs and boot using initramfs.
Probably the best way to deal with issues like this is to have omap generic platform init code for the common devices that gets built if those options are selected. Otherwise we'll end up with ifdefs all over the board-*.c files.
Regards,
Tony
Quoted 23 lines
Signed-off-by Aaro Koskinen <[email protected]>--- arch/arm/mach-omap2/Kconfig | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)arch/arm/mach-omap2/Kconfig +4
-0@@ -129,6 +129,10 @@ config MACH_DEVKIT8000 default y select OMAP_PACKAGE_CUS select OMAP_MUX + select I2C + select I2C_OMAP + select MFD_SUPPORT + select TWL4030_CORE config MACH_OMAP_LDP bool "OMAP3 LDP board"Signature · 1 line
1.5.6.5
PATCH 2/2 arm: mach-omap2: Kconfig: devkit8000 should select needed options
Hi,
Quoted 8 lines · Tony Lindgren
Quoted 3 lines · Aaro Koskinen
It's not possible to compile a kernel for this board without I2C,
MFD_SUPPORTandTWL4030_CORE, so those should be selected. This will prevent build errors when trying out different configurations.This one I'm not so convinced about. We should be able to compile support for each board and enable and disable these kind of options just fine if
CONFIG_ARCH_OMAP2PLUS_TYPICALis disabled.
So in this case we should move the stuff with special dependencies from the board file into e.g. board-devkit8000-peripherals, which would be a kernel module?
A.
Tony Lindgren
maintainerPATCH 2/2 arm: mach-omap2: Kconfig: devkit8000 should select needed options
Quoted 8 lines · Aaro Koskinen
Hi,
Quoted 5 lines · Tony Lindgren
Quoted 3 lines · Aaro Koskinen
It's not possible to compile a kernel for this board without I2C,
MFD_SUPPORTandTWL4030_CORE, so those should be selected. This will prevent build errors when trying out different configurations.
Quoted 7 lines
Quoted 3 lines
This one I'm not so convinced about. We should be able to compile support for each board and enable and disable these kind of options just fine if
CONFIG_ARCH_OMAP2PLUS_TYPICALis disabled.So in this case we should move the stuff with special dependencies from the board file into e.g. board-devkit8000-peripherals, which would be a kernel module?
Or how about just have them in ifdef CONFIG_I2C_OMAP and TWL4030_CORE in the board-devkit8000.c file?
Regards,
Tony