Skip to contentSkip to conversation

Fix migrate set speed doc arg

PATCH Applied Luiz Capitulino 3 participants 3 messages Dec 15, 2010 – Dec 27, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix migrate set speed doc arg

We used to ignore any fractional part in 0.13, but due to recent changes (started with 9f9b17a4f0865286391e4d3a0a735230122a2289) migrate_set_speed will reject the fractional part.

We don't expect existing clients to be relying on this, but we need to update the documentation to reflect the change.

---
 qmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
qmp-commands.hx +1 -1
index 3486223..164ecbc 100644
@@ -510,7 +510,7 @@ Set maximum speed for migrations.
 
 Arguments:
 
-- "value": maximum speed, in bytes per second (json-number)
+- "value": maximum speed, in bytes per second (json-int)
 
 Example:
 
Signature · 1 line
1.7.3.3.585.g74f6e
#1 lore raw
Quoted 8 lines · Luiz Capitulino

We used to ignore any fractional part in 0.13, but due to recent changes (started with 9f9b17a4f0865286391e4d3a0a735230122a2289) migrate_set_speed will reject the fractional part.

We don't expect existing clients to be relying on this, but we need to update the documentation to reflect the change.

Documentation broken by commit ed3d4a80.

ACK

#2 lore raw
In reply to Luiz Capitulino
Quoted 11 lines · Luiz Capitulino

We used to ignore any fractional part in 0.13, but due to recent changes (started with 9f9b17a4f0865286391e4d3a0a735230122a2289) migrate_set_speed will reject the fractional part.

We don't expect existing clients to be relying on this, but we need to update the documentation to reflect the change.

---
 qmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied.

Quoted 18 lines
qmp-commands.hx +1 -1
index 3486223..164ecbc 100644
@@ -510,7 +510,7 @@ Set maximum speed for migrations.
 
 Arguments:
 
-- "value": maximum speed, in bytes per second (json-number)
+- "value": maximum speed, in bytes per second (json-int)
 
 Example:
 
Signature · 1 line
1.7.3.3.585.g74f6e
Signature · 2 lines
Aurelien Jarno                          GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net