Skip to contentSkip to conversation

include/linux: Add missing include / fix build failure

PATCH Superseded Peter Huewe 3 participants 4 messages Dec 15, 2010 – Dec 16, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include/linux: Add missing include / fix build failure

From: Peter Huewe <[email protected]>

This patch fixes a build failure[1-2] by adding the missing asm/memory.h include needed for arch_is_coherent().

---
KernelVersion: linux-next-20101215
Used configs: hackkit_defconfig (arm), ep93xx_defconfig (arm)

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/3651495/
[2] http://kisskb.ellerman.id.au/kisskb/buildresult/3651425/

Error Message:
In file included from include/linux/list_bl.h:5,

                 from include/linux/rculist_bl.h:7,
                 from include/linux/dcache.h:7,
                 from include/linux/fs.h:381,
                 from arch/arm/mm/mmap.c:4:

include/linux/bit_spinlock.h: In function 'bit_spin_unlock':
include/linux/bit_spinlock.h:61: error: implicit declaration of function 'arch_is_coherent'

 include/linux/bit_spinlock.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/bit_spinlock.h +1 -0
index e612575..053fad7 100644
@@ -4,6 +4,7 @@
 #include <linux/kernel.h>
 #include <linux/preempt.h>
 #include <asm/atomic.h>
+#include <asm/memory.h>
 
 /*
  *  bit-based spin_lock()
Signature · 1 line
1.7.2.2
#1 lore raw

Hi Peter,

Quoted 15 lines · On Wed, 15 Dec 2010 22:04:18 +0100 Peter Huewe <[email protected]> wrote:

From: Peter Huewe <[email protected]>

This patch fixes a build failure[1-2] by adding the missing asm/memory.h include needed for arch_is_coherent().

---
KernelVersion: linux-next-20101215
Used configs: hackkit_defconfig (arm), ep93xx_defconfig (arm)

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/3651495/
[2] http://kisskb.ellerman.id.au/kisskb/buildresult/3651425/

Quoted 8 lines

Error Message:
In file included from include/linux/list_bl.h:5,

                 from include/linux/rculist_bl.h:7,
                 from include/linux/dcache.h:7,
                 from include/linux/fs.h:381,
                 from arch/arm/mm/mmap.c:4:

include/linux/bit_spinlock.h: In function 'bit_spin_unlock':
include/linux/bit_spinlock.h:61: error: implicit declaration of function 'arch_is_coherent'

All (or most) of the above information should be in the commit message (so above the "Signed-off-by").

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw

PATCH v2 1/1 include/linux: Add missing include / fix build failure

From: Peter Huewe <[email protected]>

This patch fixes a build failure[1-2] by adding the missing asm/memory.h include needed for arch_is_coherent().

Error message:
In file included from include/linux/list_bl.h:5,

                 from include/linux/rculist_bl.h:7,
                 from include/linux/dcache.h:7,
                 from include/linux/fs.h:381,
                 from arch/arm/mm/mmap.c:4:

include/linux/bit_spinlock.h: In function 'bit_spin_unlock':
include/linux/bit_spinlock.h:61: error: implicit declaration of function 'arch_is_coherent'

KernelVersion: linux-next-20101215
Used configs: hackkit_defconfig (arm), ep93xx_defconfig (arm)

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/3651495/
[2] http://kisskb.ellerman.id.au/kisskb/buildresult/3651425/

---
v2:
moved additional information in the commit message.

 include/linux/bit_spinlock.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/bit_spinlock.h +1 -0
index e612575..053fad7 100644
@@ -4,6 +4,7 @@
 #include <linux/kernel.h>
 #include <linux/preempt.h>
 #include <asm/atomic.h>
+#include <asm/memory.h>
 
 /*
  *  bit-based spin_lock()
Signature · 1 line
1.7.2.2
#3 lore raw

Hi Peter,

Thanks for this.

Quoted 35 lines · Peter H?we

From: Peter Huewe <[email protected]>

This patch fixes a build failure[1-2] by adding the missing asm/memory.h include needed for arch_is_coherent().

Error message:
In file included from include/linux/list_bl.h:5,

                 from include/linux/rculist_bl.h:7,
                 from include/linux/dcache.h:7,
                 from include/linux/fs.h:381,
                 from arch/arm/mm/mmap.c:4:

include/linux/bit_spinlock.h: In function 'bit_spin_unlock':
include/linux/bit_spinlock.h:61: error: implicit declaration of function 'arch_is_coherent'

KernelVersion: linux-next-20101215
Used configs: hackkit_defconfig (arm), ep93xx_defconfig (arm)

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/3651495/
[2] http://kisskb.ellerman.id.au/kisskb/buildresult/3651425/

---
v2:
moved additional information in the commit message.

 include/linux/bit_spinlock.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/bit_spinlock.h +0 -0
index e612575..053fad7 100644

include/linux/bit_spinlock.h line 10

Quoted 7 lines
include/linux/bit_spinlock.h +1 -0
@@ -4,6 +4,7 @@
 #include <linux/kernel.h>
 #include <linux/preempt.h>
 #include <asm/atomic.h>
+#include <asm/memory.h>
 
 /*
  *  bit-based spin_lock()

The problem is actually in ARM's asm/atomic.h file -- they declare the smp_mb__before_clear_bit() etc. without providing the necessary includes to actually call it. Can you include asm/memory.h in there?

Thanks,
Nick