Skip to contentSkip to conversation

cfi_flash: Use flash_read32() in sector_erased()

PATCH New Stefan Roese 1 participant 2 messages Oct 25, 2010 – Dec 17, 2010 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cfi_flash: Use flash_read32() in sector_erased()

The function sector_erased() is modified to not use pointer access, but to use the correct accessor functions. This fixes a problem on the t3corp board with the Xilinx DS617 flash chips. Here a board specific accessor function is needed to read from flash in 32bit mode. This patch enables such an operation mode.

---
 drivers/mtd/cfi_flash.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mtd/cfi_flash.c +3 -3
index e2317bd..c17c542 100644
@@ -1112,18 +1112,18 @@ static int sector_erased(flash_info_t *info, int i)
 {
 	int k;
 	int size;
-	volatile unsigned long *flash;
+	u32 *flash;
 
 	/*
 	 * Check if whole sector is erased
 	 */
 	size = flash_sector_size(info, i);
-	flash = (volatile unsigned long *) info->start[i];
+	flash = (u32 *)info->start[i];
 	/* divide by 4 for longword access */
 	size = size >> 2;
 
 	for (k = 0; k < size; k++) {
-		if (*flash++ != 0xffffffff)
+		if (flash_read32(flash++) != 0xffffffff)
 			return 0;	/* not erased */
 	}
 
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 cfi_flash: Use flash_read32() in sector_erased()

Quoted 5 lines · On Monday 25 October 2010 18:31:39 Stefan Roese wrote:

The function sector_erased() is modified to not use pointer access, but to use the correct accessor functions. This fixes a problem on the t3corp board with the Xilinx DS617 flash chips. Here a board specific accessor function is needed to read from flash in 32bit mode. This patch enables such an operation mode.

Applied to u-boot-cfi-flash/next. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de