Skip to contentSkip to conversation

xen34: fix crash

PATCH New Christoph Egger 1 participant 1 message Dec 17, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen34: fix crash

Hi,

attached patch backports c/s 21774 to Xen 3.4-testing.

-----------------------------------------------------------------------------------
mce: Replace BUG() with a console warning in the MCE handler.

If the hardware reports corrected errors that we didn't see through the status MSRs, complain on the console but don't BUG() the machine.

-----------------------------------------------------------------------------------

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
xen/arch/x86/cpu/mcheck/amd_nonfatal.c +9 -4
diff -r 14709d196e43 xen/arch/x86/cpu/mcheck/amd_nonfatal.c
@@ -155,14 +155,19 @@ static void mce_amd_work_fn(void *data)
 
 		/* HW does not count *all* kinds of correctable errors.
 		 * Thus it is possible, that the polling routine finds an
-		 * correctable error even if the HW reports nothing.
-		 * However, the other way around is not possible (= BUG).
-		 */ 
+		 * correctable error even if the HW reports nothing. */ 
 		if (counter > 0) {
 			/* HW reported correctable errors,
 			 * the polling routine did not find...
 			 */
-			BUG_ON(adjust == 0);
+			if (adjust == 0) {
+				printk("CPU counter reports %"PRIu32
+					" correctable hardware error%s that %s"
+					" not reported by the status MSRs\n",
+					counter,
+					(counter == 1 ? "" : "s"),
+					(counter == 1 ? "was" : "were"));
+			}
 			/* subtract 1 to not double count the error 
 			 * from the polling service routine */ 
 			adjust += (counter - 1);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel