WeTab device ID
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Andy,
Quoted 10 lines
Quoted 7 lines
Quoted 4 lines
Hi. I'm looking at getting a WeTab running right now and just found this patch set. It's a few weeks old now and not upstream yet, so before I start hacking at it I thought I should check with you to make sure there isn't a more current one available.
You find the tip of the mt work at
git://git.kernel.org/pub/scm/linux/kernel/git/rydberg/input-mt.gitThanks much. It works great, though on our WeTab it's missing the device ID of the part on the board. Patch below:
Thanks for the patch. Does the one below work for you?
Henrik
---
Quoted 1 line
From
a8b4613b6d7e7cf04a7335930e9c5c2fb44302d0Mon Sep 17 00:00:00 2001
From: Andy Ross <[email protected]>
Date: Thu, 16 Dec 2010 15:53:19 -0800
Subject: [PATCH] hid: egalax: Add support for Wetab (726b)
This patch adds support for another Wetab device (726b), and grabs it accordingly in hid-core.
--- drivers/hid/hid-core.c | 1 + drivers/hid/hid-egalax.c | 2 ++ drivers/hid/hid-ids.h | 1 + 3 files changed, 4 insertions(+), 0 deletions(-)
drivers/hid/hid-core.c +1 -0
@@ -1302,6 +1302,7 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH1) }, { HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2) }, { HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3) }, + { HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_BM084) }, { HID_USB_DEVICE(USB_VENDOR_ID_EZKEY, USB_DEVICE_ID_BTC_8193) }, { HID_USB_DEVICE(USB_VENDOR_ID_GAMERON, USB_DEVICE_ID_GAMERON_DUAL_PSX_ADAPTOR) },
drivers/hid/hid-egalax.c +2 -0
@@ -242,6 +242,8 @@ static const struct hid_device_id egalax_devices[] = { USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2) }, { HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3) }, + { HID_USB_DEVICE(USB_VENDOR_ID_DWAV, + USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4) }, { } }; MODULE_DEVICE_TABLE(hid, egalax_devices);
drivers/hid/hid-ids.h +1 -0
@@ -198,6 +198,7 @@#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH1 0x720c#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2 0x72a1#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3 0x480e +#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4 0x726b#define USB_VENDOR_ID_ELECOM 0x056e#define USB_DEVICE_ID_ELECOM_BM084 0x0061
Signature · 1 line
1.7.2.3
Quoted 1 line · Henrik Rydberg
Thanks for the patch. Does the one below work for you?
Looks like this is against more recent changes than I see in the "hid" branch of input-mt on kernel.org. I don't see a "...EGALAX_MULTITOUCH3" defined there. Maybe you missed a push? So not tested as-is, but certainly looks correct by inspection.
Andy
Quoted 7 lines · Andy Ross
Quoted 1 line · Henrik Rydberg
Thanks for the patch. Does the one below work for you?
Looks like this is against more recent changes than I see in the "hid" branch of input-mt on kernel.org. I don't see a "...EGALAX_MULTITOUCH3" defined there. Maybe you missed a push? So not tested as-is, but certainly looks correct by inspection.
Ah, the tip is actually at the next branch, never did say that.
Thanks,
Henrik
Quoted 10 lines · Henrik Rydberg
Quoted 7 lines · Andy Ross
Quoted 7 lines · Henrik Rydberg
Quoted 1 line
Quoted 1 line
Thanks for the patch. Does the one below work for you?
Looks like this is against more recent changes than I see in the "hid" branch of input-mt on kernel.org. I don't see a "...EGALAX_MULTITOUCH3" defined there. Maybe you missed a push? So not tested as-is, but certainly looks correct by inspection.
Ah, the tip is actually at the next branch, never did say that.
OK, makes much more sense. Applies and works great, thanks.
Andy
Quoted 22 lines · Henrik Rydberg
Hi Andy,
Quoted 10 lines
Quoted 7 lines
Quoted 4 lines
Hi. I'm looking at getting a WeTab running right now and just found this patch set. It's a few weeks old now and not upstream yet, so before I start hacking at it I thought I should check with you to make sure there isn't a more current one available.
You find the tip of the mt work at
git://git.kernel.org/pub/scm/linux/kernel/git/rydberg/input-mt.gitThanks much. It works great, though on our WeTab it's missing the device ID of the part on the board. Patch below:
Thanks for the patch. Does the one below work for you?
Henrik
---Quoted 1 line
From
a8b4613b6d7e7cf04a7335930e9c5c2fb44302d0Mon Sep 17 00:00:00 2001From: Andy Ross <[email protected]>
Date: Thu, 16 Dec 2010 15:53:19 -0800
Subject: [PATCH] hid: egalax: Add support for Wetab (726b)
Quoted 6 lines
This patch adds support for another Wetab device (726b), and grabs it accordingly in hid-core.
[[email protected]: rename and log message changes]Signed-off-by Andy Ross <[email protected]>Signed-off-by Henrik Rydberg <[email protected]>
I guess you are going to take it together with your pile to Dmitry, right Henrik?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
Quoted 7 lines
Quoted 7 lines
From: Andy Ross <[email protected]>
Date: Thu, 16 Dec 2010 15:53:19 -0800
Subject: [PATCH] hid: egalax: Add support for Wetab (726b)This patch adds support for another Wetab device (726b), and grabs it accordingly in hid-core.
Quoted 8 lines
Quoted 3 lines
[[email protected]: rename and log message changes]Signed-off-by Andy Ross <[email protected]>Signed-off-by Henrik Rydberg <[email protected]>Signed-off-by Jiri Kosina <[email protected]>I guess you are going to take it together with your pile to Dmitry, right Henrik?
Yep - thanks!
Henrik