Skip to contentSkip to conversation

batman-adv: Modifing hna_local_fill_buffer() return value

PATCH In review Antonio Quartulli 2 participants 2 messages Dec 18, 2010 – Dec 20, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 batman-adv: Modifing hna_local_fill_buffer() return value

After changeset 1888, the return value of hna_local_fill_buffer() has not been changed to _count_. In this way an eroneous num_hna was calculated before sending the new OGM packet.

---
 translation-table.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
translation-table.c +1 -1
index a19e16c..a633b5a 100644
@@ -162,7 +162,7 @@ int hna_local_fill_buffer(struct bat_priv *bat_priv,
                atomic_set(&bat_priv->hna_local_changed, 0);
 
        spin_unlock_bh(&bat_priv->hna_lhash_lock);
-       return i;
+       return count;
 }
 
 int hna_local_seq_print_text(struct seq_file *seq, void *offset)
Signature · 4 lines
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara
#1 lore raw
Quoted 14 lines · Antonio Quartulli

After changeset 1888, the return value of hna_local_fill_buffer() has not been changed to _count_. In this way an eroneous num_hna was calculated before sending the new OGM packet.

---
 translation-table.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
translation-table.c +0 -0
index a19e16c..a633b5a 100644

translation-table.c int hna_local_fill_buffer(struct bat_priv *bat_priv, · line 168

Quoted 8 lines
translation-table.c +1 -1
@@ -162,7 +162,7 @@ int hna_local_fill_buffer(struct bat_priv *bat_priv,
                atomic_set(&bat_priv->hna_local_changed, 0);
 
        spin_unlock_bh(&bat_priv->hna_lhash_lock);
-       return i;
+       return count;
 }
 
 int hna_local_seq_print_text(struct seq_file *seq, void *offset)

Your mail program mangled the patch. Please use git-send-mail or check how to fix your mailing program (see for example Documentation/email-clients.txt inside the linux tree).

Also correct your DNS entries for DKIM (you seem to sign your mails with it) - they aren't available and every DKIM aware receiving server will not accept the mails without adsp._domainkey. and mail._domainkey. TXT DNS entries.

Best regards,
Sven