Skip to contentSkip to conversation

drm/i915: no LVDS on Intel SandyBridge SDVs

PATCH In review Jesse Barnes 4 participants 9 messages Dec 20, 2010 – Dec 22, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: no LVDS on Intel SandyBridge SDVs

Add a DMI match entry for the SDV to indicate it has no LVDS present.

drivers/gpu/drm/i915/intel_lvds.c +8 -0
index aa23070..2f383f0 100644
@@ -719,6 +719,14 @@ static const struct dmi_system_id intel_no_lvds[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
 		},
 	},
+	{
+		.callback = intel_no_lvds_dmi_callback,
+		.ident = "Intel SandyBridge",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SandyBridge Platform"),
+		},
+	},
 
 	{ }	/* terminating entry */
 };
maintainer
#2 lore raw
In reply to Jesse Barnes
Quoted 1 line · Jesse Barnes

Add a DMI match entry for the SDV to indicate it has no LVDS present.

Sounds wrong, generally the SDVs can get an LVDS panel plugged into them, so they have an LVDS connector.

I'd worry that this would break something upstream that isn't an SDV.

Dave.

Quoted 27 lines
drivers/gpu/drm/i915/intel_lvds.c +8 -0
index aa23070..2f383f0 100644
@@ -719,6 +719,14 @@ static const struct dmi_system_id intel_no_lvds[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
                },
        },
+       {
+               .callback = intel_no_lvds_dmi_callback,
+               .ident = "Intel SandyBridge",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "SandyBridge Platform"),
+               },
+       },
 

       { }     /* terminating entry */
 };
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 5 lines · On Tue, 21 Dec 2010 12:43:38 +1000 Dave Airlie <[email protected]> wrote:
Quoted 1 line · Jesse Barnes

Add a DMI match entry for the SDV to indicate it has no LVDS present.

Sounds wrong, generally the SDVs can get an LVDS panel plugged into them, so they have an LVDS connector.

Yeah I think there's actually a header on this board for LVDS so it would be better to have a way to detect that. I don't know what that method would be though...

Quoted 1 line

I'd worry that this would break something upstream that isn't an SDV.

This DMI info is specific to SandyBridge SDVs, I don't think that part of the BIOS is used as reference for other vendors.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#4 lore raw
Quoted 4 lines · Jesse Barnes
Quoted 1 line · On Tue, 21 Dec 2010 12:43:38 +1000 Dave Airlie <[email protected]> wrote:

On Tue, Dec 21, 2010 at 6:05 AM, Jesse Barnes <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Add a DMI match entry for the SDV to indicate it has no LVDS present.

Sounds wrong, generally the SDVs can get an LVDS panel plugged into them, so they have an LVDS connector.

Yeah I think there's actually a header on this board for LVDS so it would be better to have a way to detect that. I don't know what that method would be though...

I think once upon a time I found a reliable method in the docs:
intel_lvds_ddc_probe(). However that only seemed to work over GMBUS...

Jesse, can you try disabling bus->force_bit in intel_i2c.c and see if that probe method still works?
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#5 lore raw
Quoted 2 lines · Chris Wilson

I think once upon a time I found a reliable method in the docs:
intel_lvds_ddc_probe(). However that only seemed to work over GMBUS...

That probably depends on the panel having DDC, which many don't, right? Maybe we can assume the SDV panels do?

Signature · 1 line
[email protected]

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 7 lines · Keith Packard
Quoted 2 lines · Chris Wilson

I think once upon a time I found a reliable method in the docs:
intel_lvds_ddc_probe(). However that only seemed to work over GMBUS...

That probably depends on the panel having DDC, which many don't, right? Maybe we can assume the SDV panels do?

The test we do is simply whether the LVDS i2c pins are addressable. That requires differentiating between an IO error and a NAK, which at present is only possible using GMBUS. The reference to this method I found in the BIOS writers' guide, but of course that doesn't actually explain how it works (especially the significance of address 0xa0).
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#7 lore raw
Quoted 5 lines · Chris Wilson

The test we do is simply whether the LVDS i2c pins are addressable. That requires differentiating between an IO error and a NAK, which at present is only possible using GMBUS. The reference to this method I found in the BIOS writers' guide, but of course that doesn't actually explain how it works (especially the significance of address 0xa0).

I can't see how that would work without an i2c receiver on the DDC bus...

But, then, I've been surprised by DDC in the past, so perhaps it's worth a test on a device that has LVDS but does not have EDID.

Signature · 1 line
[email protected]

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw
Quoted 8 lines · Keith Packard
Quoted 5 lines · Chris Wilson

The test we do is simply whether the LVDS i2c pins are addressable. That requires differentiating between an IO error and a NAK, which at present is only possible using GMBUS. The reference to this method I found in the BIOS writers' guide, but of course that doesn't actually explain how it works (especially the significance of address 0xa0).

Quoted 5 lines

I can't see how that would work without an i2c receiver on the DDC bus...

But, then, I've been surprised by DDC in the past, so perhaps it's worth a test on a device that has LVDS but does not have EDID.

It works as far back as I can test, a 915GM without a VBIOS or EDID. I've had one person report that it can distinguish a phantom LVDS panel on one g33 based all-in-one computer. Though not all hardware is equal, and prudence suggests wider testing. ;-)
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre