Skip to contentSkip to conversation

mfd: Use dummy_irq_chip for tc3589x

PATCH In review Samuel Ortiz 2 participants 3 messages Dec 20, 2010 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: Use dummy_irq_chip for tc3589x

This also converts tc3589x to the new irq API.

---

Linus, this should go through your ux500-core branch as this is where the tc3589x rename happens.

(Patch resent with Linus Walleij's correct email address)

---
 drivers/mfd/tc3589x.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
drivers/mfd/tc3589x.c +1 -12
index 32291fe..112efd3 100644
@@ -170,17 +170,6 @@ again:
 	return IRQ_HANDLED;
 }
 
-static void tc3589x_irq_dummy(unsigned int irq)
-{
-	/* No mask/unmask at this level */
-}
-
-static struct irq_chip tc3589x_irq_chip = {
-	.name	= "tc3589x",
-	.mask	= tc3589x_irq_dummy,
-	.unmask	= tc3589x_irq_dummy,
-};
-
 static int tc3589x_irq_init(struct tc3589x *tc3589x)
 {
 	int base = tc3589x->irq_base;
@@ -188,7 +177,7 @@ static int tc3589x_irq_init(struct tc3589x *tc3589x)
 
 	for (irq = base; irq < base + TC3589x_NR_INTERNAL_IRQS; irq++) {
 		set_irq_chip_data(irq, tc3589x);
-		set_irq_chip_and_handler(irq, &tc3589x_irq_chip,
+		set_irq_chip_and_handler(irq, &dummy_irq_chip,
 					 handle_edge_irq);
 		set_irq_nested_thread(irq, 1);
 #ifdef CONFIG_ARM
Signature · 5 lines
1.7.2.3

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
#1 lore raw

[Samuel]

Quoted 8 lines

This also converts tc3589x to the new irq API.

---

Linus, this should go through your ux500-core branch as this is where the
tc3589x rename happens.

OK applied and pushed to ux500-core, you can drop this tc35x stuff off the MFD tree now..

Yours,
Linus Walleij

#2 lore raw
Quoted 7 lines · Linus WALLEIJ

[Samuel]

Quoted 5 lines

This also converts tc3589x to the new irq API.

---

Quoted 6 lines
Quoted 3 lines

Linus, this should go through your ux500-core branch as this is where the
tc3589x rename happens.

OK applied and pushed to ux500-core, you can drop this tc35x stuff off the MFD tree now..

Done, thanks a lot.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/