Skip to contentSkip to conversation

usb: Add streams support to epautoconf.

PATCH [email protected] 2 participants 2 messages Dec 20, 2010 Arm Qualcomm mailing list

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · Greg KH

What do you exactly mean by "proprietary search algorithm"?

Our implementation for finding an EP with the required number of streams may not fit the needs and platform definitions of all controllers. For example, having the minimum number of streams as a parameter will allow controllers to compromise on the number of required streams in case there is no EP that answers their first request.
At the beginning of usb_ep_autoconfig we could see many if statements for finding the fitting EP for several controllers (for example gadget_is_net2280). The new gadget op will prevent having additional if statements in the usb_ep_autoconfig in case a different search is needed. Thanks,
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

#1 lore raw
Quoted 11 lines · On Mon, Dec 20, 2010 at 11:33:44AM -0800, [email protected] wrote:
Quoted 2 lines · Greg KH

What do you exactly mean by "proprietary search algorithm"?

Our implementation for finding an EP with the required number of streams may not fit the needs and platform definitions of all controllers. For example, having the minimum number of streams as a parameter will allow controllers to compromise on the number of required streams in case there is no EP that answers their first request.
At the beginning of usb_ep_autoconfig we could see many if statements for finding the fitting EP for several controllers (for example gadget_is_net2280). The new gadget op will prevent having additional if statements in the usb_ep_autoconfig in case a different search is needed.

Ok, but please note the word of "proprietary" usually means something else when talking about kernel code (i.e. licensing issues.)

I'll be glad to take this type of patch when you also provide a patch that uses the callback, but not before then.

thanks,

greg k-h