Skip to contentSkip to conversation

New package: bwm-ng

PATCH New keguang.zhang at gmail.com 3 participants 5 messages Dec 21, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 New package: bwm-ng

From: Kelvin Cheung <[email protected]>

Add new package: bwm-ng

Bandwidth Monitor NG is a small and console-based live network and disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.

---
 package/Config.in        |    1 +
 package/bwm-ng/Config.in |    7 +++++++
 package/bwm-ng/bwm-ng.mk |   16 ++++++++++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 package/bwm-ng/Config.in
 create mode 100644 package/bwm-ng/bwm-ng.mk
package/Config.in +1 -0
index d3ae75e..2648062 100644
@@ -148,6 +148,7 @@ endmenu
 
 menu "Hardware handling"
 source "package/acpid/Config.in"
+source "package/bwm-ng/Config.in"
 source "package/cdrkit/Config.in"
 source "package/cramfs/Config.in"
 source "package/dbus/Config.in"
package/bwm-ng/Config.in new file +7 -0
new file mode 100644
index 0000000..f2f8b12
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_BWM_NG
+	bool "bwm-ng"
+	help
+	  Bandwidth Monitor NG is a small and console-based live network and
+	  disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.
+
+	  http://sourceforge.net/projects/bwmng/
package/bwm-ng/bwm-ng.mk new file +16 -0
new file mode 100644
index 0000000..7fd5b38
@@ -0,0 +1,16 @@
+#############################################################
+#
+# bwm-ng
+#
+#############################################################
+BWM_NG_VERSION:=0.6
+BWM_NG:=bwm-ng-$(BWM_NG_VERSION).tar.gz
+BWM_NG_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/bwmng/bwmng/0.6/
+BWM_NG_CONF_OPT = --with-procnetdev --with-diskstats
+
+ifeq ($(BR2_PACKAGE_NCURSES),y)
+BWM_NG_CONF_OPT += --with-ncurses
+BWM_NG_DEPENDENCIES += ncurses
+endif
+
+$(eval $(call AUTOTARGETS,package,bwm-ng))
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 New package: bwm-ng

Hi Thomas,

Please review this patch.
Thanks!

2010/12/21 <[email protected]>

Quoted 70 lines

From: Kelvin Cheung <[email protected]>

Add new package: bwm-ng

Bandwidth Monitor NG is a small and console-based live network and disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.

---
 package/Config.in        |    1 +
 package/bwm-ng/Config.in |    7 +++++++
 package/bwm-ng/bwm-ng.mk |   16 ++++++++++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 package/bwm-ng/Config.in
 create mode 100644 package/bwm-ng/bwm-ng.mk
package/Config.in +1 -0
index d3ae75e..2648062 100644
@@ -148,6 +148,7 @@ endmenu
 
 menu "Hardware handling"
 source "package/acpid/Config.in"
+source "package/bwm-ng/Config.in"
 source "package/cdrkit/Config.in"
 source "package/cramfs/Config.in"
 source "package/dbus/Config.in"
package/bwm-ng/Config.in new file +4 -0
new file mode 100644
index 0000000..f2f8b12
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_BWM_NG
+       bool "bwm-ng"
+       help
+         Bandwidth Monitor NG is a small and console-based live network

and
+ disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and
others.

package/bwm-ng/Config.in new file +2 -0
+
+         http://sourceforge.net/projects/bwmng/
package/bwm-ng/bwm-ng.mk new file +8 -0
new file mode 100644
index 0000000..7fd5b38
@@ -0,0 +1,16 @@
+#############################################################
+#
+# bwm-ng
+#
+#############################################################
+BWM_NG_VERSION:=0.6
+BWM_NG:=bwm-ng-$(BWM_NG_VERSION).tar.gz
+BWM_NG_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).

dl.sourceforge.net/project/bwmng/bwmng/0.6/

package/bwm-ng/bwm-ng.mk new file +8 -1
+BWM_NG_CONF_OPT = --with-procnetdev --with-diskstats
+
+ifeq ($(BR2_PACKAGE_NCURSES),y)
+BWM_NG_CONF_OPT += --with-ncurses
+BWM_NG_DEPENDENCIES += ncurses
+endif
+
+$(eval $(call AUTOTARGETS,package,bwm-ng))
--

1.7.1

Signature · 5 lines
Best Regards!
Kelvin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101221/aa1bbad1/attachment.html>
#2 lore raw

PATCH 1/1 New package: bwm-ng

In reply to keguang.zhang at gmail.com

Hi,

some comments for use ncurses:
Seems this package should be build with or without ncurses. What about add some menu entry for that? Like for example qt. Normally user didn't check mk file just select package.

Quoted 34 lines · On Tue, Dec 21, 2010 at 9:55 AM, <[email protected]> wrote:

From: Kelvin Cheung <[email protected]>

Add new package: bwm-ng

Bandwidth Monitor NG is a small and console-based live network and disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.

---

?package/Config.in ? ? ? ?| ? ?1 +
?package/bwm-ng/Config.in | ? ?7 +++++++
?package/bwm-ng/bwm-ng.mk | ? 16 ++++++++++++++++

?3 files changed, 24 insertions(+), 0 deletions(-) ?create mode 100644 package/bwm-ng/Config.in ?create mode 100644 package/bwm-ng/bwm-ng.mk

package/Config.in +0 -0
index d3ae75e..2648062 100644
@@ -148,6 +148,7 @@ endmenu
 

?menu "Hardware handling"
?source "package/acpid/Config.in"
+source "package/bwm-ng/Config.in"
?source "package/cdrkit/Config.in"
?source "package/cramfs/Config.in"
?source "package/dbus/Config.in"

package/bwm-ng/Config.in new file +0 -0
new file mode 100644
index 0000000..f2f8b12

package/bwm-ng/Config.in line 7

Quoted 7 lines
package/bwm-ng/Config.in new file +7 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_BWM_NG
+ ? ? ? bool "bwm-ng"
+ ? ? ? help
+ ? ? ? ? Bandwidth Monitor NG is a small and console-based live network and
+ ? ? ? ? disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.
+
+ ? ? ? ? http://sourceforge.net/projects/bwmng/

Add selection for ncurses:
+config BR2_PACKAGE_BWM_NG_NCURSES
+ bool "bwm_ng with ncurses"
+ depends on BR2_PACKAGE_BWM_NG
+ select BR2_PACKAGE_NCURSES

Quoted 7 lines
package/bwm-ng/bwm-ng.mk new file +1 -0
new file mode 100644
index 0000000..7fd5b38
@@ -0,0 +1,16 @@
+#############################################################

package/bwm-ng/bwm-ng.mk line 11

Quoted 10 lines
package/bwm-ng/bwm-ng.mk new file +10 -0
+#
+# bwm-ng
+#
+#############################################################
+BWM_NG_VERSION:=0.6
+BWM_NG:=bwm-ng-$(BWM_NG_VERSION).tar.gz
+BWM_NG_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/bwmng/bwmng/0.6/
+BWM_NG_CONF_OPT = --with-procnetdev --with-diskstats
+
+ifeq ($(BR2_PACKAGE_NCURSES),y)

use instead: +ifeq($(BR2_PACKAGE_BWM_NG_NCURSES),y)

Quoted 8 lines
package/bwm-ng/bwm-ng.mk new file +5 -1
+BWM_NG_CONF_OPT += --with-ncurses
+BWM_NG_DEPENDENCIES += ncurses
+endif
+
+$(eval $(call AUTOTARGETS,package,bwm-ng))
--

1.7.1

Quoted 5 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

thanks,

marek

Signature · 10 lines
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
#3 lore raw

PATCH 1/1 New package: bwm-ng

Hello,

Quoted 4 lines · On Tue, 21 Dec 2010 11:32:38 +0100 Belisko Marek <[email protected]>…

some comments for use ncurses:
Seems this package should be build with or without ncurses. What about add some menu entry for that? Like for example qt. Normally user didn't check mk file just select package.

For many packages, we do as Kelvin did initially: if the dependency is available, we use it, if not, we silently work without it. Admittedly, it's a bit "hidden" from the user, but that's the only solution to not have hundreds or thousands of options in the configuration interface.

So I'd prefer to keep what Kelvin did on this.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 New package: bwm-ng

So, will this patch be accepted ?

2010/12/21 Thomas Petazzoni <[email protected]>

Quoted 26 lines

Hello,

Quoted 4 lines · On Tue, 21 Dec 2010 11:32:38 +0100 Belisko Marek <[email protected]>…

some comments for use ncurses:
Seems this package should be build with or without ncurses. What about add some menu entry for that? Like for example qt. Normally user didn't check mk file just select package.

For many packages, we do as Kelvin did initially: if the dependency is available, we use it, if not, we silently work without it. Admittedly, it's a bit "hidden" from the user, but that's the only solution to not have hundreds or thousands of options in the configuration interface.

So I'd prefer to keep what Kelvin did on this.

Regards,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Signature · 5 lines
Best Regards!
Kelvin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101221/0e19e0f8/attachment.html>