USB: add support for Dream Cheeky DL100B Webmail Notifier (1d34:0004)
PATCH v3 1/1 USB: add support for Dream Cheeky DL100B Webmail Notifier (1d34:0004)
From: Melchior FRANZ <[email protected]>
So far the USBLED driver only supports Delcom's "USB Visual Signal Indicator" (http://www.delcomproducts.com/products_USBLMP.asp). The driver generates virtual files "red", "green", and "blue" under the device's /sys/ directory, where color values can be read from and written to.
This patch adds support for Dream Cheeky's "DL100B Webmail Notifier"
(http://www.dreamcheeky.com/webmail-notifier -- available from several shops, such as http://www.conrad.at/ce/de/product/777048/USB-WEBMAIL).
This device isn't as pretty as Delcom's, but it's *far* cheaper, and its 3 LEDs can be set in 32 brightness steps each. The grey envelope contour can easily be removed, leaving a rather neutral white box (with a few small holes), which is useful for generic signalling purposes. Of course, the small circuit board can easily be put into a prettier case.
The DL100B device pretends to be a HID, but the HID descriptor shows that it's not overly useful as such (see below). The patch therefore removes the "HID-ness" (hid-core.c, hid-ids.h), and adds the necessary commands to usbled.c. The protocol info comes from the developer's manual that Dream Cheeky kindly provided (815DeveloperManual.pdf).
HID descriptor:
0: 05 01 Usage Page 'Generic Desktop Controls' 2: 09 10 Usage 'Reserved' 4: a1 01 Collection 'Application (mouse, keyboard)' 6: 05 00 Usage Page 'Undefined' 8: 19 10 Usage Minimum = 16 10: 29 11 Usage Maximum = 17 12: 15 00 Logical Minimum = 0 14: 25 0f Logical Maximum = 15 16: 75 08 Report Size = 8 18: 95 08 Report Count = 8 20: 91 02 Output data *var abs lin pref-state null-pos non-vol bit-field 22: 19 10 Usage Minimum = 16 24: 29 11 Usage Maximum = 17 26: 15 00 Logical Minimum = 0 28: 25 0f Logical Maximum = 15 30: 75 08 Report Size = 8 32: 95 08 Report Count = 8 34: 81 00 Input data array abs lin pref-state null-pos non-vol bit-field
36: c0 End Collection
---
Same as v2, except:
- version number removed from usbled.c file header
- garbage removed from corrupted diff (sorry about that)
Please review yet again and consider for inclusion. (The patch is diffed against 2.6.36.2.)
m. :-)
drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 2 + drivers/usb/misc/usbled.c | 118 ++++++++++++++++++++++++++++++++++----------- 3 files changed, 93 insertions(+), 28 deletions(-)
drivers/hid/hid-core.c +1 -0
@@ -1594,6 +1594,7 @@ static const struct hid_device_id hid_ignore_list[] = { { HID_USB_DEVICE(USB_VENDOR_ID_DEALEXTREAME, USB_DEVICE_ID_DEALEXTREAME_RADIO_SI4701) }, { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EARTHMATE) }, { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) }, + { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) }, { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) }, { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) }, { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) },
drivers/hid/hid-ids.h +2 -0
@@ -197,6 +197,8 @@#define USB_VENDOR_ID_ELECOM 0x056e#define USB_DEVICE_ID_ELECOM_BM084 0x0061 +#define USB_VENDOR_ID_DREAM_CHEEKY 0x1d34 +#define USB_VENDOR_ID_ELO 0x04E7#define USB_DEVICE_ID_ELO_TS2700 0x0020
drivers/usb/misc/usbled.c +90 -28
164 lines not on this page · raw message
Quoted 7 lines · Melchior FRANZ
Same as v2, except:
- version number removed fromusbled.cfile header
- garbage removed from corrupted diff (sorry about that)Please review yet again and consider for inclusion. (The patch is diffed against 2.6.36.2.)
I've applied this, but I now get the following build warning:
drivers/usb/misc/usbled.c: In function ‘change_color’:drivers/usb/misc/usbled.c:48:6: warning: ‘retval’ may be used uninitialized in this function
Care to send a follow-on patch to fix this up? Just set retval to 0 at the start of that function and it should be fine.
thanks,
greg k-h