Skip to contentSkip to conversation

ath5k: Move mac80211 functions into new file

PATCH In review Bruno Randolf 5 participants 5 messages Dec 22, 2010 – Dec 24, 2010 Atheros ATH5K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath5k: Move mac80211 functions into new file

Move mac80211 functions into new file mac80211-ops.c to have a better separation and to make base.c smaller.

---
 drivers/net/wireless/ath/ath5k/Makefile       |    1 
 drivers/net/wireless/ath/ath5k/base.c         |  763 ++-----------------------
 drivers/net/wireless/ath/ath5k/mac80211-ops.c |  774 +++++++++++++++++++++++++
 3 files changed, 825 insertions(+), 713 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath5k/mac80211-ops.c
drivers/net/wireless/ath/ath5k/Makefile +1 -0
index 67dd9fd..f60b389 100644
@@ -14,6 +14,7 @@ ath5k-y				+= led.o
 ath5k-y				+= rfkill.o
 ath5k-y				+= ani.o
 ath5k-y				+= sysfs.o
+ath5k-y				+= mac80211-ops.o
 ath5k-$(CONFIG_ATH5K_DEBUG)	+= debug.o
 ath5k-$(CONFIG_ATH5K_AHB)	+= ahb.o
 ath5k-$(CONFIG_ATH5K_PCI)	+= pci.o
drivers/net/wireless/ath/ath5k/base.c +50 -713

856 lines not on this page · raw message

drivers/net/wireless/ath/ath5k/mac80211-ops.c new file +774 -0

774 lines not on this page · raw message

Tested-by on v1 1/1
#1 lore raw
Quoted 11 lines · Bruno Randolf

Move mac80211 functions into new file mac80211-ops.c to have a better separation and to make base.c smaller.

---
 drivers/net/wireless/ath/ath5k/Makefile       |    1 drivers/net/wireless/ath/ath5k/base.c         |  763 ++----------------------- drivers/net/wireless/ath/ath5k/mac80211-ops.c |  774 +++++++++++++++++++++++++

 3 files changed, 825 insertions(+), 713 deletions(-)

 create mode 100644 drivers/net/wireless/ath/ath5k/mac80211-ops.c

Tested against linux-next (next-20101221) and the following additional ath5k and mac80211 patches:

$ ls ath5k-fix/*.patch
ath5k-fix/1-5-ath5k-Simplify-powertable-recalculation.patch
ath5k-fix/2-5-ath5k-Separate-powertable-setup-and-writing.patch
ath5k-fix/3-5-ath5k-Track-current-TX-power-separately-from-max-TX-power.patch
ath5k-fix/4-5-ath5k-Remove-ATH5K_INI_RFGAIN-defines-use-band-instead.patch
ath5k-fix/5-5-ath5k-Use-helper-function-to-get-eeprom-mode-from-channel.patch
ath5k-fix/ath5k-Move-mac80211-functions-into-new-file.patc
$ ls mac80211-fix/*.patch
mac80211-fix/mac80211-minstrel-honor-max-retry-counts-from-cfg80211.patch

Feel free to add:

- Sedat -

#2 lore raw
Quoted 10 lines · Sedat Dilek
Quoted 9 lines · Bruno Randolf

Move mac80211 functions into new file mac80211-ops.c to have a better separation and to make base.c smaller.

---
 drivers/net/wireless/ath/ath5k/Makefile       |    1 drivers/net/wireless/ath/ath5k/base.c         |  763 ++----------------------- drivers/net/wireless/ath/ath5k/mac80211-ops.c |  774 +++++++++++++++++++++++++

 3 files changed, 825 insertions(+), 713 deletions(-)

How about just a main.c ?

Luis

maintainer
#3 lore raw

2010/12/22 Luis R. Rodriguez <[email protected]>:

Quoted 12 lines · Sedat Dilek
Quoted 10 lines · Bruno Randolf
Quoted 9 lines

Move mac80211 functions into new file mac80211-ops.c to have a better separation and to make base.c smaller.

---
 drivers/net/wireless/ath/ath5k/Makefile       |    1 drivers/net/wireless/ath/ath5k/base.c         |  763 ++----------------------- drivers/net/wireless/ath/ath5k/mac80211-ops.c |  774 +++++++++++++++++++++++++

 3 files changed, 825 insertions(+), 713 deletions(-)
Quoted 3 lines

How about just a main.c ?

 Luis

We already have base.c, having both main.c and base.c could be misleading, i think mac80211-ops.c is fine.

Signature · 3 lines
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
#4 lore raw
In reply to Bruno Randolf
Quoted 2 lines · Bruno Randolf

Move mac80211 functions into new file mac80211-ops.c to have a better separation and to make base.c smaller.

Or we could move the non-ops to a different file...

BTW I just rebased my sta PS code and I'll be working on it this holiday week.. I guess I'll re-rebase it whenever I get it working.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com