Skip to contentSkip to conversation

mct_u232: added _ioctl and _get_icount functions

PATCH In review Tsozik 2 participants 2 messages Dec 27, 2010

lore
Share & tools
lore

Tsozik

author
#0 lore raw

PATCH 1/1 mct_u232: added _ioctl and _get_icount functions

Pete, Greg,

Again thank you very much for your valuable feedback. I generated another patch (based on linux-2.6.37-rc7) and ran it against scripts/checkpatch.pl script which didn't produce any errors or warnings:

[vtsozik@SR71 2.6.37-rc7]$ /usr/src/kernels/2.6.37-rc7/scripts/checkpatch.pl mct_u232.c.patch.submit
total: 0 errors, 0 warnings, 191 lines checked

mct_u232.c.patch.submit has no obvious style problems and is ready for submission. [vtsozik@SR71 2.6.37-rc7]$

I attached mct_u232.c.patch.submit file to this email, so tabs will not be expanded into spaces. Please let me know if there's anything else I need to correct before it can be rolled out,

Again thank you for your help with this,
Vadim.

#1 lore raw
Quoted 2 lines · On Sun, 26 Dec 2010 18:58:46 -0800 (PST) Tsozik <[email protected]> wrote:

Please let me know if there's anything else I need to correct before it can be rolled out,

I am hardly an expert here, but I looked it up as much as I could, and this looks like a wrong way to do it:

Review static int mct_u232_get_modem_stat(struc · line 402

Quoted 8 lines
(quoted diff) +4 -0
@@ -386,27 +396,41 @@ static int mct_u232_get_modem_stat(struc
 	/* Translate Control Line states */
+	if (msr & MCT_U232_MSR_DSR) {
 		*control_state |=  TIOCM_DSR;
+		icount->dsr++;
+	} else {
 		*control_state &= ~TIOCM_DSR;
+	}

Unfortunately, Kerrisk's manpages do not seem to offer an authoritative definition, but the expectations across the code seems that the counter actually counts the changes. I know that some people talked about counting "interrupts", but the way it's implemented in trustworthy drivers suggests something like this:

	unsigned int old_ctl_state;

	old_ctl_state = *control_state;
	if (msr & MCT_U232_MSR_DSR)
		*control_state |=  TIOCM_DSR;
	else
		*control_state &= ~TIOCM_DSR;
	if (old_ctl_state != *control_state)
		icount->dsr++;
	...... repeat for all bits

E.g. for DSR going down too, although perhaps I'm not suggesting the best way to do it. Could you re-implement it like the above and check that your radiation counter works the same with it and when driven by a built-in serial port?

Another thing, you should take priv->lock around fetching of mct_u232_port->icount in mct_u232_ioctl. It seems superfluous, I know, because the API itself is racy, but just to be nice and doing the expected thing...

-- Pete