fs: FS_POSIX_ACL does not depend on BLOCK
PATCH 1/1 fs: FS_POSIX_ACL does not depend on BLOCK
From: Randy Dunlap <[email protected]>
- Fix a kconfig unmet dependency warning.
- Update the comment that identifies which filesystems use POSIX ACL utility routines.
- Move the FS_POSIX_ACL symbol outside of the BLOCK symbol if/endif block because its functions do not depend on BLOCK and some of the filesystems that use it do not depend on BLOCK.
warning: (GENERIC_ACL && JFFS2_FS_POSIX_ACL && NFSD_V4 && NFS_ACL_SUPPORT && 9P_FS_POSIX_ACL) selects FS_POSIX_ACL which has unmet direct dependencies (BLOCK)
--- fs/Kconfig | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
fs/Kconfig +9 -9
@@ -30,15 +30,6 @@ config FS_MBCACHE source "fs/reiserfs/Kconfig" source "fs/jfs/Kconfig" -config FS_POSIX_ACL -# Posix ACL utility routines (for now, only ext2/ext3/jfs/reiserfs/nfs4) -# -# NOTE: you can implement Posix ACLs without these helpers (XFS does). -# Never use this symbol for ifdefs. -# - bool - default n - source "fs/xfs/Kconfig" source "fs/gfs2/Kconfig" source "fs/ocfs2/Kconfig"
@@ -47,6 +38,15 @@ source "fs/nilfs2/Kconfig" endif # BLOCK +config FS_POSIX_ACL +# Posix ACL utility routines +# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p) +# +# NOTE: you can implement Posix ACLs without these helpers. +# Never use this symbol for ifdefs. +# + def_bool n + config EXPORTFS tristate
fs/Kconfig source "fs/nilfs2/Kconfig" · line 49
Quoted 9 lines · Randy Dunlap
fs/Kconfig +9
-0+config FS_POSIX_ACL +# Posix ACL utility routines +# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p) +# +# NOTE: you can implement Posix ACLs without these helpers. +# Never use this symbol for ifdefs. +# + def_bool n +
I'd drop the list of filesystems, and move the comment above the symbol, e.g:
#
# Posix ACL utility routines
#
# Note: Posix ACLs can be implemented without these helpers. Never use
# this symbol for ifdefs in core code. # config FS_POSIX_ACL def_bool n
Il 02/01/2011 07:29, Christoph Hellwig ha scritto:
Quoted 14 lines · Randy Dunlap
fs/Kconfig source "fs/nilfs2/Kconfig" · line 49
Quoted 9 lines
fs/Kconfig +9
-0+config FS_POSIX_ACL +# Posix ACL utility routines +# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p) +# +# NOTE: you can implement Posix ACLs without these helpers. +# Never use this symbol for ifdefs. +# + def_bool n +I'd drop the list of filesystems, and move the comment above the symbol, e.g:
Quoted 9 lines
#
# Posix ACL utility routines
#
# Note: Posix ACLs can be implemented without these helpers. Never use# this symbol for ifdefs in core code. # config FS_POSIX_ACL def_bool n
I agree, the list can be a maintaince overhead.
Marco
PATCH v2 1/1 fs: FS_POSIX_ACL does not depend on BLOCK
From: Randy Dunlap <[email protected]>
- Fix a kconfig unmet dependency warning.
- Remove the comment that identifies which filesystems use POSIX ACL utility routines.
- Move the FS_POSIX_ACL symbol outside of the BLOCK symbol if/endif block because its functions do not depend on BLOCK and some of the filesystems that use it do not depend on BLOCK.
warning: (GENERIC_ACL && JFFS2_FS_POSIX_ACL && NFSD_V4 && NFS_ACL_SUPPORT && 9P_FS_POSIX_ACL) selects FS_POSIX_ACL which has unmet direct dependencies (BLOCK)
--- fs/Kconfig | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
fs/Kconfig +8 -9
@@ -30,15 +30,6 @@ config FS_MBCACHE source "fs/reiserfs/Kconfig" source "fs/jfs/Kconfig" -config FS_POSIX_ACL -# Posix ACL utility routines (for now, only ext2/ext3/jfs/reiserfs/nfs4) -# -# NOTE: you can implement Posix ACLs without these helpers (XFS does). -# Never use this symbol for ifdefs. -# - bool - default n - source "fs/xfs/Kconfig" source "fs/gfs2/Kconfig" source "fs/ocfs2/Kconfig"
@@ -47,6 +38,14 @@ source "fs/nilfs2/Kconfig" endif # BLOCK +# Posix ACL utility routines +# +# Note: Posix ACLs can be implemented without these helpers. Never use +# this symbol for ifdefs in core code. +# +config FS_POSIX_ACL + def_bool n + config EXPORTFS tristate