Skip to contentSkip to conversation

mpt2sas: Description Patch

PATCH In review Kashyap, Desai 2 participants 4 messages Jan 4, 2011 – Jan 18, 2011 SCSI

lore
Share & tools
lore
#0 lore raw

cover mpt2sas: Description Patch

MPT2SAS driver changes.
These patches are taken from 2.6.37-rc5. Please consider this patch set for next kernel release.

[PATCH 01/10] mpt2sas: Device removal handshake even though the PHYSTATUS_VACANT bit is set in the PhyStatus
[PATCH 02/10] mpt2sas: Internal device reset complete event is not supported for older firmware prior to MPI Rev K
[PATCH 03/10] mpt2sas: Correct resizing calculation for max_queue_depth [PATCH 04/10] mpt2sas: Revision P MPI Header Update
[PATCH 05/10] mpt2sas: Add support for Customer specific branding messages [PATCH 06/10] mpt2sas: Fix the race between broadcast asyn event and scsi command completion.
[PATCH 07/10] mpt2sas: Prevent access to freed memory from port enable process [PATCH 08/10] mpt2sas: Basic Code Cleanup in mpt2sas_base
[PATCH 09/10] mpt2sas: Call the _scsih_ir_shutdown prior to reporting the volumes missing from the OS
[PATCH 10/10] mpt2sas: Bump version 08.100.00.00

---

#1 lore raw
Quoted 3 lines · Desai

MPT2SAS driver changes.
These patches are taken from 2.6.37-rc5. Please consider this patch set for next kernel release.

That's a bit unlikely considering we're probably only a day or so away from a 2.6.37 kernel release. It takes time to go through the linux-next and code inspection process.

I can add them to scsi-misc with a cc stable (at least for the ones that are bug fixes):

Quoted 6 lines

[PATCH 01/10] mpt2sas: Device removal handshake even though the PHYSTATUS_VACANT bit is set in the PhyStatus
[PATCH 02/10] mpt2sas: Internal device reset complete event is not supported for older firmware prior to MPI Rev K
[PATCH 03/10] mpt2sas: Correct resizing calculation for max_queue_depth [PATCH 04/10] mpt2sas: Revision P MPI Header Update

This is an update not a bug fix

Quoted 1 line

[PATCH 05/10] mpt2sas: Add support for Customer specific branding messages

This is an update, not a bug fix

Quoted 2 lines

[PATCH 06/10] mpt2sas: Fix the race between broadcast asyn event and scsi command completion.

This patch seems to contain half the branding stuff from 5/10 ... please separate them

Quoted 2 lines

[PATCH 07/10] mpt2sas: Prevent access to freed memory from port enable process [PATCH 08/10] mpt2sas: Basic Code Cleanup in mpt2sas_base

A code cleanup is not a bug fix.

Quoted 5 lines

[PATCH 09/10] mpt2sas: Call the _scsih_ir_shutdown prior to reporting the volumes missing from the OS
[PATCH 10/10] mpt2sas: Bump version 08.100.00.00

So that's 1-3 bug fixes, rework 5,6 so it becomes a clean separation between enhancement and bug fix and 7,9 are bug fixes.

James

#2 lore raw
Quoted 52 lines

-----Original Message-----
From: James Bottomley [mailto:[email protected]]
Sent: Tuesday, January 04, 2011 9:31 PM
To: Desai, Kashyap
Cc: [email protected]; Moore, Eric; Prakash, Sathya
Subject: Re: [PATCH 0/10] mpt2sas: Description Patch

Quoted 3 lines · Desai

MPT2SAS driver changes.
These patches are taken from 2.6.37-rc5. Please consider this patch set for next kernel release.

That's a bit unlikely considering we're probably only a day or so away from a 2.6.37 kernel release. It takes time to go through the linux-next and code inspection process.

I can add them to scsi-misc with a cc stable (at least for the ones that
are bug fixes):

Quoted 5 lines

[PATCH 01/10] mpt2sas: Device removal handshake even though the PHYSTATUS_VACANT bit is set in the PhyStatus
[PATCH 02/10] mpt2sas: Internal device reset complete event is not supported for older firmware prior to MPI Rev K
[PATCH 03/10] mpt2sas: Correct resizing calculation for

max_queue_depth

Quoted 1 line

[PATCH 04/10] mpt2sas: Revision P MPI Header Update

This is an update not a bug fix

Quoted 1 line

[PATCH 05/10] mpt2sas: Add support for Customer specific branding

messages

This is an update, not a bug fix

Quoted 1 line

[PATCH 06/10] mpt2sas: Fix the race between broadcast asyn event and

scsi

Quoted 1 line

command completion.

This patch seems to contain half the branding stuff from 5/10 ... please
separate them

Quoted 1 line

[PATCH 07/10] mpt2sas: Prevent access to freed memory from port

enable process

Quoted 1 line

[PATCH 08/10] mpt2sas: Basic Code Cleanup in mpt2sas_base

A code cleanup is not a bug fix.

Quoted 1 line

[PATCH 09/10] mpt2sas: Call the _scsih_ir_shutdown prior to reporting

Quoted 8 lines

the

Quoted 4 lines

volumes missing from the OS
[PATCH 10/10] mpt2sas: Bump version 08.100.00.00

So that's 1-3 bug fixes, rework 5,6 so it becomes a clean separation between enhancement and bug fix and 7,9 are bug fixes.

James Thanks for quick review and giving me suggestion for separation of fixes vs updates. There are some unusual things in patch-6. I will resend patch-6.

Here, I have re-listed fixes.
[PATCH 01/10] mpt2sas: Device removal handshake even though the ... [PATCH 02/10] mpt2sas: Internal device reset complete event is not ... [PATCH 03/10] mpt2sas: Correct resizing calculation for max_queue_depth [PATCH 06/10] mpt2sas: Fix the race between broadcast asyn event and scsi .. [PATCH 07/10] mpt2sas: Prevent access to freed memory from port enable process .. [PATCH 09/10] mpt2sas: Call the _scsih_ir_shutdown prior to reporting the ...

These are updates.
[PATCH 04/10] mpt2sas: Revision P MPI Header Update
[PATCH 05/10] mpt2sas: Add support for Customer specific branding messages [PATCH 08/10] mpt2sas: Basic Code Cleanup in mpt2sas_base

Thanks, Kashyap

Quoted 3 lines

James

#3 lore raw
In reply to Kashyap, Desai

James,

Any feedback on this patch set. ?

Thanks, Kashyap

Quoted 39 lines

-----Original Message-----
From: [email protected] [mailto:linux-scsi- [email protected]] On Behalf Of Kashyap, Desai
Sent: Tuesday, January 04, 2011 11:31 AM
To: [email protected]
Cc: [email protected]; Moore, Eric; Prakash, Sathya
Subject: [PATCH 0/10] mpt2sas: Description Patch

MPT2SAS driver changes.
These patches are taken from 2.6.37-rc5. Please consider this patch set for next kernel release.

[PATCH 01/10] mpt2sas: Device removal handshake even though the PHYSTATUS_VACANT bit is set in the PhyStatus
[PATCH 02/10] mpt2sas: Internal device reset complete event is not supported for older firmware prior to MPI Rev K
[PATCH 03/10] mpt2sas: Correct resizing calculation for max_queue_depth [PATCH 04/10] mpt2sas: Revision P MPI Header Update
[PATCH 05/10] mpt2sas: Add support for Customer specific branding messages
[PATCH 06/10] mpt2sas: Fix the race between broadcast asyn event and scsi
command completion.
[PATCH 07/10] mpt2sas: Prevent access to freed memory from port enable process
[PATCH 08/10] mpt2sas: Basic Code Cleanup in mpt2sas_base [PATCH 09/10] mpt2sas: Call the _scsih_ir_shutdown prior to reporting the
volumes missing from the OS
[PATCH 10/10] mpt2sas: Bump version 08.100.00.00

---
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html