input/tc3589x: fix compile error

There was a semi-colon missing and it broke the compile.

index 69dc0cb..217a74f 100644
@@ -469,4 +469,5 @@ module_exit(tc3589x_keypad_exit);
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Jayeeta Banerjee/Sundar Iyer");
 MODULE_DESCRIPTION("TC35893 Keypad Driver");
-MODULE_ALIAS("platform:tc3589x-keypad")
+MODULE_ALIAS("platform:tc3589x-keypad");
+

2011/1/4 Dan Carpenter <[email protected]>:

How come my setup compiles then... Oh well, probably a more forgiving compiler.
Applied it.

Yours,
Linus Walleij

The only explanation I can think of is that you're compiling the driver into the kernel instead of as a module? A lot of people like to have their keyboard compiled in instead of loaded later.

You could try a "make drivers/input/keyboard/tc3589x-keypad.i" and look at the precompiled code.

regards,
dan carpenter

2011/1/5 Dan Carpenter <[email protected]>:

Yes that's it, hm the macro __MODULE_INFO() resolves to nothing if compiled-in and resolves to something needing a semicolon otherwise.

This makes some errors pass under the radar, looks syntactically unsound to me :-(

I'll cook up a patch.

Yours,
Linus Walleij

2011/1/4 Dan Carpenter <[email protected]>:

Dmitry can you take this fixup into the input tree? Russell pulled the tc3589x driver into his tree and Torvalds pulled it into his tree, so if you are based on Torvalds' tree for today it should apply fine.

(Sorry for the mistake, I've attempted to fix the root cause by a patch to make this throw compile errors under all circumstances to Rusty Russell.)

Yours,
Linus Walleij

I normally merge with mainline at -rc1 or -rc2 points so I do not have the driver yet.

I think this is one of those times when forwarding patch directly to Linus instead of waiting for it to trickle through all the trees is the most sensible solution.

Thanks.

Dmitry

2011/1/7 Dmitry Torokhov <[email protected]>:

OK said and done Linus sends to Linus...

Yours,
Linus Walleij