Skip to contentSkip to conversation

omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

PATCH New Ohad Ben-Cohen 2 participants 5 messages Nov 24, 2010 – Jan 4, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

Power to the wl12xx wlan device is controlled by a fixed regulator.

Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so users will not be baffled.

---
 arch/arm/mach-omap2/Kconfig |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/Kconfig +3 -0
index fc3a181..cc386da 100644
@@ -190,6 +190,7 @@ config MACH_OMAP3_PANDORA
 	depends on ARCH_OMAP3
 	default y
 	select OMAP_PACKAGE_CBB
+	select REGULATOR_FIXED_VOLTAGE
 
 config MACH_OMAP3_TOUCHBOOK
 	bool "OMAP3 Touch Book"
@@ -235,6 +236,7 @@ config MACH_OMAP_ZOOM2
 	select SERIAL_8250
 	select SERIAL_CORE_CONSOLE
 	select SERIAL_8250_CONSOLE
+	select REGULATOR_FIXED_VOLTAGE
 
 config MACH_OMAP_ZOOM3
 	bool "OMAP3630 Zoom3 board"
@@ -244,6 +246,7 @@ config MACH_OMAP_ZOOM3
 	select SERIAL_8250
 	select SERIAL_CORE_CONSOLE
 	select SERIAL_8250_CONSOLE
+	select REGULATOR_FIXED_VOLTAGE
 
 config MACH_CM_T35
 	bool "CompuLab CM-T35 module"
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

Hi Tony,

Quoted 4 lines · Ohad Ben-Cohen

Power to the wl12xx wlan device is controlled by a fixed regulator.

Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so users will not be baffled.

Not sure if you picked this up ?

We need it because otherwise new wl12xx users can spend many hours until they figure out what's the problem..

Please tell me if there's any problem with this one.

Thanks,
Ohad.

Quoted 38 lines

---
?arch/arm/mach-omap2/Kconfig | ? ?3 +++
?1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/Kconfig +0 -0
index fc3a181..cc386da 100644
@@ -190,6 +190,7 @@ config MACH_OMAP3_PANDORA

? ? ? ?depends on ARCH_OMAP3
? ? ? ?default y
? ? ? ?select OMAP_PACKAGE_CBB
+ ? ? ? select REGULATOR_FIXED_VOLTAGE

?config MACH_OMAP3_TOUCHBOOK
? ? ? ?bool "OMAP3 Touch Book"

arch/arm/mach-omap2/Kconfig +0 -0
@@ -235,6 +236,7 @@ config MACH_OMAP_ZOOM2

? ? ? ?select SERIAL_8250
? ? ? ?select SERIAL_CORE_CONSOLE
? ? ? ?select SERIAL_8250_CONSOLE
+ ? ? ? select REGULATOR_FIXED_VOLTAGE

?config MACH_OMAP_ZOOM3
? ? ? ?bool "OMAP3630 Zoom3 board"

arch/arm/mach-omap2/Kconfig +0 -0
@@ -244,6 +246,7 @@ config MACH_OMAP_ZOOM3

? ? ? ?select SERIAL_8250
? ? ? ?select SERIAL_CORE_CONSOLE
? ? ? ?select SERIAL_8250_CONSOLE
+ ? ? ? select REGULATOR_FIXED_VOLTAGE

?config MACH_CM_T35
? ? ? ?bool "CompuLab CM-T35 module"
--
1.7.0.4

#2 lore raw

PATCH 1/1 omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

In reply to Ohad Ben-Cohen
Quoted 7 lines · Ohad Ben-Cohen

Power to the wl12xx wlan device is controlled by a fixed regulator.

Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so users will not be baffled.

---

Hi Tony,

Gentle reminder,

Thanks,
Ohad.

Quoted 35 lines

?arch/arm/mach-omap2/Kconfig | ? ?3 +++
?1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/Kconfig +0 -0
index fc3a181..cc386da 100644
@@ -190,6 +190,7 @@ config MACH_OMAP3_PANDORA

? ? ? ?depends on ARCH_OMAP3
? ? ? ?default y
? ? ? ?select OMAP_PACKAGE_CBB
+ ? ? ? select REGULATOR_FIXED_VOLTAGE

?config MACH_OMAP3_TOUCHBOOK
? ? ? ?bool "OMAP3 Touch Book"

arch/arm/mach-omap2/Kconfig +0 -0
@@ -235,6 +236,7 @@ config MACH_OMAP_ZOOM2

? ? ? ?select SERIAL_8250
? ? ? ?select SERIAL_CORE_CONSOLE
? ? ? ?select SERIAL_8250_CONSOLE
+ ? ? ? select REGULATOR_FIXED_VOLTAGE

?config MACH_OMAP_ZOOM3
? ? ? ?bool "OMAP3630 Zoom3 board"

arch/arm/mach-omap2/Kconfig +0 -0
@@ -244,6 +246,7 @@ config MACH_OMAP_ZOOM3

? ? ? ?select SERIAL_8250
? ? ? ?select SERIAL_CORE_CONSOLE
? ? ? ?select SERIAL_8250_CONSOLE
+ ? ? ? select REGULATOR_FIXED_VOLTAGE

?config MACH_CM_T35
? ? ? ?bool "CompuLab CM-T35 module"
--
1.7.0.4

maintainer
#3 lore raw

PATCH 1/1 omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

Quoted 6 lines · Ohad Ben-Cohen
Quoted 5 lines · Ohad Ben-Cohen

Power to the wl12xx wlan device is controlled by a fixed regulator.

Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so users will not be baffled.

Quoted 6 lines
Quoted 2 lines

---

Hi Tony,

Gentle reminder,

This is queued for 2.6.38 in omap-for-linus as commit 7c50152f0851e44ef7491546a29fddbbea47735b?

Tony

#4 lore raw

PATCH 1/1 omap: boards w/ wl12xx should select REGULATOR_FIXED_VOLTAGE

Quoted 10 lines · Tony Lindgren
Quoted 9 lines · Ohad Ben-Cohen
Quoted 7 lines · Ohad Ben-Cohen

Power to the wl12xx wlan device is controlled by a fixed regulator.

Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so users will not be baffled.

---

Quoted 6 lines
Quoted 3 lines

Hi Tony,

Gentle reminder,

This is queued for 2.6.38 in omap-for-linus as commit 7c50152f0851e44ef7491546a29fddbbea47735b?

Thanks!

Quoted 3 lines

Tony