Possible bug with ip6tables hl module.
Hello
I am using ip6tables 1.4.10 and kernel 2.6.37.
If I type the following command:
ip6tables -A INPUT -m length --length 100 -m hl --hl-gt 100 -j ACCEPT
It works.
If I swap the length and hl options around:
ip6tables -A INPUT -m hl --hl-gt 100 -m length --length 100 -j ACCEPT
It fails with the following message:
ip6tables v1.4.10: Can't specify HL option twice
Steven.
Quoted 3 lines · Steven Jan Springl
ip6tables -A INPUT -m hl --hl-gt 100 -m length --length 100 -j ACCEPT It fails with the following message:
ip6tables v1.4.10: Can't specify HL option twice
I queued this patch (to be merged when everybody got out of vacation, hehe):
origin git://dev.medozas.de/iptables master
parent 1dc27393b7ba401e6228a5ee2472a6eb72836c43 (v1.4.10-23-g1dc2739) commit 1e128bd804b676ee91beca48312de9b251845d09
Author: Jan Engelhardt Date: Sat Jan 8 02:25:28 2011 +0100
ip[6]tables: only call match's parse function when option char is in range
Normally, extensions use a "default:" case in switch(c) to just return if they do not handle c. Apparently, libip6t_hl does that too late and checks for hl-specific parsing state before it has established that c refers to one of its own options.
Also affected: libipt_ttl, libxt_ipvs, libxt_policy, libxt_statistic.
One way to fix this is to move the flags checks into case '2', '3', '4'. Doing this replication feels bad, so as an alternative, let's just free extensions from having to deal with other extension's options passing thru.
References: http://marc.info/?l=netfilter-devel&m=129444759532377&w=2
--- ip6tables.c | 3 +++ iptables.c | 3 +++ xshared.h | 4 ++++ xtables.c | 4 ++-- 4 files changed, 12 insertions(+), 2 deletions(-)
ip6tables.c +3 -0
@@ -1714,6 +1714,9 @@ int do_command6(int argc, char *argv[], char **table, struct ip6tc_handle **handif (matchp->completed || matchp->match->parse ==NULL )continue ; +if (c < matchp->match->option_offset || + c >= matchp->match->option_offset +XT_OPTION_OFFSET_SCALE ) +continue ; if (matchp->match->parse(c - matchp->match->option_offset, argv, invert, &matchp->match->mflags,
iptables.c +3 -0
@@ -1746,6 +1746,9 @@ int do_command(int argc, char *argv[], char **table, struct iptc_handle **handleif (matchp->completed || matchp->match->parse ==NULL )continue ; +if (c < matchp->match->option_offset || + c >= matchp->match->option_offset +XT_OPTION_OFFSET_SCALE ) +continue ; if (matchp->match->parse(c - matchp->match->option_offset, argv, invert, &matchp->match->mflags,
xshared.h +4 -0
@@ -4,6 +4,10 @@struct xtables_rule_match ;struct xtables_target ; +enum { +XT_OPTION_OFFSET_SCALE =256 , +}; +extern void print_extension_helps (const struct xtables_target *,const struct xtables_rule_match *);
xtables.c +2 -2
@@ -49,7 +49,7 @@# define IP6T_SO_GET_REVISION_TARGET 69#endif #include <getopt.h> - +#include "xshared.h" #define NPROTO 255
@@ -111,7 +111,7 @@ struct option *xtables_merge_options(struct option *orig_opts, mp = merge + num_oold;/* Second, the new options */ - xt_params->option_offset +=256 ; + xt_params->option_offset +=XT_OPTION_OFFSET_SCALE ; *option_offset = xt_params->option_offset;memcpy (mp, newopts,sizeof (*mp) * num_new);
Signature · 1 line
# Created with git-export-patch
Pablo Neira Ayuso
maintainerQuoted 8 lines · Jan Engelhardt
Quoted 3 lines · Steven Jan Springl
ip6tables -A INPUT -m hl --hl-gt 100 -m length --length 100 -j ACCEPT It fails with the following message:
ip6tables v1.4.10: Can't specify HL option twiceI queued this patch (to be merged when everybody got out of vacation, hehe):
JFYI, the fix for this is now in the git tree, it will be available in the next iptables release.