suspicious code in linux/arch/arm/common/sa1111.c
Hi!
Is this good idea?
arch/arm/common/sa1111.c renamed from /arch/arm/common/sa1111.c +1 -1
@@ -282,7 +312,7 @@for (i =0 ; i <8 ; i++) {sa1111_writel (ip0 ^ mask, mapbase +SA1111_INTPOL0 );sa1111_writel (ip0, mapbase +SA1111_INTPOL0 ); -if (sa1111_readl (mapbase +SA1111_INTSTATCLR1 ) & mask) +if (sa1111_readl (mapbase +SA1111_INTSTATCLR0 ) & mask)break ; }
Quoted 5 lines · Pavel Machek
Hi!
Is this good idea?
Signed-off-by Pavel Machek <[email protected]>
Yep, obviously was a typo.
Quoted 14 lines
diff -ur
linux.ofic//arch/arm/common/sa1111.clinux/arch/arm/common/sa1111.carch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100 renamed from /arch/arm/common/sa1111.c ? ? ? ?2010-10-17 20:31:13.000000000 +0200 +1
-1@@ -282,7 +312,7 @@ ? ? ? ?for (i = 0; i < 8; i++) { ? ? ? ? ? ? ? ?sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0); ? ? ? ? ? ? ? ?sa1111_writel(ip0, mapbase + SA1111_INTPOL0); - ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask) + ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask) ? ? ? ? ? ? ? ? ? ? ? ?break; ? ? ? ?}
Quoted 8 lines · Eric Miao
Quoted 5 lines · Pavel Machek
Hi!
Is this good idea?
Signed-off-by Pavel Machek <[email protected]>Yep, obviously was a typo.
Can you apply the patch? Or should I re--generate one with better changelog?
Quoted 18 lines
arch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100 line 318
Quoted 13 lines
diff -ur
linux.ofic//arch/arm/common/sa1111.clinux/arch/arm/common/sa1111.carch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100 renamed from /arch/arm/common/sa1111.c ? ? ? ?2010-10-17 20:31:13.000000000 +0200 +1
-1@@ -282,7 +312,7 @@ ? ? ? ?for (i = 0; i < 8; i++) { ? ? ? ? ? ? ? ?sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0); ? ? ? ? ? ? ? ?sa1111_writel(ip0, mapbase + SA1111_INTPOL0); - ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask) + ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask) ? ? ? ? ? ? ? ? ? ? ? ?break; ? ? ? ?}--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 11 lines · Pavel Machek
Quoted 8 lines · Eric Miao
Quoted 5 lines · Pavel Machek
Hi!
Is this good idea?
Signed-off-by Pavel Machek <[email protected]>Yep, obviously was a typo.
Can you apply the patch? Or should I re--generate one with better changelog?
Applied with subject line as below, which I guess is more specific?
Subject: ARM: sa1111: fix typo in sa1111_retrigger_lowirq()
Quoted 24 lines
Quoted 11 lines
Quoted 11 lines
diff -ur
linux.ofic//arch/arm/common/sa1111.clinux/arch/arm/common/sa1111.carch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100 renamed from /arch/arm/common/sa1111.c ? ? ? ?2010-10-17 20:31:13.000000000 +0200 +1
-1@@ -282,7 +312,7 @@ ? ? ? ?for (i = 0; i < 8; i++) { ? ? ? ? ? ? ? ?sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0); ? ? ? ? ? ? ? ?sa1111_writel(ip0, mapbase + SA1111_INTPOL0); - ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask) + ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask) ? ? ? ? ? ? ? ? ? ? ? ?break;Quoted 8 lines
arch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100 line 318
Quoted 3 lines
arch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100 renamed from /arch/arm/common/sa1111.c ? ? ? ?2010-10-17 20:31:13.000000000 +0200 +0
-0? ? ? ?}--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html Please read the FAQ at ?http://www.tux.org/lkml/--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html