Skip to contentSkip to conversation

cfi_flash: avoid flash_verbose when possible

PATCH New Mike Frysinger 3 participants 3 messages Dec 22, 2010 – Jan 10, 2011 Memory technology devices (MTD)

lore
Share & tools
lore

Mike Frysinger

author
#0 lore raw

PATCH 1/1 cfi_flash: avoid flash_verbose when possible

The flash_verbose logic is only used by the CFI MTD layer, so if we aren't using that, disable the logic completely.

Signed-off-by Mike Frysinger <[email protected]>
---
 drivers/mtd/cfi_flash.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/mtd/cfi_flash.c +6 -0
index 39c235e..b05264b 100644
@@ -63,7 +63,11 @@
  */
 
 static uint flash_offset_cfi[2] = { FLASH_OFFSET_CFI, FLASH_OFFSET_CFI_ALT };
+#ifdef CONFIG_FLASH_CFI_MTD
 static uint flash_verbose = 1;
+#else
+#define flash_verbose 1
+#endif
 
 flash_info_t flash_info[CFI_MAX_FLASH_BANKS];	/* FLASH chips info */
 

@@ -2016,10 +2020,12 @@ ulong flash_get_size (phys_addr_t base, int banknum)
 	return (info->size);
 }
 
+#ifdef CONFIG_FLASH_CFI_MTD
 void flash_set_verbose(uint v)
 {
 	flash_verbose = v;
 }
+#endif
 
 /*-----------------------------------------------------------------------
  */
Signature · 1 line
1.7.3.4
Applied
#1 lore raw

PATCH 1/1 cfi_flash: avoid flash_verbose when possible

Dear Mike Frysinger,

Quoted 7 lines · In message <[email protected]> you wrote:

The flash_verbose logic is only used by the CFI MTD layer, so if we aren't using that, disable the logic completely.

Signed-off-by Mike Frysinger <[email protected]>
---
 drivers/mtd/cfi_flash.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Applied, thanks.

Stefan, this is somewhat global and looks simple enough - hope this is OK with you.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The great question... which I have not been able  to  answer...  is,
`What does woman want?'"                              - Sigmund Freud
#2 lore raw

PATCH 1/1 cfi_flash: avoid flash_verbose when possible

Hi Wolfgang,

Quoted 6 lines · On Sunday 09 January 2011 18:05:42 Wolfgang Denk wrote:
Quoted 6 lines

The flash_verbose logic is only used by the CFI MTD layer, so if we aren't using that, disable the logic completely.

Signed-off-by Mike Frysinger <[email protected]>

---

Quoted 7 lines
Quoted 2 lines
 drivers/mtd/cfi_flash.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Applied, thanks.

Stefan, this is somewhat global and looks simple enough - hope this is OK with you.

No problem at all. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de