gspca for_2.6.38
PATCH 1/1 gspca for_2.6.38
The following changes since commit353b61709a555fab9745cb7aea18e1c376c413ce:
[media] radio-si470x: Always report support for RDS (2011-01-11 14:44:28 -0200)
are available in the git repository at:
git://linuxtv.org/jfrancois/gspca.git for_2.6.38
Jean-François Moine (9):
gspca: Version change.
gspca: Remove __devinit, __devinitconst and __devinitdata
gspca: Remove useless instructions
gspca - ov519: Cleanup source and add a comment
gspca - ov534: Clearer debug messages
gspca - ov534: Propagate errors to higher level
gspca - ov534: Use the new video control mechanism
gspca - sonixj: Infrared bug fix and enhancement
gspca - sonixj: Add LED (illuminator) control to the webcam 0c45:614a.
drivers/media/video/gspca/benq.c | 2 +- drivers/media/video/gspca/conex.c | 4 +- drivers/media/video/gspca/cpia1.c | 2 +- drivers/media/video/gspca/etoms.c | 4 +- drivers/media/video/gspca/finepix.c | 2 +- drivers/media/video/gspca/gl860/gl860.c | 2 +- drivers/media/video/gspca/gspca.c | 2 +- drivers/media/video/gspca/jeilinj.c | 2 +- drivers/media/video/gspca/jpeg.h | 4 +- drivers/media/video/gspca/konica.c | 2 +- drivers/media/video/gspca/m5602/m5602_core.c | 2 +- drivers/media/video/gspca/mars.c | 2 +- drivers/media/video/gspca/mr97310a.c | 2 +- drivers/media/video/gspca/ov519.c | 8 +- drivers/media/video/gspca/ov534.c | 473 +++++++------------------- drivers/media/video/gspca/ov534_9.c | 2 +- drivers/media/video/gspca/pac207.c | 2 +- drivers/media/video/gspca/pac7302.c | 4 +- drivers/media/video/gspca/pac7311.c | 4 +- drivers/media/video/gspca/sn9c2028.c | 2 +- drivers/media/video/gspca/sn9c20x.c | 2 +- drivers/media/video/gspca/sonixb.c | 4 +- drivers/media/video/gspca/sonixj.c | 92 +++--- drivers/media/video/gspca/spca1528.c | 2 +- drivers/media/video/gspca/spca500.c | 2 +- drivers/media/video/gspca/spca501.c | 2 +- drivers/media/video/gspca/spca505.c | 2 +- drivers/media/video/gspca/spca508.c | 2 +- drivers/media/video/gspca/spca561.c | 2 +- drivers/media/video/gspca/sq905.c | 2 +- drivers/media/video/gspca/sq905c.c | 2 +- drivers/media/video/gspca/sq930x.c | 2 +- drivers/media/video/gspca/stk014.c | 2 +- drivers/media/video/gspca/stv0680.c | 2 +- drivers/media/video/gspca/stv06xx/stv06xx.c | 2 +- drivers/media/video/gspca/sunplus.c | 2 +- drivers/media/video/gspca/t613.c | 2 +- drivers/media/video/gspca/tv8532.c | 2 +- drivers/media/video/gspca/vc032x.c | 2 +- drivers/media/video/gspca/xirlink_cit.c | 2 +- drivers/media/video/gspca/zc3xx.c | 2 +- 41 files changed, 218 insertions(+), 443 deletions(-)
Signature · 2 lines
Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
Quoted 8 lines · On Thu, 13 Jan 2011 11:59:53 +0100 Jean-Francois Moine <[email protected]> wrote:
The following changes since commit
353b61709a555fab9745cb7aea18e1c376c413ce:[media] radio-si470x: Always report support for RDS (2011-01-11 14:44:28 -0200)
are available in the git repository at:
git://linuxtv.org/jfrancois/gspca.gitfor_2.6.38
Hi Jean-François, I had a look at the ov534 changes.
Quoted 1 line
Jean-François Moine (9):
[...]
Quoted 1 line
gspca - ov534: Use the new video control mechanism
In this commit, is there a reason why you didn't rename also sd_setagc() into setagc() like for the other functions?
I am going to test the changes and report back if there's anything more, I like the cleanup tho.
Thanks,
Antonio
Signature · 8 lines
Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Quoted 9 lines · On Thu, 13 Jan 2011 12:38:04 +0100 Antonio Ospite <[email protected]>…
Quoted 1 line
Jean-François Moine (9):
[...]
Quoted 1 line
gspca - ov534: Use the new video control mechanism
In this commit, is there a reason why you didn't rename also
sd_setagc()intosetagc()like for the other functions?I am going to test the changes and report back if there's anything more, I like the cleanup tho.
Hi Antonio,
With the new video control mechanism, the '.set_control' function is called only when capture is active. Otherwise, the '.set' function is called in any case, and here, it activates/inactivates the auto white balance control... Oh, I forgot to disable the awb when the agc is disabled!
Thank you for reporting any problem. BTW, the webcam 06f8:3002 which had been removed some time ago is being tested. I will add it to this subdriver as soon as it works correctly.
Cheers.
Signature · 2 lines
Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
Quoted 13 lines · On Thu, 13 Jan 2011 17:30:21 +0100 Jean-Francois Moine <[email protected]> wrote:
Quoted 9 lines · On Thu, 13 Jan 2011 12:38:04 +0100 Antonio Ospite <[email protected]>…
Quoted 1 line
Jean-François Moine (9):
[...]
Quoted 1 line
gspca - ov534: Use the new video control mechanism
In this commit, is there a reason why you didn't rename also
sd_setagc()intosetagc()like for the other functions?I am going to test the changes and report back if there's anything more, I like the cleanup tho.
Quoted 8 lines
Hi Antonio,
With the new video control mechanism, the '.set_control' function is called only when capture is active. Otherwise, the '.set' function is called in any case, and here, it activates/inactivates the auto white balance control... Oh, I forgot to disable the awb when the agc is disabled!
So the convention you used for function names is:
.set = sd_setFOO;
and
.set_control = setBAR;
right?
Tested with guvcview, when toggling the Autoexposure control I get this message:
control id: 0x009a0901 failed to set (error -1)
control id: 0x009a0901 failed to get value (error -1)
Similar error with qv4l2:
Error Auto Exposure (1): Invalid argument
And because of that the manual Exposure control does not work either.
However I verified these errors are also in 2.6.35, so I think your conversion is fine, there must be something else going on; maybe I should open another thread, as there is also the pending issue of changing framerates "live", unrelated to the control changes as well.
I hope to be able to look at these issues soon, if nobody else does before.
Thanks,
Antonio
Signature · 8 lines
Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Em 13-01-2011 14:30, Jean-Francois Moine escreveu:
Quoted 21 lines
Quoted 9 lines · On Thu, 13 Jan 2011 12:38:04 +0100 Antonio Ospite <[email protected]>…
Quoted 1 line
Jean-François Moine (9):
[...]
Quoted 1 line
gspca - ov534: Use the new video control mechanism
In this commit, is there a reason why you didn't rename also
sd_setagc()intosetagc()like for the other functions?I am going to test the changes and report back if there's anything more, I like the cleanup tho.
Hi Antonio,
With the new video control mechanism, the '.set_control' function is called only when capture is active. Otherwise, the '.set' function is called in any case, and here, it activates/inactivates the auto white balance control... Oh, I forgot to disable the awb when the agc is disabled!
Quoted 3 lines
Thank you for reporting any problem. BTW, the webcam 06f8:3002 which had been removed some time ago is being tested. I will add it to this subdriver as soon as it works correctly.
I'm applying the remaining 8 patches from this series, as they seem to be ok.
Please send me a new pull request when you fix the issues with the ov534 new video control mechanism.
Thanks,
Mauro