block driver updates for 2.6.38

Hi Linus,

Block driver updates for 2.6.38. Not a lot.

Please pull.

git://git.kernel.dk/linux-2.6-block.git for-2.6.38/drivers

Jens Axboe (1):
cciss: reinstate proper FIFO order of command queue list

Pekka Enberg (1):
floppy: replace NO_GEOM macro with a function

 drivers/block/cciss.c     |   23 +++++++++++------------
 drivers/block/cciss.h     |    4 ++--
 drivers/block/cciss_cmd.h |    2 +-
 drivers/block/floppy.c    |   15 ++++++++++-----
 4 files changed, 24 insertions(+), 20 deletions(-)

Jens Axboe

Hmm. When I see work on floppy.c, I end up wondering what happened to the work by Stephen to use a single threaded workqueue?

That was reported to fix a KVM oops at some point to to avoiding the whole race between interrupts/workqueues, but it seems to have dropped off everybody's radar. I don't think anybody ever tested it on real hardware, but I'm still wondering..

Anybody?

Linus

Not sure, I don't recall seeing it.

Jens Axboe

It was on lkml a few months ago. google finds it with "floppy: use single threaded workqueue" if you don't have your own archives.

Eg:

http://kerneltrap.org/mailarchive/linux-kernel/2010/6/11/4582074

and similar.

Linus

Good news: I have updated version, but bad news is that it fails formatting a floppy and haven't had time to debug.

It looks my floppy format problem wasn't my patch but the HPET-MSI problem. https://patchwork.kernel.org/patch/69588/

Why hasn't that been fixed in mainline kernel?

Because the proper fix was _supposed_ to be the one that disabled MSI for just the affected AMD boards. See

commit 73472a46b5b28116b145fb5fc05242c1aa8e1461
Author: Pallipadi, Venkatesh <[email protected]>
Date: Thu Jan 21 11:09:52 2010 -0800

x86: Disable HPET MSI on ATI SB700/SB800

HPET MSI on platforms with ATI SB700/SB800 as they seem to have some side-effects on floppy DMA. Do not use HPET MSI on such platforms.

Original problem report from Mark Hounschell
http://lkml.indiana.edu/hypermail/linux/kernel/0912.2/01118.html

[ This patch needs to go to stable as well. But, there are some
conflicts that prevents the patch from going as is. I can rebase/resubmit to stable once the patch goes upstream.
hpa: still Cc:'ing stable@ as an FYI. ]

LKML-Reference: <[email protected]>

and if you have the same problem (MSI + floppy doesn't work), can you give more information about your system?

In particular, is it an AMD southbridge that we don't have listed? Right now we only trigger it for machines that match this:

PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS

(which is PCI device 1002:4385) and it may be that we have incomplete coverage.

And so few people use floppies (and expect them to work), that we probably have very bad test coverage too.

Linus

It appears to be a different problem (not HPET MSI). Not sure what is causing it, but even 2.6.35 can't format a floppy without error.

00:00.0 Host bridge: Intel Corporation 5520/5500/X58 I/O Hub to ESI Port (rev 12)
00:01.0 PCI bridge: Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port 1 (rev 12) 00:03.0 PCI bridge: Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port 3 (rev 12) 00:07.0 PCI bridge: Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port 7 (rev 12) 00:14.0 PIC: Intel Corporation 5520/5500/X58 I/O Hub System Management Registers (rev 12) 00:14.1 PIC: Intel Corporation 5520/5500/X58 I/O Hub GPIO and Scratch Pad Registers (rev 12) 00:14.2 PIC: Intel Corporation 5520/5500/X58 I/O Hub Control Status and RAS Registers (rev 12) 00:14.3 PIC: Intel Corporation 5520/5500/X58 I/O Hub Throttle Registers (rev 12)
00:1a.0 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB UHCI Controller #4 00:1a.1 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB UHCI Controller #5 00:1a.2 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB UHCI Controller #6 00:1a.7 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB2 EHCI Controller #2 00:1b.0 Audio device: Intel Corporation 82801JI (ICH10 Family) HD Audio Controller
00:1c.0 PCI bridge: Intel Corporation 82801JI (ICH10 Family) PCI Express Root Port 1 00:1c.2 PCI bridge: Intel Corporation 82801JI (ICH10 Family) PCI Express Root Port 3 00:1c.3 PCI bridge: Intel Corporation 82801JI (ICH10 Family) PCI Express Root Port 4 00:1c.4 PCI bridge: Intel Corporation 82801JI (ICH10 Family) PCI Express Root Port 5 00:1c.5 PCI bridge: Intel Corporation 82801JI (ICH10 Family) PCI Express Root Port 6 00:1d.0 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB UHCI Controller #1 00:1d.1 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB UHCI Controller #2 00:1d.2 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB UHCI Controller #3 00:1d.7 USB Controller: Intel Corporation 82801JI (ICH10 Family) USB2 EHCI Controller #1 00:1e.0 PCI bridge: Intel Corporation 82801 PCI Bridge (rev 90)
00:1f.0 ISA bridge: Intel Corporation 82801JIR (ICH10R) LPC Interface Controller
00:1f.2 IDE interface: Intel Corporation 82801JI (ICH10 Family) 4 port SATA IDE Controller #1 00:1f.3 SMBus: Intel Corporation 82801JI (ICH10 Family) SMBus Controller
00:1f.5 IDE interface: Intel Corporation 82801JI (ICH10 Family) 2 port SATA IDE Controller #2 01:00.0 Ethernet controller: Intel Corporation 82571EB Gigabit Ethernet Controller (rev 06) 01:00.1 Ethernet controller: Intel Corporation 82571EB Gigabit Ethernet Controller (rev 06) 02:00.0 VGA compatible controller: ATI Technologies Inc RV535 [Radeon X1650 Series] (rev 9e) 02:00.1 Display controller: ATI Technologies Inc RV535 [Radeon X1650 Series] (rev 9e) 03:00.0 PCI bridge: Integrated Device Technology, Inc. PES12N3A PCI Express Switch (rev 0e) 04:02.0 PCI bridge: Integrated Device Technology, Inc. PES12N3A PCI Express Switch (rev 0e) 04:04.0 PCI bridge: Integrated Device Technology, Inc. PES12N3A PCI Express Switch (rev 0e) 05:00.0 Ethernet controller: Intel Corporation 82575GB Gigabit Network Connection (rev 02) 05:00.1 Ethernet controller: Intel Corporation 82575GB Gigabit Network Connection (rev 02) 06:00.0 Ethernet controller: Intel Corporation 82575GB Gigabit Network Connection (rev 02) 06:00.1 Ethernet controller: Intel Corporation 82575GB Gigabit Network Connection (rev 02) 07:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit Ethernet Controller (rev 12) 08:00.0 IDE interface: Marvell Technology Group Ltd. 88SE6121 SATA II Controller (rev b2) 09:00.0 RAID bus controller: Marvell Technology Group Ltd. 88SE6440 SAS/SATA PCIe controller (rev 02) 0a:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit Ethernet Controller (rev 12)

Do you actually know that the hardware is good (ie does _any_ version of Linux work)?

Floppy disks and drives have not been known for their robustness, and most of them tend to be pretty old by now.

Dang, I think I should just try to go to Fry's and see if I can find a floppy drive somewhere. Not that I even know if my motherboards necessarily even have the _pins_ to connect it any more.

Linus

I have enough machines to try several.
Will go back to ancient history to see if this is new issue.

Forgot how unreliable floppies are! Even my Windows 7 machine reference machine won't format with the crap drive it has.
And the old Xeon machine won't boot with current version of Grub (grub-pc), I hate antiques. Time to do more hunting.

Some people can't even remember what a floppy is...
http://www.geek.com/articles/geek-pick/what-are-the-windows-a-and-b-drives-used-for-20110112/

----- Original Message ----

you just made my day. Besides that I learned my computing on punched cards and
tape (which may reveal something about my age) I really like the 5-core processing :-)

Happy weekend
Martin

I could not find a working floppy in 4 machines (even Windows).

There is always USB floppy but it is not the same.