ASoC: Add dependency on X86 for Intel MID drivers
PATCH 1/1 ASoC: Add dependency on X86 for Intel MID drivers
--- sound/soc/mid-x86/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/mid-x86/Kconfig +1 -0
@@ -1,5 +1,6 @@ config SND_MFLD_MACHINE tristate "SOC Machine Audio driver for Intel Medfield MID platform" + depends on X86 select SND_SOC_SN95031 select SND_SST_PLATFORM help
Signature · 1 line
1.7.2.3
sound/soc/mid-x86/Kconfig line 6
Quoted 6 lines
config
SND_MFLD_MACHINEsound/soc/mid-x86/Kconfig +1
-0tristate "SOC Machine Audio driver for Intel Medfield MID platform" + depends on X86 select SND_SOC_SN95031 select SND_SST_PLATFORM help
Mark,
X86 specifies generic x86 devices, pc's netbooks.....
The MID class of devices are quite different, so IMO it should rather depend on X86_MRST which is for MID devices.
CC Alan:
Alan would X86_MRST be apt or any other option for MID drivers vs X86?
~Vinod
Quoted 6 lines · Vinod
X86 specifies generic x86 devices, pc's netbooks.....
The MID class of devices are quite different, so IMO it should rather depend onX86_MRSTwhich is for MID devices.CC Alan:
Alan wouldX86_MRSTbe apt or any other option for MID drivers vs X86?
Quite possibly, given that you hadn't specified any dependencies at all I was going for something as inclusive as possible on x86 platforms. Were this a normal embedded system on Linux the machine driver would depend on the specific machine that's being supported.
Quoted 9 lines · On Sat, 15 Jan 2011 13:28:42 +0000 Mark Brown…
Quoted 7 lines · Vinod
X86 specifies generic x86 devices, pc's netbooks..... The MID class of devices are quite different, so IMO it should rather depend on
X86_MRSTwhich is for MID devices.CC Alan:
Alan wouldX86_MRSTbe apt or any other option for MID drivers vs X86?
That depends what it needs - you want to specify the minimum needed to make it buildable really, which is probably INTEL_SCU_IPC in this case
- you use the IPC I/O so you need the IPC, and the rest follows.
Quoted 3 lines · Alan Cox
That depends what it needs - you want to specify the minimum needed to make it buildable really, which is probably
INTEL_SCU_IPCin this case
- you use the IPC I/O so you need the IPC, and the rest follows.
Ping? I don't care what dependency is most appropriate but clearly there's no way this should be showing up on things that aren't even x86.
Quoted 7 lines
Quoted 3 lines
That depends what it needs - you want to specify the minimum needed to make it buildable really, which is probably
INTEL_SCU_IPCin this case
- you use the IPC I/O so you need the IPC, and the rest follows.Ping? I don't care what dependency is most appropriate but clearly there's no way this should be showing up on things that aren't even x86.
I will send the patch now, sorry been little tied up with few other stuff
~Vinod
Quoted 5 lines · Vinod
Quoted 3 lines
Ping? I don't care what dependency is most appropriate but clearly there's no way this should be showing up on things that aren't even x86.
I will send the patch now, sorry been little tied up with few other stuff
No problem - I'd just like to get this sorted before the merge window closes and this appears in -next.