Skip to contentSkip to conversation

Add -v option to btrfsctl to control verbosity: Be quiet unless requested.

PATCH In review Maximilian Mehnert 2 participants 4 messages Jan 22, 2011 Btrfs file system

lore
Share & tools
lore

Maximilian Mehnert

author
#0 lore raw

PATCH 1/1 Add -v option to btrfsctl to control verbosity: Be quiet unless requested.

---
 btrfsctl.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
btrfsctl.c +8 -2
index 92bdf39..156ed62 100644
@@ -106,6 +106,7 @@ int main(int ac, char **av)
 	char *pos;
 	char *fullpath;
 	u64 objectid = 0;
+	int verbose = 0;
  	if (ac == 2 && strcmp(av[1], "-a") == 0) {
 		fprintf(stderr, "Scanning for Btrfs filesystems\n");

@@ -217,6 +218,9 @@ int main(int ac, char **av)
 				}
 			}
 		}
+		else if (strcmp(av[i], "-v") == 0) {
+			verbose = 1;
+		}
 	}
 	if (command == 0) {
 		fprintf(stderr, "no valid commands given\n");

@@ -254,11 +258,13 @@ int main(int ac, char **av)
 		exit(1);
 	}
 	if (ret == 0) {
-		printf("operation complete\n");
+		if (verbose) printf("operation complete\n");
 	} else {
 		printf("ioctl failed with error %d\n", ret);
 	}
-	printf("%s\n", BTRFS_BUILD_VERSION);
+	if (verbose) {
+		printf("%s\n", BTRFS_BUILD_VERSION);
+	}
 	if (ret)
 		exit(1);
 -- 1.7.2.3
#1 lore raw

Hi,

btrfsctl is deprecated, why you're adding new options to it? :)

Regards,
Felix

Quoted 50 lines · Maximilian Mehnert

Date: Sat, 22 Jan 2011 12:59:22 +0100
From: Maximilian Mehnert <[email protected]>
To: linux-btrfs <[email protected]>
Subject: [PATCH] Add -v option to btrfsctl to control verbosity: Be quiet
unless requested.

---
  btrfsctl.c |   10 ++++++++--
  1 files changed, 8 insertions(+), 2 deletions(-)
btrfsctl.c +8 -3
index 92bdf39..156ed62 100644
@@ -106,6 +106,7 @@ int main(int ac, char **av)
  	char *pos;
  	char *fullpath;
  	u64 objectid = 0;
+	int verbose = 0;
   	if (ac == 2 && strcmp(av[1], "-a") == 0) {
  		fprintf(stderr, "Scanning for Btrfs filesystems\n");

@@ -217,6 +218,9 @@ int main(int ac, char **av)
  				}
  			}
  		}
+		else if (strcmp(av[i], "-v") == 0) {
+			verbose = 1;
+		}
  	}
  	if (command == 0) {
  		fprintf(stderr, "no valid commands given\n");

@@ -254,11 +258,13 @@ int main(int ac, char **av)
  		exit(1);
  	}
  	if (ret == 0) {
-		printf("operation complete\n");
+		if (verbose) printf("operation complete\n");
  	} else {
  		printf("ioctl failed with error %d\n", ret);
  	}
-	printf("%s\n", BTRFS_BUILD_VERSION);
+	if (verbose) {
+		printf("%s\n", BTRFS_BUILD_VERSION);
+	}
  	if (ret)
  		exit(1);
  -- 1.7.2.3
 
 
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

---end quoted text---

author
#2 lore raw
Quoted 3 lines · Felix Blanke

Hi,

btrfsctl is deprecated, why you're adding new options to it? :)

Well, I did not know that it's deprecated ;-)
Neither the manpage nor the program itself said so and the messages annoyed logcheck...

#3 lore raw

Hi,

there is a patch that marks it deprecated:

http://www.spinics.net/lists/linux-btrfs/msg06625.html

But it's not in git yet :/ Last commit is from oct. 2010, hopefully all new patches will be pulled soon.

Regards,
Felix

Quoted 12 lines · Maximilian Mehnert

Date: Sat, 22 Jan 2011 13:26:51 +0100
From: Maximilian Mehnert <[email protected]>
To: linux-btrfs <[email protected]>
Subject: Re: [PATCH] Add -v option to btrfsctl to control verbosity: Be
quiet unless requested.

Quoted 3 lines · Felix Blanke

Hi,

btrfsctl is deprecated, why you're adding new options to it? :)

Quoted 8 lines

Well, I did not know that it's deprecated ;-)
Neither the manpage nor the program itself said so and the messages annoyed logcheck...

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

---end quoted text---