Skip to contentSkip to conversation

cdrkit: fix build with ccache

PATCH New Peter Korsgaard 3 participants 4 messages Jan 20, 2011 – Jan 24, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cdrkit: fix build with ccache

commit: http://git.buildroot.net/buildroot/commit/?id=464f862d82c2c1dee1f154e587e8771bbf45f780
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Cmake gets confused about ccache, so don't use ccache for cmake builds.

---
 package/cdrkit/cdrkit.mk |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
package/cdrkit/cdrkit.mk +3 -2
index a0ce9cb..7d6899a 100644
@@ -13,8 +13,9 @@ endif
 
 # CMake doesn't support having the --sysroot option directly in the
 # compiler path, so move this option to the CFLAGS/CXXFLAGS variables.
-CDRKIT_TARGET_CC = $(filter-out --sysroot=%,$(TARGET_CC))
-CDRKIT_TARGET_CXX = $(filter-out --sysroot=%,$(TARGET_CXX))
+# It also gets confused by ccache, so don't use ccache here.
+CDRKIT_TARGET_CC = $(filter-out --sysroot=%,$(TARGET_CC_NOCCACHE))
+CDRKIT_TARGET_CXX = $(filter-out --sysroot=%,$(TARGET_CXX_NOCCACHE))
 CDRKIT_TARGET_CFLAGS = $(filter --sysroot=%,$(TARGET_CC)) $(TARGET_CFLAGS)
 CDRKIT_TARGET_CXXFLAGS = $(filter --sysroot=%,$(TARGET_CXX)) $(TARGET_CXXFLAGS)
 
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 cdrkit: fix build with ccache

Hello,

Quoted 1 line · On Thu, 20 Jan 2011 21:23:23 +0100 Peter Korsgaard <[email protected]> wrote:

Cmake gets confused about ccache, so don't use ccache for cmake builds.

Which problems did you had exactly ?

While this is obviously the right short-term fix, it's a bit of a shame of CMake doesn't play well with ccache, so maybe it's something I could raise on the CMake mailing-list.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 cdrkit: fix build with ccache

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Hello,
Thomas> On Thu, 20 Jan 2011 21:23:23 +0100

Quoted 1 line · Thomas> Peter Korsgaard <[email protected]> wrote:
Quoted 1 line

Cmake gets confused about ccache, so don't use ccache for cmake builds.

Thomas> Which problems did you had exactly ?

See the quoted error message in the libcuefile thread:

http://lists.busybox.net/pipermail/buildroot/2011-January/040755.html

(and followups)

Thomas> While this is obviously the right short-term fix, it's a bit of Thomas> a shame of CMake doesn't play well with ccache, so maybe it's Thomas> something I could raise on the CMake mailing-list.

Indeed. We left it here for you to have fun with once you're back from holidays :P

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 cdrkit: fix build with ccache

Quoted 9 lines · On Mon, 24 Jan 2011 17:14:00 +0100 Peter Korsgaard <[email protected]> wrote:
Quoted 1 line
Quoted 1 line

Cmake gets confused about ccache, so don't use ccache for cmake builds.

Thomas> Which problems did you had exactly ?

See the quoted error message in the libcuefile thread:

http://lists.busybox.net/pipermail/buildroot/2011-January/040755.html

(and followups)

Thanks. In fact, I found this e-mail while going through the rest of my Buildroot backlog (which I'm going through in a reverse chronological order).

Quoted 6 lines

Thomas> While this is obviously the right short-term fix, it's a bit of Thomas> a shame of CMake doesn't play well with ccache, so maybe it's Thomas> something I could raise on the CMake mailing-list.

Indeed. We left it here for you to have fun with once you're back from holidays :P

Thanks so much :-)

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com