Skip to contentSkip to conversation

hid: check for kmalloc() failure

PATCH In review Dan Carpenter 2 participants 2 messages Jan 24, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hid: check for kmalloc() failure

Return -ENOMEM if kmalloc() fails.

drivers/hid/hid-roccat-koneplus.c +4 -0
index 1608c8d..c27bc91 100644
@@ -220,6 +220,10 @@ static int koneplus_get_startup_profile(struct usb_device *usb_dev)
 	int retval;
 
 	buf = kmalloc(sizeof(struct koneplus_startup_profile), GFP_KERNEL);
+	if (!buf) {
+		retval = -ENOMEM;
+		goto out;
+	}
 
 	retval = koneplus_receive(usb_dev, KONEPLUS_USB_COMMAND_STARTUP_PROFILE,
 			buf, sizeof(struct koneplus_startup_profile));
maintainer
#1 lore raw

Am Montag, den 24.01.2011, 21:32 +0300 schrieb Dan Carpenter:

Quoted 9 lines

Return -ENOMEM if kmalloc() fails.

drivers/hid/hid-roccat-koneplus.c +0 -0
index 1608c8d..c27bc91 100644

drivers/hid/hid-roccat-koneplus.c static int koneplus_get_startup_profile(struct usb_device *usb_dev) · line 229

Quoted 10 lines
drivers/hid/hid-roccat-koneplus.c +4 -0
@@ -220,6 +220,10 @@ static int koneplus_get_startup_profile(struct usb_device *usb_dev)
 	int retval;
 
 	buf = kmalloc(sizeof(struct koneplus_startup_profile), GFP_KERNEL);
+	if (!buf) {
+		retval = -ENOMEM;
+		goto out;
+	}
 
 	retval = koneplus_receive(usb_dev, KONEPLUS_USB_COMMAND_STARTUP_PROFILE,
 			buf, sizeof(struct koneplus_startup_profile));

That was already fixed by Vasiliy Kulikov. The patch was applied to the roccat branch in Jiri Kosinas hid repository (dacfecdbf3a0a5072984ff8b3c224a48c8461008).
Thank you anyway.
Stefan