python-scons_1.3.0: add missing dependencies
PATCH 1/1 python-scons_1.3.0: add missing dependencies
In order to launch scons in a board it depends on a couple python packages which were not managed by the recipe.
This patch adds them.
--- recipes/python/python-scons_1.3.0.bb | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
recipes/python/python-scons_1.3.0.bb +8 -0
@@ -1,8 +1,16 @@ DESCRIPTION = "A Software Construction Tool" SECTION = "devel/python" PRIORITY = "optional" +RDEPENDS_${PN} = "python-shell \ + python-stringold \ + python-lang \ + python-io \ + python-fcntl \ + python-pickle \ + python-crypt" LICENSE = "GPL" SRCNAME = "scons" +PR = "r1" SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz;name=scons \ file://toolchain-from-env.SConscript \
Signature · 1 line
1.7.2.3
Some small nitpicks, see below
Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
Quoted 18 lines
In order to launch scons in a board it depends on a couple python packages which were not managed by the recipe.
This patch adds them.
Signed-off-by Víctor Manuel Jáquez Leal <[email protected]>---
recipes/python/python-scons_1.3.0.bb | 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)recipes/python/python-scons_1.3.0.bb +0
-0@@ -1,8 +1,16 @@DESCRIPTION = "A Software Construction Tool"
SECTION = "devel/python"
PRIORITY = "optional"
recipes/python/python-scons_1.3.0.bb line 10
Quoted 7 lines
recipes/python/python-scons_1.3.0.bb +7
-0+RDEPENDS_${PN} = "python-shell \ + python-stringold \ + python-lang \ + python-io \ + python-fcntl \ + python-pickle \ + python-crypt"
We generally put variables in the order OE uses them, so RDEPENDS should go next to do_package/FILES/etc. Historically it was on top, but that stopped making sense after switching to RDEPENDS_${PN}
Quoted 1 line
LICENSE = "GPL"
Could you fix that while you're at it? It would be nice to know if it's GPLv2 or GPLv2+.
Other than that, the patch looks OK to me[1].
regards,
Koen
[1] Sconstructs still make my eyes bleed, but that's not the point
Quoted 7 lines · Koen Kooi
Some small nitpicks, see below
Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
Quoted 3 lines
In order to launch scons in a board it depends on a couple python packages which were not managed by the recipe.
[snip]
Quoted 4 lines
We generally put variables in the order OE uses them, so RDEPENDS should go next to do_package/FILES/etc. Historically it was on top, but that stopped making sense after switching to RDEPENDS_${PN}
Done.
Quoted 5 lines
Quoted 2 lines
LICENSE = "GPL"
Could you fix that while you're at it? It would be nice to know if it's GPLv2 or GPLv2+.
Verified. It is MIT not GPL!
Quoted 8 lines
Other than that, the patch looks OK to me[1].
regards,
Koen
[1] Sconstructs still make my eyes bleed, but that's not the point
I do not like it either at all, but v8 uses it.
vmjl
Op 25 jan 2011, om 17:18 heeft Víctor M. Jáquez L. het volgende geschreven:
Quoted 19 lines · Koen Kooi
Quoted 7 lines
Some small nitpicks, see below
Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
Quoted 3 lines
In order to launch scons in a board it depends on a couple python packages which were not managed by the recipe.
[snip]
Quoted 4 lines
We generally put variables in the order OE uses them, so RDEPENDS should go next to do_package/FILES/etc. Historically it was on top, but that stopped making sense after switching to RDEPENDS_${PN}
Done.
Quoted 1 line
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
LICENSE = "GPL"
Could you fix that while you're at it? It would be nice to know if it's GPLv2 or GPLv2+.
Verified. It is MIT not GPL!
Good catch!
Quoted 13 lines
Quoted 9 lines
Other than that, the patch looks OK to me[1].
regards,
Koen
[1] Sconstructs still make my eyes bleed, but that's not the point
I do not like it either at all, but v8 uses it.
vmjl