Skip to contentSkip to conversation

compile time initialization for event flags value

PATCH In review Lai Jiangshan 2 participants 3 messages Jan 26, 2011 – Feb 17, 2011 ABI/API

lore
Share & tools
lore

Lai Jiangshan

author
#0 lore raw

PATCH 1/1 compile time initialization for event flags value

compile time initialization is better than runtime initialization.

impact: remove many early_initcall()s and many trace_init_flags_##name()s.

Signed-off-by Lai Jiangshan <[email protected]>

---

include/linux/syscalls.h +4 -4
index 18cd068..ff074c8 100644
@@ -135,8 +135,8 @@ extern struct trace_event_functions exit_syscall_print_funcs;
 		.class			= &event_class_syscall_enter,	\
 		.event.funcs            = &enter_syscall_print_funcs,	\
 		.data			= (void *)&__syscall_meta_##sname,\
-	};								\
-	__TRACE_EVENT_FLAGS(enter_##sname, TRACE_EVENT_FL_CAP_ANY)
+		.flags			= TRACE_EVENT_FL_CAP_ANY,	\
+	};
 
 #define SYSCALL_TRACE_EXIT_EVENT(sname)					\
 	static struct syscall_metadata					\

@@ -149,8 +149,8 @@ extern struct trace_event_functions exit_syscall_print_funcs;
 		.class			= &event_class_syscall_exit,	\
 		.event.funcs		= &exit_syscall_print_funcs,	\
 		.data			= (void *)&__syscall_meta_##sname,\
-	};								\
-	__TRACE_EVENT_FLAGS(exit_##sname, TRACE_EVENT_FL_CAP_ANY)
+		.flags			= TRACE_EVENT_FL_CAP_ANY,	\
+	};
 
 #define SYSCALL_METADATA(sname, nb)				\
 	SYSCALL_TRACE_ENTER_EVENT(sname);			\
Acked-by on v1 1/1
#1 lore raw
Quoted 22 lines · Lai Jiangshan

compile time initialization is better than runtime initialization.

impact: remove many early_initcall()s and many trace_init_flags_##name()s.

Signed-off-by Lai Jiangshan <[email protected]>

---

include/linux/syscalls.h +2 -2
index 18cd068..ff074c8 100644
@@ -135,8 +135,8 @@ extern struct trace_event_functions exit_syscall_print_funcs;
 		.class			= &event_class_syscall_enter,	\
 		.event.funcs            = &enter_syscall_print_funcs,	\
 		.data			= (void *)&__syscall_meta_##sname,\
-	};								\
-	__TRACE_EVENT_FLAGS(enter_##sname, TRACE_EVENT_FL_CAP_ANY)
+		.flags			= TRACE_EVENT_FL_CAP_ANY,	\
+	};
 
 #define SYSCALL_TRACE_EXIT_EVENT(sname)					\
 	static struct syscall_metadata					\

include/linux/syscalls.h extern struct trace_event_functions exit_syscall_print_funcs; · line 156

Quoted 10 lines
include/linux/syscalls.h +2 -2
@@ -149,8 +149,8 @@ extern struct trace_event_functions exit_syscall_print_funcs;
 		.class			= &event_class_syscall_exit,	\
 		.event.funcs		= &exit_syscall_print_funcs,	\
 		.data			= (void *)&__syscall_meta_##sname,\
-	};								\
-	__TRACE_EVENT_FLAGS(exit_##sname, TRACE_EVENT_FL_CAP_ANY)
+		.flags			= TRACE_EVENT_FL_CAP_ANY,	\
+	};
 
 #define SYSCALL_METADATA(sname, nb)				\
 	SYSCALL_TRACE_ENTER_EVENT(sname);			\
Acked-by Frederic Weisbecker <[email protected]>
author
#2 lore raw

[tip:perf/core] tracing: Compile time initialization for event flags value

In reply to Lai Jiangshan
Commit-ID:  f4d5c029bd6731baac0937324cef0f746e7d5ea7
Gitweb:     http://git.kernel.org/tip/f4d5c029bd6731baac0937324cef0f746e7d5ea7
Author:     Lai Jiangshan <[email protected]>
AuthorDate: Wed, 26 Jan 2011 16:49:00 +0800
Committer:  Steven Rostedt <[email protected]>
CommitDate: Tue, 8 Feb 2011 17:14:54 -0500

tracing: Compile time initialization for event flags value

Compile time initialization is better than runtime initialization.

Remove many early_initcall()s and many trace_init_flags_##name()s.

Acked-by Frederic Weisbecker <[email protected]>
Signed-off-by Lai Jiangshan <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by Steven Rostedt <[email protected]>
---
 include/linux/syscalls.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
include/linux/syscalls.h +4 -4
index 8e8968e..a17fcea 100644
@@ -132,11 +132,11 @@ extern struct trace_event_functions exit_syscall_print_funcs;
 		.class			= &event_class_syscall_enter,	\
 		.event.funcs            = &enter_syscall_print_funcs,	\
 		.data			= (void *)&__syscall_meta_##sname,\
+		.flags			= TRACE_EVENT_FL_CAP_ANY,	\
 	};								\
 	static struct ftrace_event_call __used				\
 	  __attribute__((section("_ftrace_events")))			\
-	 *__event_enter_##sname = &event_enter_##sname;			\
-	__TRACE_EVENT_FLAGS(enter_##sname, TRACE_EVENT_FL_CAP_ANY)
+	 *__event_enter_##sname = &event_enter_##sname;
 
 #define SYSCALL_TRACE_EXIT_EVENT(sname)					\
 	static struct syscall_metadata __syscall_meta_##sname;		\

@@ -146,11 +146,11 @@ extern struct trace_event_functions exit_syscall_print_funcs;
 		.class			= &event_class_syscall_exit,	\
 		.event.funcs		= &exit_syscall_print_funcs,	\
 		.data			= (void *)&__syscall_meta_##sname,\
+		.flags			= TRACE_EVENT_FL_CAP_ANY,	\
 	};								\
 	static struct ftrace_event_call __used				\
 	  __attribute__((section("_ftrace_events")))			\
-	*__event_exit_##sname = &event_exit_##sname;			\
-	__TRACE_EVENT_FLAGS(exit_##sname, TRACE_EVENT_FL_CAP_ANY)
+	*__event_exit_##sname = &event_exit_##sname;
 
 #define SYSCALL_METADATA(sname, nb)				\
 	SYSCALL_TRACE_ENTER_EVENT(sname);			\