Skip to contentSkip to conversation

Publishing mips_hpt_frequency in /proc/cpuinfo

PATCH Earl Chew 3 participants 4 messages Jan 28, 2011 MIPS

lore
Share & tools
lore

Earl Chew

author
#0 lore raw

The CPU frequency is known to the Linux kernel. For example:

Quoted 4 lines

CPU revision is: 00019374 (MIPS 24Kc)
Atheros AR7161 rev 2, CPU:680.000 MHz, AHB:170.000 MHz, DDR:340.000 MHz
...
Calibrating delay loop... 452.19 BogoMIPS (lpj=2260992)

Unfortunately that information is not available from userspace:

Quoted 2 lines

cpu model : MIPS 24Kc V7.4
BogoMIPS : 452.19

This makes it difficult to use CPU timers (rdhwr) from user space applications.

Is there any reason not to publish mips_hpt_frequency in /proc/cpuinfo ?

Earl

tmp/proc.c 2011-01-27 20:56:18.807454356 -0800 renamed from proc.c 2011-01-17 14:05:16.397444347 -0800 +3 -0
@@ -43,6 +43,9 @@
        seq_printf(m, "BogoMIPS\t\t: %u.%02u\n",
                      cpu_data[n].udelay_val / (500000/HZ),
                      (cpu_data[n].udelay_val / (5000/HZ)) % 100);
+       seq_printf(m, "timer frequency\t: %u.%03u\n",
+                     mips_hpt_frequency / 1000000,
+                     mips_hpt_frequency % 1000000 / 1000);
        seq_printf(m, "wait instruction\t: %s\n", cpu_wait ? "yes" : "no");
        seq_printf(m, "microsecond timers\t: %s\n",
                      cpu_has_counter ? "yes" : "no");
#1 lore raw
Quoted 9 lines · Earl Chew

The CPU frequency is known to the Linux kernel. For example:

Quoted 4 lines

CPU revision is: 00019374 (MIPS 24Kc)
Atheros AR7161 rev 2, CPU:680.000 MHz, AHB:170.000 MHz, DDR:340.000 MHz
...
Calibrating delay loop... 452.19 BogoMIPS (lpj=2260992)

Unfortunately that information is not available from userspace:

Quoted 8 lines
Quoted 2 lines

cpu model : MIPS 24Kc V7.4
BogoMIPS : 452.19

This makes it difficult to use CPU timers (rdhwr) from user space applications.

Is there any reason not to publish mips_hpt_frequency in /proc/cpuinfo ?

The CPU clock frequency may change at any time due to clockscaling A process might be rescheduled to another CPU running at a different clock rate. A suspended process might miss counter wraparounds.

This right approach is to handle this in a virtual syscall, something like vsys_clock_gettime().

Ralf

#2 lore raw
Quoted 18 lines · Ralf Baechle
Quoted 16 lines · Earl Chew

The CPU frequency is known to the Linux kernel. For example:

Quoted 4 lines

CPU revision is: 00019374 (MIPS 24Kc)
Atheros AR7161 rev 2, CPU:680.000 MHz, AHB:170.000 MHz, DDR:340.000 MHz
...
Calibrating delay loop... 452.19 BogoMIPS (lpj=2260992)

Unfortunately that information is not available from userspace:

Quoted 2 lines

cpu model : MIPS 24Kc V7.4
BogoMIPS : 452.19

This makes it difficult to use CPU timers (rdhwr) from user space applications.

Quoted 8 lines
Quoted 1 line

Is there any reason not to publish mips_hpt_frequency in /proc/cpuinfo ?

The CPU clock frequency may change at any time due to clockscaling A process might be rescheduled to another CPU running at a different clock rate. A suspended process might miss counter wraparounds.

This right approach is to handle this in a virtual syscall, something like vsys_clock_gettime().

Right. We had this discussion on x86 over and over and using a vsyscall is the correct approach. That's also a huge win in general if you can avoid going into the kernel to read the time. gettimeofday() and clock_gettime() belong to the most frequently called syscalls on any Linux system.

Thanks,

tglx

author
#3 lore raw
Quoted 6 lines · Ralf Baechle

The CPU clock frequency may change at any time due to clockscaling A process might be rescheduled to another CPU running at a different clock rate. A suspended process might miss counter wraparounds.

This right approach is to handle this in a virtual syscall, something like vsys_clock_gettime().

Quoted 5 lines · Thomas Gleixner

Right. We had this discussion on x86 over and over and using a vsyscall is the correct approach. That's also a huge win in general if you can avoid going into the kernel to read the time. gettimeofday() and clock_gettime() belong to the most frequently called syscalls on any Linux system.

Ralf, Thomas,

Yes, I have seen that code on x86, and I completely agree with you both. The scenarios that Ralf described pertinent, but for my currently application the win of not going to the kernel that Thomas described is much more important.

I would very much like to go down the vsyscall route, but I can't see any of that infrastructure in the arch/mips subdirectories.

It seems to me that that work has not been started for MIPS. Am I mistaken ?

[ I'm trying to figure out where I should start. ]

Looking in /proc/cpuinfo for x86 I see:

Quoted 7 lines

processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 28
model name : Intel(R) Atom(TM) CPU D510 @ 1.66GHz
stepping : 10
cpu MHz : 1666.670

This makes available the clock frequency of the CPU. To get similar information for MIPS, I need to rummage around inside dmesg:

Quoted 2 lines

CPU revision is: 00019374 (MIPS 24Kc)
Atheros AR7161 rev 2, CPU:680.000 MHz, AHB:170.000 MHz, DDR:340.000 MHz

Would you be averse to publishing additional CPU information (include cpu MHz) in /proc/cpuinfo for MIPS ?

Earl