Skip to contentSkip to conversation

depca: Fix warnings

PATCH Applied Alan Cox 2 participants 2 messages Feb 1, 2011

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 depca: Fix warnings

From: Alan Cox <[email protected]>

Replace the rather weird use of ++ with + 1 as the value is being assigned

Signed-off-by Alan Cox <[email protected]>

---

 drivers/net/depca.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/depca.c +3 -3
index 1b48b68..8b0084d 100644
@@ -1094,7 +1094,7 @@ static int depca_rx(struct net_device *dev)
 				}
 			}
 			/* Change buffer ownership for this last frame, back to the adapter */
-			for (; lp->rx_old != entry; lp->rx_old = (++lp->rx_old) & lp->rxRingMask) {
+			for (; lp->rx_old != entry; lp->rx_old = (lp->rx_old + 1) & lp->rxRingMask) {
 				writel(readl(&lp->rx_ring[lp->rx_old].base) | R_OWN, &lp->rx_ring[lp->rx_old].base);
 			}
 			writel(readl(&lp->rx_ring[entry].base) | R_OWN, &lp->rx_ring[entry].base);

@@ -1103,7 +1103,7 @@ static int depca_rx(struct net_device *dev)
 		/*
 		   ** Update entry information
 		 */
-		lp->rx_new = (++lp->rx_new) & lp->rxRingMask;
+		lp->rx_new = (lp->rx_new + 1) & lp->rxRingMask;
 	}
 
 	return 0;

@@ -1148,7 +1148,7 @@ static int depca_tx(struct net_device *dev)
 		}
 
 		/* Update all the pointers */
-		lp->tx_old = (++lp->tx_old) & lp->txRingMask;
+		lp->tx_old = (lp->tx_old + 1) & lp->txRingMask;
 	}
 
 	return 0;