mptfusion: mptctl_release is required in mptctl.c

PATCH In review Kashyap, Desai 3 participants 5 messages Feb 3, 2011 – Feb 4, 2011

Subsystems (2)

SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)

lore

Share & tools

lore

Kashyap, Desai

author

2011-02-03 10:49 UTC #0 lore raw

PATCH 4/6 mptfusion: mptctl_release is required in mptctl.c

Added missing release callback for file_operations mptctl_fops. Without release callback there will be never freed. It remains on mptctl's eent list even after the file is closed and released.

Relavent RHEL bugzilla is 660871

Signed-off-by Kashyap Desai <[email protected]>

---

drivers/message/fusion/mptctl.c +8 -0

index a3856ed..e8deb8e 100644
@@ -597,6 +597,13 @@ mptctl_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *pEvReply)
 }
 
 static int
+mptctl_release(struct inode *inode, struct file *filep)
+{
+	fasync_helper(-1, filep, 0, &async_queue);
+	return 0;
+}
+
+static int
 mptctl_fasync(int fd, struct file *filep, int mode)
 {
 	MPT_ADAPTER	*ioc;

@@ -2815,6 +2822,7 @@ static const struct file_operations mptctl_fops = {
 	.llseek =	no_llseek,
 	.fasync = 	mptctl_fasync,
 	.unlocked_ioctl = mptctl_ioctl,
+	.release =	mptctl_release,
 #ifdef CONFIG_COMPAT
 	.compat_ioctl = compat_mpctl_ioctl,
 #endif

Greg KH

2011-02-03 17:21 UTC #1 lore raw

Quoted 9 lines · Desai

Added missing release callback for file_operations mptctl_fops. Without release callback there will be never freed. It remains on mptctl's eent list even after the file is closed and released.
Relavent RHEL bugzilla is 660871
Signed-off-by Kashyap Desai <[email protected]>
---

<snip>

This is NOT the way to get patches into a stable kernel release. Please read the file, Documentation/stable_kernel_rules.txt for how to do it properly.

thanks,

greg k-h

Desai, Kashyap

author

2011-02-04 06:50 UTC #2 lore raw

Quoted 22 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 03, 2011 10:50 PM
To: Desai, Kashyap
Cc: [email protected]; [email protected]; Prakash, Sathya; Moore, Eric; [email protected]
Subject: Re: [stable] [PATCH 04/06] mptfusion: mptctl_release is required in mptctl.c
Quoted 9 lines · Desai
Added missing release callback for file_operations mptctl_fops. Without release callback there will be never freed. It remains on mptctl's eent list even after the file is closed and released.
Relavent RHEL bugzilla is 660871
Signed-off-by Kashyap Desai <[email protected]>
---

Quoted 6 lines

<snip>
This is NOT the way to get patches into a stable kernel release. Please
read the file, Documentation/stable_kernel_rules.txt for how to do it properly.

Greg, Thanks for the redirecting to correct process. I understood that I have to add "CC: [email protected] " in header of the patch itself instead of CCing [email protected] from email client.
Do I need to resend those patches?

~ Kashyap

Quoted 4 lines

thanks,
greg k-h

Greg KH

2011-02-04 14:50 UTC #3 lore raw

Quoted 30 lines · Kashyap

Quoted 22 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 03, 2011 10:50 PM
To: Desai, Kashyap
Cc: [email protected]; [email protected]; Prakash, Sathya; Moore, Eric; [email protected]
Subject: Re: [stable] [PATCH 04/06] mptfusion: mptctl_release is required in mptctl.c
Quoted 9 lines · Desai
Added missing release callback for file_operations mptctl_fops. Without release callback there will be never freed. It remains on mptctl's eent list even after the file is closed and released.
Relavent RHEL bugzilla is 660871
Signed-off-by Kashyap Desai <[email protected]>
---
Quoted 6 lines
<snip>
This is NOT the way to get patches into a stable kernel release. Please
read the file, Documentation/stable_kernel_rules.txt for how to do it properly.

Quoted 4 lines

Greg, Thanks for the redirecting to correct process. I understood that I have to add "CC: [email protected] " in header of the patch itself instead of CCing [email protected] from email client.
Do I need to resend those patches?

To get these into a stable release? I don't know, that's up to the subsystem maintainer if he is going to be willing to edit the patch and add that line himself.

I'd defer and resend it to make sure it gets there.

good luck,

greg k-h

James Bottomley

maintainer

2011-02-04 14:54 UTC #4 lore raw

In reply to Desai, Kashyap

Quoted 29 lines · Kashyap

Quoted 21 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 03, 2011 10:50 PM
To: Desai, Kashyap
Cc: [email protected]; [email protected]; Prakash, Sathya; Moore, Eric; [email protected]
Subject: Re: [stable] [PATCH 04/06] mptfusion: mptctl_release is required in mptctl.c
Quoted 9 lines · Desai
Added missing release callback for file_operations mptctl_fops. Without release callback there will be never freed. It remains on mptctl's eent list even after the file is closed and released.
Relavent RHEL bugzilla is 660871
Signed-off-by Kashyap Desai <[email protected]>
---
Quoted 6 lines
<snip>
This is NOT the way to get patches into a stable kernel release. Please
read the file, Documentation/stable_kernel_rules.txt for how to do it properly.

Quoted 3 lines

Greg, Thanks for the redirecting to correct process. I understood that I have to add "CC: [email protected] " in header of the patch itself instead of CCing [email protected] from email client.
Do I need to resend those patches?

Well, as I said, I need the series split into enhancements and bug fixes ... so why not do that with a resend and add it?

James