Skip to contentSkip to conversation

OMAP: McBSP: Remove unused audio macros in mcbsp.h

PATCH In review Kishon Vijay Abraham I 5 participants 5 messages Feb 4, 2011 – Feb 14, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP: McBSP: Remove unused audio macros in mcbsp.h

Some macros defined in mcbsp.h related to audio, which are never being used is removed.

---
 arch/arm/plat-omap/include/plat/mcbsp.h |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
arch/arm/plat-omap/include/plat/mcbsp.h +0 -14
index b87d83c..6ecf105 100644
@@ -106,13 +106,6 @@ static struct platform_device omap_mcbsp##port_nr = {	\
 #define OMAP_MCBSP_REG_XCCR	0x00
 #define OMAP_MCBSP_REG_RCCR	0x00
 
-#define AUDIO_MCBSP_DATAWRITE	(OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DXR1)
-#define AUDIO_MCBSP_DATAREAD	(OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DRR1)
-
-#define AUDIO_MCBSP		OMAP_MCBSP1
-#define AUDIO_DMA_TX		OMAP_DMA_MCBSP1_TX
-#define AUDIO_DMA_RX		OMAP_DMA_MCBSP1_RX
-
 #else
 
 #define OMAP_MCBSP_REG_DRR2	0x00
@@ -168,13 +161,6 @@ static struct platform_device omap_mcbsp##port_nr = {	\
 #define OMAP_ST_REG_SFIRCR	0x28
 #define OMAP_ST_REG_SSELCR	0x2C
 
-#define AUDIO_MCBSP_DATAWRITE	(OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DXR1)
-#define AUDIO_MCBSP_DATAREAD	(OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DRR1)
-
-#define AUDIO_MCBSP		OMAP_MCBSP2
-#define AUDIO_DMA_TX		OMAP24XX_DMA_MCBSP2_TX
-#define AUDIO_DMA_RX		OMAP24XX_DMA_MCBSP2_RX
-
 #endif
 
 /************************** McBSP SPCR1 bit definitions ***********************/
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Fri, 4 Feb 2011 14:45:09 +0530 Kishon Vijay Abraham I <[email protected]> wrote:

Some macros defined in mcbsp.h related to audio, which are never being used is removed.

---
 arch/arm/plat-omap/include/plat/mcbsp.h |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
Acked-by on v1 1/1
#2 lore raw
In reply to Kishon Vijay Abraham I
Quoted 9 lines · ext Kishon Vijay Abraham I

Some macros defined in mcbsp.h related to audio, which are never being used is removed.

---
 arch/arm/plat-omap/include/plat/mcbsp.h |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
Acked-by on v1 1/1
#3 lore raw
In reply to Kishon Vijay Abraham I
Quoted 15 lines · Kishon Vijay Abraham I

Some macros defined in mcbsp.h related to audio, which are never being used is removed.

---
 arch/arm/plat-omap/include/plat/mcbsp.h |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
arch/arm/plat-omap/include/plat/mcbsp.h +0 -0
index b87d83c..6ecf105 100644

arch/arm/plat-omap/include/plat/mcbsp.h static struct platform_device omap_mcbsp##port_nr = { \ · line 114

Quoted 9 lines
arch/arm/plat-omap/include/plat/mcbsp.h +0 -6
@@ -106,13 +106,6 @@ static struct platform_device omap_mcbsp##port_nr = {	\
 #define OMAP_MCBSP_REG_XCCR	0x00
 #define OMAP_MCBSP_REG_RCCR	0x00
 
-#define AUDIO_MCBSP_DATAWRITE	(OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DXR1)
-#define AUDIO_MCBSP_DATAREAD	(OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DRR1)
-
-#define AUDIO_MCBSP		OMAP_MCBSP1
-#define AUDIO_DMA_TX		OMAP_DMA_MCBSP1_TX
-#define AUDIO_DMA_RX		OMAP_DMA_MCBSP1_RX

Thanks. I have patch in my git repo to cleanup all unwanted dma macros. I will remove mcbsp dma related declarations in my patch.

-Manjunath

Quoted 25 lines
arch/arm/plat-omap/include/plat/mcbsp.h +0 -8
-
 #else
 
 #define OMAP_MCBSP_REG_DRR2	0x00
@@ -168,13 +161,6 @@ static struct platform_device omap_mcbsp##port_nr = {	\
 #define OMAP_ST_REG_SFIRCR	0x28
 #define OMAP_ST_REG_SSELCR	0x2C
 
-#define AUDIO_MCBSP_DATAWRITE	(OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DXR1)
-#define AUDIO_MCBSP_DATAREAD	(OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DRR1)
-
-#define AUDIO_MCBSP		OMAP_MCBSP2
-#define AUDIO_DMA_TX		OMAP24XX_DMA_MCBSP2_TX
-#define AUDIO_DMA_RX		OMAP24XX_DMA_MCBSP2_RX
-
 #endif
 
 /************************** McBSP SPCR1 bit definitions ***********************/
Signature · 6 lines
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw
In reply to Kishon Vijay Abraham I
Quoted 2 lines · Kishon Vijay Abraham I

Some macros defined in mcbsp.h related to audio, which are never being used is removed.

Applying this to devel-cleanup branch for the upcoming merge window.

Tony