Skip to contentSkip to conversation

fix: domains do not get created when using vifname variable for bridged interfaces

PATCH New Patrick Scharrenberg 1 participant 1 message Feb 5, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix: domains do not get created when using vifname variable for bridged interfaces

In the two scripts vif-bridge and vif-route the variable containing the right interface-name, after an interface was renamed using "ifname", is $vif. Otherwise hotplug can't handle renamed interfaces and prevents xm from creating domains.

---

Please apply to unstable.

In 4.0.x the scripts are correct.
In unstable only vif-route contains the right variables

tools/hotplug/Linux/vif-bridge Sat Feb 05 14:11:52 2011 +0100 renamed from tools/hotplug/Linux/vif-bridge Mon Jan 31 17:46:55 2011 +0000 +7 -7
diff -r e7b31cc0093c tools/hotplug/Linux/vif-bridge
@@ -81,18 +81,18 @@
 
 case "$command" in
     online)
-        setup_virtual_bridge_port "$dev"
-        add_to_bridge "$bridge" "$dev"
+        setup_virtual_bridge_port "$vif"
+        add_to_bridge "$bridge" "$vif"
         ;;
 
     offline)
-        do_without_error brctl delif "$bridge" "$dev"
-        do_without_error ifconfig "$dev" down
+        do_without_error brctl delif "$bridge" "$vif"
+        do_without_error ifconfig "$vif" down
         ;;
 
     add)
-        setup_virtual_bridge_port "$dev"
-        add_to_bridge "$bridge" "$dev"
+        setup_virtual_bridge_port "$vif"
+        add_to_bridge "$bridge" "$vif"
         ;;
 esac
 
@@ -100,7 +100,7 @@
     handle_iptable
 fi
 
-log debug "Successful vif-bridge $command for $dev, bridge $bridge."
+log debug "Successful vif-bridge $command for $vif, bridge $bridge."
 if [ "$type_if" = vif -a "$command" = "online" ]
 then
   success