Skip to contentSkip to conversation

Fix control channel shutdown in case of errors.

PATCH In review [email protected] 2 participants 2 messages Feb 4, 2011 – Feb 7, 2011 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix control channel shutdown in case of errors.

From: Jaikumar Ganesh <[email protected]>

When there are connection errors, like host is down, when establishing the control channel connection, the control io channel was not being shutdown. This will cause future connections to fail.

---
 input/device.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
input/device.c +1 -0
index 5cb57ea..21f8329 100644
@@ -856,6 +856,7 @@ static void control_connect_cb(GIOChannel *chan, GError *conn_err,
 		error("%s", conn_err->message);
 		reply = btd_error_failed(iconn->pending_connect,
 						conn_err->message);
+		g_io_channel_shutdown(chan, TRUE, NULL);
 		goto failed;
 	}
 
Signature · 1 line
1.7.3.1
#1 lore raw

Hi Jaikumar,

Quoted 7 lines · On Fri, Feb 04, 2011, [email protected] wrote:

When there are connection errors, like host is down, when establishing the control channel connection, the control io channel was not being shutdown. This will cause future connections to fail.

---
 input/device.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, there were several other issues present (which we already discussed) so a little bit different (and more comprehensive) patch has now been pushed upstream.

Johan