Skip to contentSkip to conversation

perf: fix compile error in annotate.h

PATCH In review Stephane Eranian 3 participants 4 messages Feb 8, 2011 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf: fix compile error in annotate.h

The following patch is necessary to compile without NEWT.

---

tools/perf/util/annotate.h +1 -1
index b1253aa..bc08b36 100644
@@ -82,7 +82,7 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map, int evidx,
 			 int max_lines);
 
 #ifdef NO_NEWT_SUPPORT
-static inline int symbol__tui_annotate(symbol *sym __used,
+static inline int symbol__tui_annotate(struct symbol *sym __used,
 				       struct map *map __used, int evidx __used)
 {
 	return 0;
#1 lore raw

Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu:

Quoted 1 line

The following patch is necessary to compile without NEWT.

Merged already, Borislav Petkov sent a similar patch.

Thanks,

- Arnaldo

Quoted 16 lines

---

tools/perf/util/annotate.h +1 -1
index b1253aa..bc08b36 100644
@@ -82,7 +82,7 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map, int evidx,
 			 int max_lines);
 
 #ifdef NO_NEWT_SUPPORT
-static inline int symbol__tui_annotate(symbol *sym __used,
+static inline int symbol__tui_annotate(struct symbol *sym __used,
 				       struct map *map __used, int evidx __used)
 {
 	return 0;
#2 lore raw
Quoted 4 lines · Arnaldo Carvalho de Melo

Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu:

Quoted 1 line

The following patch is necessary to compile without NEWT.

Merged already, Borislav Petkov sent a similar patch.

I just pushed it out - Stephane, mind checking that latest -tip indeed fixes things for you?

Thanks,

Ingo

author Acked-by
#3 lore raw
Quoted 11 lines · Ingo Molnar
Quoted 4 lines · Arnaldo Carvalho de Melo

Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu:

Quoted 1 line

The following patch is necessary to compile without NEWT.

Merged already, Borislav Petkov sent a similar patch.

I just pushed it out - Stephane, mind checking that latest -tip indeed fixes things for you?

Works for me now, thanks.