Skip to contentSkip to conversation

Add package bonnie++

PATCH New Martin Hicks 3 participants 6 messages Feb 1, 2011 – Feb 14, 2011

lore
Share & tools
lore

Martin Hicks

author
#0 lore raw

PATCH 1/1 Add package bonnie++

A good filesystem performance benchmark program

Signed-off-by Martin Hicks <[email protected]>
---
 package/Config.in        |    1 +
 package/bonnie/Config.in |    6 ++++++
 package/bonnie/bonnie.mk |   18 ++++++++++++++++++
 3 files changed, 25 insertions(+), 0 deletions(-)
 create mode 100644 package/bonnie/Config.in
 create mode 100644 package/bonnie/bonnie.mk
package/Config.in +1 -0
index 631bb80..49859b1 100644
@@ -17,6 +17,7 @@ source "package/xz/Config.in"
 endmenu
 
 menu "Debugging, profiling and benchmark"
+source "package/bonnie/Config.in"
 source "package/dhrystone/Config.in"
 source "package/dmalloc/Config.in"
 source "package/kexec/Config.in"
package/bonnie/Config.in new file +6 -0
new file mode 100644
index 0000000..6bef13b
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BONNIE
+	bool "bonnie++"
+	help
+          Filesystem tester
+
+	  http://www.coker.com.au/bonnie++/
package/bonnie/bonnie.mk new file +18 -0
new file mode 100644
index 0000000..03fce50
@@ -0,0 +1,18 @@
+#
+# bonnie++
+#
+BONNIE_VERSION = 1.03e
+BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
+BONNIE_SITE = http://www.coker.com.au/bonnie++/
+BONNIE_INSTALL_TARGET_OPT = INSTALL="install -m 0755" install-bin
+
+define BONNIE_INSTALL_TARGET_CMDS
+	install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin
+	install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin
+endef
+
+define BONNIE_UNINSTALL_TARGET_CMDS
+	rm -f $(TARGET_DIR)/usr/sbin/bonnie++ $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+$(eval $(call AUTOTARGETS,package,bonnie))
Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/1 Add package bonnie++

Hello,

Quoted 3 lines · On Tue, 1 Feb 2011 12:19:00 -0500 Martin Hicks <[email protected]> wrote:

A good filesystem performance benchmark program

Signed-off-by Martin Hicks <[email protected]>

Thanks for this package. Some comments below.

package/bonnie/Config.in line 4

Quoted 4 lines
package/bonnie/Config.in new file +4 -0
+config BR2_PACKAGE_BONNIE
+	bool "bonnie++"
+	help
+          Filesystem tester

Here the indent should be one tab + two spaces.

package/bonnie/bonnie.mk line 7

Quoted 4 lines
package/bonnie/bonnie.mk new file +4 -0
+BONNIE_VERSION = 1.03e
+BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
+BONNIE_SITE = http://www.coker.com.au/bonnie++/
+BONNIE_INSTALL_TARGET_OPT = INSTALL="install -m 0755" install-bin

This is not needed if you override the installation as done below by BONNE_INSTALL_TARGET_CMDS.

package/bonnie/bonnie.mk line 10

Quoted 2 lines
package/bonnie/bonnie.mk new file +2 -0
+define BONNIE_INSTALL_TARGET_CMDS
+	install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin

should be

install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin/bonnie++

package/bonnie/bonnie.mk line 11

Quoted 1 line
package/bonnie/bonnie.mk new file +1 -0
+	install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin

should be

install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin/zcav

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 V2: Add package bonnie++

A good filesystem performance benchmark program.
Fixed up a few things requested by reviewers.

Signed-off-by Martin Hicks <[email protected]>
---
 package/Config.in        |    1 +
 package/bonnie/Config.in |    6 ++++++
 package/bonnie/bonnie.mk |   17 +++++++++++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 package/bonnie/Config.in
 create mode 100644 package/bonnie/bonnie.mk
package/Config.in +1 -0
index 631bb80..49859b1 100644
@@ -17,6 +17,7 @@ source "package/xz/Config.in"
 endmenu
 
 menu "Debugging, profiling and benchmark"
+source "package/bonnie/Config.in"
 source "package/dhrystone/Config.in"
 source "package/dmalloc/Config.in"
 source "package/kexec/Config.in"
package/bonnie/Config.in new file +6 -0
new file mode 100644
index 0000000..ff4988b
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BONNIE
+	bool "bonnie++"
+	help
+	  Filesystem tester
+
+	  http://www.coker.com.au/bonnie++/
package/bonnie/bonnie.mk new file +17 -0
new file mode 100644
index 0000000..87f5fbc
@@ -0,0 +1,17 @@
+#
+# bonnie++
+#
+BONNIE_VERSION = 1.03e
+BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
+BONNIE_SITE = http://www.coker.com.au/bonnie++/
+
+define BONNIE_INSTALL_TARGET_CMDS
+	install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin/bonnie++
+	install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+define BONNIE_UNINSTALL_TARGET_CMDS
+	rm -f $(TARGET_DIR)/usr/sbin/bonnie++ $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+$(eval $(call AUTOTARGETS,package,bonnie))
Signature · 1 line
1.5.6.5
#3 lore raw

PATCH 1/1 V2: Add package bonnie++

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Martin" == Martin Hicks <[email protected]> writes:

Martin> A good filesystem performance benchmark program. Martin> Fixed up a few things requested by reviewers.

Bonnie++ is implemented in C++, right? If so, you need to depend on LIBSTDCPP (and add a comment statement if it isn't available) - See E.G. package/iperf/Config.in for an example.

Signature · 1 line
Bye, Peter Korsgaard
author
#4 lore raw

PATCH 1/1 V2: Add package bonnie++

Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Martin" == Martin Hicks <[email protected]> writes:

Martin> A good filesystem performance benchmark program. Martin> Fixed up a few things requested by reviewers.

Bonnie++ is implemented in C++, right? If so, you need to depend on LIBSTDCPP (and add a comment statement if it isn't available) - See E.G. package/iperf/Config.in for an example.

Okay. here's the updated patch:

author
#5 lore raw

PATCH 1/1 V2: Add package bonnie++

Were any other changes needed for this patch?

Thanks,
mh

Quoted 89 lines · Martin Hicks
Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Martin" == Martin Hicks <[email protected]> writes:

?Martin> A good filesystem performance benchmark program. ?Martin> Fixed up a few things requested by reviewers.

Bonnie++ is implemented in C++, right? If so, you need to depend on LIBSTDCPP (and add a comment statement if it isn't available) - See E.G. package/iperf/Config.in for an example.

Okay. ?here's the updated patch:

From 6b6e22d5a981069019db09fa68df5a7de0c892f4 Mon Sep 17 00:00:00 2001
From: Martin Hicks <[email protected]>
Date: Mon, 31 Jan 2011 15:32:06 -0500
Subject: [PATCH] Add package bonnie++

A good filesystem performance benchmark program

Signed-off-by Martin Hicks <[email protected]>

---

?package/Config.in ? ? ? ?| ? ?1 +
?package/bonnie/Config.in | ? 10 ++++++++++
?package/bonnie/bonnie.mk | ? 17 +++++++++++++++++

?3 files changed, 28 insertions(+), 0 deletions(-) ?create mode 100644 package/bonnie/Config.in ?create mode 100644 package/bonnie/bonnie.mk

package/Config.in +0 -0
index 631bb80..49859b1 100644
@@ -17,6 +17,7 @@ source "package/xz/Config.in"

?endmenu

?menu "Debugging, profiling and benchmark"
+source "package/bonnie/Config.in"
?source "package/dhrystone/Config.in"
?source "package/dmalloc/Config.in"
?source "package/kexec/Config.in"

package/bonnie/Config.in new file +10 -0
new file mode 100644
index 0000000..926d917
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_BONNIE
+ ? ? ? bool "bonnie++"
+ ? ? ? depends on BR2_INSTALL_LIBSTDCPP
+ ? ? ? help
+ ? ? ? ? Filesystem tester
+
+ ? ? ? ? http://www.coker.com.au/bonnie++/
+
+comment "bonnie requires a toolchain with C++ support enabled"
+ ? ? ? depends on !BR2_INSTALL_LIBSTDCPP
package/bonnie/bonnie.mk new file +17 -1
new file mode 100644
index 0000000..87f5fbc
@@ -0,0 +1,17 @@
+#
+# bonnie++
+#
+BONNIE_VERSION = 1.03e
+BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
+BONNIE_SITE = http://www.coker.com.au/bonnie++/
+
+define BONNIE_INSTALL_TARGET_CMDS
+ ? ? ? install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin/bonnie++
+ ? ? ? install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+define BONNIE_UNINSTALL_TARGET_CMDS
+ ? ? ? rm -f $(TARGET_DIR)/usr/sbin/bonnie++ $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+$(eval $(call AUTOTARGETS,package,bonnie))
--

1.5.6.5

--
Martin Hicks P.Eng. ? ?| ? ? ?mort at bork.org
Bork Consulting Inc. ? | ?+1 (613) 266-2296

Signature · 2 lines
Martin Hicks P.Eng. ?? ? | ? ? ? ? mort at bork.org
Bork Consulting Inc. ? ? | ? +1 (613) 266-2296