Skip to contentSkip to conversation

DaVinci: fix compilation warnings in <mach/clkdev.h>

PATCH New Sergei Shtylyov 3 participants 4 messages Feb 9, 2011 – Feb 23, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures TI DaVinci machine support
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH 1/1 DaVinci: fix compilation warnings in <mach/clkdev.h>

Commit 6d803ba736abb5e122dede70a4720e4843dd6df4 (ARM: 6483/1: arm & sh:
factorised duplicated clkdev.c) caused the following warnings:

In file included from /home/headless/src/kernel.org/linux-davinci/arch/arm/ include/asm/clkdev.h:17,
from include/linux/clkdev.h:15,
from arch/arm/mach-davinci/clock.h:71,
from arch/arm/mach-davinci/common.c:22:
arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: `struct clk' declared inside parameter list arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/mach-davinci/include/mach/clkdev.h:9: warning: `struct clk' declared inside parameter list

Signed-off-by Sergei Shtylyov <[email protected]>

---
The patch is against the recent DaVinci tree.

 arch/arm/mach-davinci/include/mach/clkdev.h |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-davinci/include/mach/clkdev.h +2 -0
Index: linux-davinci/arch/arm/mach-davinci/include/mach/clkdev.h
===================================================================
@@ -1,6 +1,8 @@
 #ifndef __MACH_CLKDEV_H
 #define __MACH_CLKDEV_H
 
+struct clk;
+
 static inline int __clk_get(struct clk *clk)
 {
 	return 1;
#1 lore raw

PATCH 1/1 DaVinci: fix compilation warnings in <mach/clkdev.h>

Hello.

Quoted 28 lines · I wrote:

Commit 6d803ba736abb5e122dede70a4720e4843dd6df4 (ARM: 6483/1: arm & sh:
factorised duplicated clkdev.c) caused the following warnings:

In file included from /home/headless/src/kernel.org/linux-davinci/arch/arm/ include/asm/clkdev.h:17,
from include/linux/clkdev.h:15,
from arch/arm/mach-davinci/clock.h:71,
from arch/arm/mach-davinci/common.c:22:
arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: `struct clk' declared inside parameter list arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/mach-davinci/include/mach/clkdev.h:9: warning: `struct clk' declared inside parameter list

Signed-off-by Sergei Shtylyov <[email protected]>

---
The patch is against the recent DaVinci tree.

 arch/arm/mach-davinci/include/mach/clkdev.h |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-davinci/arch/arm/mach-davinci/include/mach/clkdev.h
===================================================================

arch/arm/mach-davinci/include/mach/clkdev.h line 8

Quoted 8 lines
arch/arm/mach-davinci/include/mach/clkdev.h +2 -0
@@ -1,6 +1,8 @@
 #ifndef __MACH_CLKDEV_H
 #define __MACH_CLKDEV_H
 
+struct clk;
+
 static inline int __clk_get(struct clk *clk)
 {
 	return 1;

Kevin, Sekhar, will you apply this?

WBR, Sergei

#2 lore raw

PATCH 1/1 DaVinci: fix compilation warnings in <mach/clkdev.h>

Hi Sergei,

Quoted 1 line · Sergei Shtylyov

Kevin, Sekhar, will you apply this?

Last two weeks were pretty busy for me and there has been a patch backlog. I started today with testing of Mike's SPI patches.

I should get to your patches this week itself.

Thanks,
Sekhar

#3 lore raw

PATCH 1/1 DaVinci: fix compilation warnings in <mach/clkdev.h>

In reply to Sergei Shtylyov

Hi Sergei,

Quoted 18 lines · Sergei Shtylyov

Commit 6d803ba736abb5e122dede70a4720e4843dd6df4 (ARM: 6483/1: arm & sh:
factorised duplicated clkdev.c) caused the following warnings:

In file included from /home/headless/src/kernel.org/linux-davinci/arch/arm/ include/asm/clkdev.h:17,
from include/linux/clkdev.h:15,
from arch/arm/mach-davinci/clock.h:71,
from arch/arm/mach-davinci/common.c:22:
arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: `struct clk' declared inside parameter list arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/mach-davinci/include/mach/clkdev.h:9: warning: `struct clk' declared inside parameter list

Signed-off-by Sergei Shtylyov <[email protected]>

arch/arm/mach-davinci/include/mach/clkdev.h line 8

Quoted 5 lines
arch/arm/mach-davinci/include/mach/clkdev.h +2 -0
+struct clk;
+
 static inline int __clk_get(struct clk *clk)
 {
 	return 1;

This looks good to me. It should be queued for 2.6.38-rc Kevin is going to handle the 2.6.38 and 2.6.39 kernels so will queue this for him.

Thanks,
Sekhar