Skip to contentSkip to conversation

btusb:fix crash with quirky dongles doing sound

PATCH Applied Oliver Neukum 2 participants 2 messages Feb 11, 2011 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btusb:fix crash with quirky dongles doing sound

=46rom befd2cd1a7875d395f72b38f2cb89a03f16edaba Mon Sep 17 00:00:00 2001 =46rom: Oliver Neukum <[email protected]>
Date: Fri, 11 Feb 2011 12:35:05 +0100
Subject: [PATCH] btusb:fix crash with quirky dongles doing sound

Quirky dongles sometimes do not use the iso interface which causes a crash with runtime PM

=2D--

 drivers/bluetooth/btusb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/bluetooth/btusb.c +0 -0
index 1da773f..08c8629 100644

=2D-- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -826,7 +826,7 @@ static void btusb_work(struct work_struct *work) =20
if (hdev->conn_hash.sco_num > 0) {
if (!test_bit(BTUSB_DID_ISO_RESUME, &data->flags)) {
=2D err =3D usb_autopm_get_interface(data->isoc);
+ err =3D usb_autopm_get_interface(data->isoc ? data->isoc : data->intf);
if (err < 0) {
clear_bit(BTUSB_ISOC_RUNNING, &data->flags); usb_kill_anchored_urbs(&data->isoc_anchor);
@@ -855,7 +855,7 @@ static void btusb_work(struct work_struct *work) =20
__set_isoc_interface(hdev, 0);
if (test_and_clear_bit(BTUSB_DID_ISO_RESUME, &data->flags))
=2D usb_autopm_put_interface(data->isoc);
+ usb_autopm_put_interface(data->isoc ? data->isoc : data->intf);
}
}
=20
=2D-=20
1.7.1

#1 lore raw

Hi Oliver,

Quoted 5 lines · Oliver Neukum

From befd2cd1a7875d395f72b38f2cb89a03f16edaba Mon Sep 17 00:00:00 2001
From: Oliver Neukum <[email protected]>
Date: Fri, 11 Feb 2011 12:35:05 +0100
Subject: [PATCH] btusb:fix crash with quirky dongles doing sound

Quoted 7 lines

Quirky dongles sometimes do not use the iso interface which causes a crash with runtime PM

---
 drivers/bluetooth/btusb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Applied. It should be in mainline soon. Thanks.

Signature · 2 lines
Gustavo F. Padovan
http://profusion.mobi