[[email protected]: all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and layout_segment field prefix results]

DISCUSSION J. Bruce Fields 2 participants 3 messages Feb 11, 2011 – Feb 15, 2011

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

J. Bruce Fields

author

2011-02-11 15:29 UTC #0 lore raw

Is this something that only shows when pnfs is configured out, maybe?

--b.

----- Forwarded message from "J. Bruce Fields" <[email protected]> -----

Date: Fri, 11 Feb 2011 02:42:18 -0500
From: "J. Bruce Fields" <[email protected]>
To: [email protected]
Subject: all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and
layout_segment field prefix results

6210 all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and layout_segment field prefix fs/cifs/file.c: In function 'cifs_iovec_write':
fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *' fs/cifs/link.c: In function 'symlink_hash':
fs/cifs/link.c:58: warning: 'rc' may be used uninitialized in this function fs/cifs/smbencrypt.c: In function 'mdfour':
fs/cifs/smbencrypt.c:61: warning: 'rc' may be used uninitialized in this function In file included from include/linux/nfsd/nfsd4_pnfs.h:39,

                 from include/linux/nfsd/nfs4layoutxdr.h:38,
                 from fs/nfsd/nfs4proc.c:37:

include/linux/nfs_xdr.h:1124: error: field 'refcount' has incomplete type make[2]: *** [fs/nfsd/nfs4proc.o] Error 1
make[1]: *** [fs/nfsd] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [fs] Error 2
make: *** Waiting for unfinished jobs....

started Fri Feb 11 02:22:03 EST 2011, finished Fri Feb 11 02:42:18 EST 2011

+-----------------------------------------+
|            verbose output               |
+-----------------------------------------+

----- End forwarded message -----

Benny Halevy

2011-02-13 05:22 UTC #1 lore raw

Quoted 1 line · J. Bruce Fields

Is this something that only shows when pnfs is configured out, maybe?

Doesn't show up with my .config, with or without pnfs configured... Does this help?

fs/nfsd/nfs4proc.c +1 -0

index f08ab55..35d2567 100644
@@ -33,6 +33,7 @@
  *  SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #include <linux/file.h>
+#include <linux/kref.h>
 #include <linux/slab.h>
 #include <linux/nfsd/nfs4layoutxdr.h>
 #include <linux/nfsd4_spnfs.h>

Quoted 37 lines

--b.
----- Forwarded message from "J. Bruce Fields" <[email protected]> -----
Date: Fri, 11 Feb 2011 02:42:18 -0500
From: "J. Bruce Fields" <[email protected]>
To: [email protected]
Subject: all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and
layout_segment field prefix results
6210 all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and layout_segment field prefix fs/cifs/file.c: In function 'cifs_iovec_write':
fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *' fs/cifs/link.c: In function 'symlink_hash':
fs/cifs/link.c:58: warning: 'rc' may be used uninitialized in this function fs/cifs/smbencrypt.c: In function 'mdfour':
fs/cifs/smbencrypt.c:61: warning: 'rc' may be used uninitialized in this function In file included from include/linux/nfsd/nfsd4_pnfs.h:39,
                 from include/linux/nfsd/nfs4layoutxdr.h:38,
                 from fs/nfsd/nfs4proc.c:37:
include/linux/nfs_xdr.h:1124: error: field 'refcount' has incomplete type make[2]: *** [fs/nfsd/nfs4proc.o] Error 1
make[1]: *** [fs/nfsd] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [fs] Error 2
make: *** Waiting for unfinished jobs....
started Fri Feb 11 02:22:03 EST 2011, finished Fri Feb 11 02:42:18 EST 2011
+-----------------------------------------+
|            verbose output               |
+-----------------------------------------+
----- End forwarded message -----

J. Bruce Fields

author

2011-02-15 14:55 UTC #2 lore raw

Quoted 4 lines · Benny Halevy

Quoted 1 line · J. Bruce Fields
Is this something that only shows when pnfs is configured out, maybe?
Doesn't show up with my .config, with or without pnfs configured...

I've got:

	$ grep NFS .config
	CONFIG_NFS_FS=y
	CONFIG_NFS_V3=y
	CONFIG_NFS_V3_ACL=y
	CONFIG_NFS_V4=y
	CONFIG_NFS_V4_1=y
	CONFIG_PNFS_FILE_LAYOUT=y
	# CONFIG_PNFS_BLOCK is not set
	# CONFIG_NFS_USE_LEGACY_DNS is not set
	CONFIG_NFS_USE_KERNEL_DNS=y
	# CONFIG_NFS_USE_NEW_IDMAPPER is not set
	CONFIG_NFSD=y
	CONFIG_NFSD_DEPRECATED=y
	CONFIG_NFSD_V2_ACL=y
	CONFIG_NFSD_V3=y
	CONFIG_NFSD_V3_ACL=y
	CONFIG_NFSD_V4=y
	# CONFIG_PNFSD is not set
	CONFIG_NFS_ACL_SUPPORT=y
	CONFIG_NFS_COMMON=y

Quoted 1 line

Does this help?

Yep.--b.

Quoted 52 lines

fs/nfsd/nfs4proc.c +1 -0
index f08ab55..35d2567 100644
@@ -33,6 +33,7 @@
  *  SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #include <linux/file.h>
+#include <linux/kref.h>
 #include <linux/slab.h>
 #include <linux/nfsd/nfs4layoutxdr.h>
 #include <linux/nfsd4_spnfs.h>
Quoted 39 lines
--b.
----- Forwarded message from "J. Bruce Fields" <[email protected]> -----
Date: Fri, 11 Feb 2011 02:42:18 -0500
From: "J. Bruce Fields" <[email protected]>
To: [email protected]
Subject: all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and
layout_segment field prefix results
6210 all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and layout_segment field prefix fs/cifs/file.c: In function 'cifs_iovec_write':
fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *' fs/cifs/link.c: In function 'symlink_hash':
fs/cifs/link.c:58: warning: 'rc' may be used uninitialized in this function fs/cifs/smbencrypt.c: In function 'mdfour':
fs/cifs/smbencrypt.c:61: warning: 'rc' may be used uninitialized in this function In file included from include/linux/nfsd/nfsd4_pnfs.h:39,
                 from include/linux/nfsd/nfs4layoutxdr.h:38,
                 from fs/nfsd/nfs4proc.c:37:
include/linux/nfs_xdr.h:1124: error: field 'refcount' has incomplete type make[2]: *** [fs/nfsd/nfs4proc.o] Error 1
make[1]: *** [fs/nfsd] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [fs] Error 2
make: *** Waiting for unfinished jobs....
started Fri Feb 11 02:22:03 EST 2011, finished Fri Feb 11 02:42:18 EST 2011
+-----------------------------------------+
|            verbose output               |
+-----------------------------------------+
----- End forwarded message -----