Skip to contentSkip to conversation

MAINTAINERS: a question about it

DISCUSSION Harry Wei 3 participants 6 messages Feb 11, 2011 – Feb 12, 2011 3 messages not in the archive

lore
Share & tools
lore

Harry Wei

author
#0 lore raw

Hi us,
I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position. Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.

Thanks.
Best Regards.
Harry Wei.

#1 lore raw
Quoted 4 lines · Harry Wei

Hi us,
I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position. Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.

Why not just modify the 'scripts/get_maintainers.pl' tool to do this?

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · On Fri, 11 Feb 2011 07:40:14 -0800 Greg KH <[email protected]> wrote:
Quoted 4 lines · Harry Wei

Hi us,
I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position. Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.

Why not just modify the 'scripts/get_maintainers.pl' tool to do this?

thanks,

greg k-h

surely, you mean hooking it into 'scripts/checkpatch.pl' ?

#3 lore raw
Quoted 9 lines · Florian Mickler
Quoted 6 lines · On Fri, 11 Feb 2011 07:40:14 -0800 Greg KH <[email protected]> wrote:
Quoted 4 lines · Harry Wei

Hi us,
I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position. Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.

Quoted 8 lines
Quoted 5 lines

Why not just modify the 'scripts/get_maintainers.pl' tool to do this?

thanks,

greg k-h

surely, you mean hooking it into 'scripts/checkpatch.pl' ?

No, I hadn't ment that, as I figured get_maintainers.pl already parsed the MAINTAINERS file, so it might be easier to do it there.

But you are probably right, it's only an issue when you add a MAINTAINERS entry, so it should go into that script.

Although I'm really loath to add any more to that script, it's slow enough as it is on large patches :(

thanks,

greg k-h

#4 lore raw
Quoted 14 lines · On Fri, 11 Feb 2011 13:25:54 -0800 Greg KH <[email protected]> wrote:
Quoted 13 lines · Florian Mickler
Quoted 10 lines · On Fri, 11 Feb 2011 07:40:14 -0800 Greg KH <[email protected]> wrote:
Quoted 4 lines · Harry Wei

Hi us,
I saw MAINTAINERS these days. I find we should program a script(shell) for checking if a maintainer added himself in correct position. Because the MAINTAINERS is in alphabetical order and it has lots of maintainers now.
I just want to ask if anyone is doing this work. If it has been began i will do other things about kernel. If not, i will program this script(shell) for us.

Why not just modify the 'scripts/get_maintainers.pl' tool to do this?

thanks,

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

greg k-h

surely, you mean hooking it into 'scripts/checkpatch.pl' ?

No, I hadn't ment that, as I figured get_maintainers.pl already parsed the MAINTAINERS file, so it might be easier to do it there.

perl -e '$last = "0"; while (<>) { @F = split(/:/); if ($begin) { if (!/^\s*$/ && length($F[0]) > 1) { unless ($last le $_) { print "header wrongly sorted! ($_)\n"; $err =1; } $last = $_; }}; $begin = 1 if ( $F[0] =~ /\t\t-----------------------------------$/);} exit(1) if ($err); ' < MAINTAINERS

:)

Regards,
Flo

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#8 lore raw
Quoted 8 lines · harryxiyou

---------- Forwarded message ----------
From: Florian Mickler <[email protected]>
Date: 2011/2/12
Subject: Re: MAINTAINERS: a question about it
To: harryxiyou <[email protected]>
Cc: Tranlations maintainer for linux kernel <[email protected]>

Quoted 14 lines
Quoted 2 lines · On Sat, 12 Feb 2011 10:56:48 +0800 harryxiyou <[email protected]> wrote:

Hi greg, Florian,
I will try to do it. Thanks to your help. Maybe i will do it

in

Quoted 7 lines

get_maintainers.pl or a private shell script.
I just want to check if anyone has done it :)

Thanks.
Best regards.
Harry Wei.

Hi florian,
Thanks to your reply ;)

Quoted 1 line

Ok. If the script can automatically sort the file, that would be cool.

It can only check if the maintainers in the alphabetical order when maintainer add himself in it.

Quoted 5 lines

And a little note, because I don't know if you already know it:
We almost never drop people from the 'cc:' list. That could be considered rude if that person is actually interested in the email thread. That is why we, if in doubt, keep the cc list.

Thanks, i will remember this rule. Keep the cc list :)

Quoted 8 lines

Another thing that you can try, is to find a bug report with a backtrace, locate the bug in the source code and then try to figure out why it happened and how it could be prevented from happening. And then you can check if the solution somebody else probably already posted in the meantime is what you would have done. (Oh, and be warned, some people know what they do, and some don't... not easy to tell.. and it varies from day to day ;) )

I will surely do it later :) thanks to your help.

Thanks.
Best Regards.
Harry Wei.

Quoted 11 lines

Regards,
Flo

Signature · 3 lines
Best Regards.
Harry Wei.
Do what u like!