mc13xxx-core, support for i2c, V4
Subsystems (3)
Hi,
These patches add i2c support for the mc13xxx-core drive. For v4 I've tried to take in all previous comments, hopefully making it better to follow, and bisectable.
Cheers,
Marc
PATCH v4 1/4 mc13xxx-core: Prepare for separate spi and i2c backends.
This patch abstracts the bus specific operations from the driver core. Read and write handlers are introduced and generic initialization is consolidated into mc13xxx_comon_init. The irq member is removed because it is unused.
--- drivers/mfd/mc13xxx-core.c | 158 +++++++++++++++++++++++++----------------- include/linux/mfd/mc13xxx.h | 5 ++ 2 files changed, 99 insertions(+), 64 deletions(-)
drivers/mfd/mc13xxx-core.c +94 -64
@@ -19,10 +19,22 @@#include <linux/mfd/core.h> #include <linux/mfd/mc13xxx.h> +enum mc13xxx_id { +MC13XXX_ID_MC13783 , +MC13XXX_ID_MC13892 , +MC13XXX_ID_INVALID , +}; +struct mc13xxx {struct spi_device *spidev; + +struct device *dev; +enum mc13xxx_id ictype; +struct mutex lock; -int irq; + +int (*read_dev)(struct mc13xxx *,unsigned int ,u32 *); +int (*write_dev)(struct mc13xxx *,unsigned int ,u32 );irq_handler_t irqhandler[MC13XXX_NUM_IRQ ];void *irqdata[MC13XXX_NUM_IRQ ];
@@ -150,36 +162,32 @@ EXPORT_SYMBOL(mc13783_to_mc13xxx);void mc13xxx_lock (struct mc13xxx *mc13xxx) {if (!mutex_trylock (&mc13xxx->lock)) { -dev_dbg (&mc13xxx->spidev->dev,"wait for %s from %pf\n" , +dev_dbg (mc13xxx->dev,"wait for %s from %pf\n" , __func__,__builtin_return_address (0 ));mutex_lock (&mc13xxx->lock); } -dev_dbg (&mc13xxx->spidev->dev,"%s from %pf\n" , +dev_dbg (mc13xxx->dev,"%s from %pf\n" , __func__,__builtin_return_address (0 )); }EXPORT_SYMBOL (mc13xxx_lock);void mc13xxx_unlock (struct mc13xxx *mc13xxx) { -dev_dbg (&mc13xxx->spidev->dev,"%s from %pf\n" , +dev_dbg (mc13xxx->dev,"%s from %pf\n" , __func__,__builtin_return_address (0 ));mutex_unlock (&mc13xxx->lock); }EXPORT_SYMBOL (mc13xxx_unlock);#define MC13XXX_REGOFFSET_SHIFT 25 -int mc13xxx_reg_read (struct mc13xxx *mc13xxx,unsigned int offset,u32 *val) +static int mc13xxx_spi_reg_read (struct mc13xxx *mc13xxx, +unsigned int offset,u32 *val) {struct spi_transfer t;struct spi_message m;int ret; -BUG_ON (!mutex_is_locked (&mc13xxx->lock)); - -if (offset >MC13XXX_NUMREGS ) -return -EINVAL ; - *val = offset <<MC13XXX_REGOFFSET_SHIFT ;memset (&t,0 ,sizeof (t));
@@ -201,26 +209,33 @@ int mc13xxx_reg_read(struct mc13xxx *mc13xxx, unsigned int offset, u32 *val) *val &=0xffffff ; -dev_vdbg (&mc13xxx->spidev->dev,"[0x%02x] -> 0x%06x\n" , offset, *val); -return 0 ; } -EXPORT_SYMBOL (mc13xxx_reg_read); -int mc13xxx_reg_write (struct mc13xxx *mc13xxx,unsigned int offset,u32 val) +int mc13xxx_reg_read (struct mc13xxx *mc13xxx,unsigned int offset,u32 *val) { -u32 buf; -struct spi_transfer t; -struct spi_message m;int ret;BUG_ON (!mutex_is_locked (&mc13xxx->lock)); -dev_vdbg (&mc13xxx->spidev->dev,"[0x%02x] <- 0x%06x\n" , offset, val); - -if (offset >MC13XXX_NUMREGS || val >0xffffff ) +if (offset >MC13XXX_NUMREGS )return -EINVAL ; + ret = mc13xxx->read_dev (mc13xxx, offset, val); +dev_vdbg (mc13xxx->dev,"[0x%02x] -> 0x%06x\n" , offset, *val); + +return ret; +} +EXPORT_SYMBOL (mc13xxx_reg_read); + +static int mc13xxx_spi_reg_write (struct mc13xxx *mc13xxx,unsigned int offset, +u32 val) +{ +u32 buf; +struct spi_transfer t; +struct spi_message m; +int ret; + buf =1 <<31 | offset <<MC13XXX_REGOFFSET_SHIFT | val;memset (&t,0 ,sizeof (t));
@@ -241,6 +256,18 @@ int mc13xxx_reg_write(struct mc13xxx *mc13xxx, unsigned int offset, u32 val)return 0 ; } + +int mc13xxx_reg_write (struct mc13xxx *mc13xxx,unsigned int offset,u32 val) +{ +BUG_ON (!mutex_is_locked (&mc13xxx->lock)); + +dev_vdbg (mc13xxx->dev,"[0x%02x] <- 0x%06x\n" , offset, val); + +if (offset >MC13XXX_NUMREGS || val >0xffffff ) +return -EINVAL ; + +return mc13xxx->write_dev (mc13xxx, offset, val); +}EXPORT_SYMBOL (mc13xxx_reg_write); int mc13xxx_reg_rmw(struct mc13xxx *mc13xxx, unsigned int offset,
@@ -445,7 +472,7 @@ static int mc13xxx_irq_handle(struct mc13xxx *mc13xxx,if (handled ==IRQ_HANDLED ) num_handled++; }else { -dev_err (&mc13xxx->spidev->dev, +dev_err (mc13xxx->dev,"BUG: irq %u but no handler\n" , baseirq + irq);
@@ -481,25 +508,23 @@ static irqreturn_t mc13xxx_irq_thread(int irq, void *data)return IRQ_RETVAL (handled); } -enum mc13xxx_id { -MC13XXX_ID_MC13783 , -MC13XXX_ID_MC13892 , -MC13XXX_ID_INVALID , -}; -const char *mc13xxx_chipname[] = { [MC13XXX_ID_MC13783 ] ="mc13783" , [MC13XXX_ID_MC13892 ] ="mc13892" , };#define maskval (reg, mask) (((reg) & (mask)) >> __ffs(mask)) -static int mc13xxx_identify (struct mc13xxx *mc13xxx,enum mc13xxx_id *id) +static int mc13xxx_identify (struct mc13xxx *mc13xxx) {u32 icid;u32 revision; -const char *name;int ret; +/* +* Get the generation ID from register 46, as apparently some older +* IC revisions only have this info at this location. Newer ICs seem to +* have both. +*/ ret =mc13xxx_reg_read (mc13xxx,46 , &icid);if (ret)return ret;
@@ -508,26 +533,23 @@ static int mc13xxx_identify(struct mc13xxx *mc13xxx, enum mc13xxx_id *id)switch (icid) {case 2 : - *id =MC13XXX_ID_MC13783 ; - name ="mc13783" ; + mc13xxx->ictype =MC13XXX_ID_MC13783 ;break ;case 7 : - *id =MC13XXX_ID_MC13892 ; - name ="mc13892" ; + mc13xxx->ictype =MC13XXX_ID_MC13892 ;break ;default : - *id =MC13XXX_ID_INVALID ; + mc13xxx->ictype =MC13XXX_ID_INVALID ;break ; } -if (*id ==MC13XXX_ID_MC13783 || *id ==MC13XXX_ID_MC13892 ) { +if (mc13xxx->ictype ==MC13XXX_ID_MC13783 || + mc13xxx->ictype ==MC13XXX_ID_MC13892 ) { ret =mc13xxx_reg_read (mc13xxx,MC13XXX_REVISION , &revision); -if (ret) -return ret; - dev_info(&mc13xxx->spidev->dev, "%s: rev: %d.%d, " + dev_info(mc13xxx->dev, "%s: rev: %d.%d, " "fin: %d, fab: %d, icid: %d/%d\n", - mc13xxx_chipname[*id], + mc13xxx_chipname[mc13xxx->ictype], maskval(revision, MC13XXX_REVISION_REVFULL), maskval(revision, MC13XXX_REVISION_REVMETAL), maskval(revision, MC13XXX_REVISION_FIN),
@@ -536,26 +558,12 @@ static int mc13xxx_identify(struct mc13xxx *mc13xxx, enum mc13xxx_id *id) maskval(revision, MC13XXX_REVISION_ICIDCODE)); } -if (*id !=MC13XXX_ID_INVALID ) { -const struct spi_device_id *devid = -spi_get_device_id (mc13xxx->spidev); -if (!devid || devid->driver_data != *id) -dev_warn (&mc13xxx->spidev->dev,"device id doesn't " -"match auto detection!\n" ); - } - -return 0 ; +return (mc13xxx->ictype ==MC13XXX_ID_INVALID ) ? -ENODEV :0 ; }static const char *mc13xxx_get_chipname (struct mc13xxx *mc13xxx) { -const struct spi_device_id *devid = -spi_get_device_id (mc13xxx->spidev); - -if (!devid) -return NULL ; - -return mc13xxx_chipname[devid->driver_data]; +return mc13xxx_chipname[mc13xxx->ictype]; }#include <linux/mfd/mc13783.h>
@@ -563,7 +571,7 @@ static const char *mc13xxx_get_chipname(struct mc13xxx *mc13xxx)int mc13xxx_get_flags (struct mc13xxx *mc13xxx) {struct mc13xxx_platform_data *pdata = -dev_get_platdata (&mc13xxx->spidev->dev); +dev_get_platdata (mc13xxx->dev);return pdata->flags; }
@@ -601,7 +609,7 @@ int mc13783_adc_do_conversion(struct mc13783 *mc13783, unsigned int mode, };init_completion (&adcdone_data.done); -dev_dbg (&mc13xxx->spidev->dev,"%s\n" , __func__); +dev_dbg (mc13xxx->dev,"%s\n" , __func__);mc13xxx_lock (mc13xxx);
@@ -643,7 +651,7 @@ int mc13783_adc_do_conversion(struct mc13783 *mc13783, unsigned int mode,return -EINVAL ; } -dev_dbg (&mc13783->mc13xxx.spidev->dev,"%s: request irq\n" , __func__); +dev_dbg (mc13783->mc13xxx.dev,"%s: request irq\n" , __func__);mc13xxx_irq_request (mc13xxx,MC13783_IRQ_ADCDONE , mc13783_handler_adcdone, __func__, &adcdone_data);mc13xxx_irq_ack (mc13xxx,MC13783_IRQ_ADCDONE );
@@ -701,7 +709,7 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx,if (!cell.name)return -ENOMEM ; -return mfd_add_devices (&mc13xxx->spidev->dev,-1 , &cell,1 ,NULL ,0 ); +return mfd_add_devices (mc13xxx->dev,-1 , &cell,1 ,NULL ,0 ); }static int mc13xxx_add_subdevice (struct mc13xxx *mc13xxx,const char *format)
@@ -713,7 +721,6 @@ static int mc13xxx_probe(struct spi_device *spi) {struct mc13xxx *mc13xxx;struct mc13xxx_platform_data *pdata =dev_get_platdata (&spi->dev); -enum mc13xxx_id id;int ret; mc13xxx =kzalloc (sizeof (*mc13xxx),GFP_KERNEL );
@@ -725,13 +732,36 @@ static int mc13xxx_probe(struct spi_device *spi) spi->bits_per_word =32 ;spi_setup (spi); + mc13xxx->dev = &spi->dev; mc13xxx->spidev = spi; + mc13xxx->read_dev = mc13xxx_spi_reg_read; + mc13xxx->write_dev = mc13xxx_spi_reg_write; + + ret =mc13xxx_common_init (mc13xxx, pdata, spi->irq); + +if (ret) { +dev_set_drvdata (&spi->dev,NULL ); + }else { +const struct spi_device_id *devid = +spi_get_device_id (mc13xxx->spidev); +if (!devid || devid->driver_data != mc13xxx->ictype) +dev_warn (mc13xxx->dev, +"device id doesn't match auto detection!\n" ); + } + +return ret; +} + +int mc13xxx_common_init (struct mc13xxx *mc13xxx, +struct mc13xxx_platform_data *pdata,int irq) +{ +int ret;mutex_init (&mc13xxx->lock);mc13xxx_lock (mc13xxx); - ret =mc13xxx_identify (mc13xxx, &id); -if (ret || id ==MC13XXX_ID_INVALID ) + ret =mc13xxx_identify (mc13xxx); +if (ret) goto err_revision;/* mask all irqs */
@@ -743,14 +773,13 @@ static int mc13xxx_probe(struct spi_device *spi)if (ret) goto err_mask; - ret =request_threaded_irq (spi->irq,NULL , mc13xxx_irq_thread, + ret =request_threaded_irq (irq,NULL , mc13xxx_irq_thread,IRQF_ONESHOT |IRQF_TRIGGER_HIGH ,"mc13xxx" , mc13xxx);if (ret) { err_mask: err_revision:mutex_unlock (&mc13xxx->lock); -dev_set_drvdata (&spi->dev,NULL );kfree (mc13xxx);return ret; }
@@ -786,6 +815,7 @@ err_revision:return 0 ; } +EXPORT_SYMBOL_GPL (mc13xxx_common_init); static int __devexit mc13xxx_remove(struct spi_device *spi) {
include/linux/mfd/mc13xxx.h +5 -0
@@ -21,6 +21,11 @@ int mc13xxx_reg_write(struct mc13xxx *mc13xxx, unsigned int offset, u32 val);int mc13xxx_reg_rmw (struct mc13xxx *mc13xxx,unsigned int offset,u32 mask,u32 val); +struct mc13xxx_platform_data ; + +int mc13xxx_common_init (struct mc13xxx *mc13xxx, +struct mc13xxx_platform_data *pdata,int irq); +int mc13xxx_get_flags (struct mc13xxx *mc13xxx); int mc13xxx_irq_request(struct mc13xxx *mc13xxx, int irq,
Signature · 1 line
1.7.1
PATCH v4 2/4 mc13xxx-core: Kconfig: Config menu driven by specific IC type
In reply to Marc ReillyThis patch makes config items for the mc13892 and mc13783 distinct and splits introduces a separate config item for spi interface support in preparation for a separate i2c and spi backend.
The mc13xxx generic core is therefore selected by the spi (or i2c) item:
having it the other way around doesn't work for other drivers that will need to distinguish between mc13783 and mc13892 (at build time).
--- drivers/mfd/Kconfig | 34 +++++++++++++++++++++++++--------- 1 files changed, 25 insertions(+), 9 deletions(-)
drivers/mfd/Kconfig +25 -9
@@ -425,20 +425,36 @@ config MFD_PCF50633 so that function-specific drivers can bind to them. config MFD_MC13783 - tristate - -config MFD_MC13XXX - tristate "Support Freescale MC13783 and MC13892" depends on SPI_MASTER - select MFD_CORE - select MFD_MC13783 + select MFD_MC13XXX_SPI + tristate "Support for Freescale MC13783 PMIC" help - Support for the Freescale (Atlas) PMIC and audio CODECs - MC13783 and MC13892. - This driver provides common support for accessing the device, + Support for the Freescale MC13783 PMIC and audio CODEC. + This driver provides common support for accessing the device, additional drivers must be enabled in order to use the functionality of the device. +config MFD_MC13892 + depends on SPI_MASTER || I2C + select MFD_MC13XXX + tristate "Support for Freescale MC13892 PMIC" + help + Enable support for the Freescale MC13892 PMIC. + As the MC13892 can connect by either I2C or SPI bus, you will + also need to select which of these you would like to support. + Additional drivers must be enabled in order to use the + functionality of the device. + +config MFD_MC13XXX + tristate + depends on SPI_MASTER || I2C + select MFD_CORE + +config MFD_MC13XXX_SPI + tristate "Support Freescale MC13783 and MC13892 via SPI interface" + select MFD_MC13XXX + depends on SPI_MASTER && (MFD_MC13783 || MFD_MC13892) + config PCF50633_ADC tristate "Support for NXP PCF50633 ADC" depends on MFD_PCF50633
Signature · 1 line
1.7.1
PATCH v4 2/4 mc13xxx-core: Kconfig: Config menu driven by specific IC type
Quoted 31 lines · Marc Reilly
This patch makes config items for the mc13892 and mc13783 distinct and splits introduces a separate config item for spi interface support in preparation for a separate i2c and spi backend.
The mc13xxx generic core is therefore selected by the spi (or i2c) item:
having it the other way around doesn't work for other drivers that will need to distinguish between mc13783 and mc13892 (at build time).Signed-off-by Marc Reilly <[email protected]>--- drivers/mfd/Kconfig | 34 +++++++++++++++++++++++++--------- 1 files changed, 25 insertions(+), 9 deletions(-)drivers/mfd/Kconfig +2
-6@@ -425,20 +425,36 @@ config MFD_PCF50633 so that function-specific drivers can bind to them. config MFD_MC13783 - tristate - -config MFD_MC13XXX - tristate "Support Freescale MC13783 and MC13892" depends on SPI_MASTER - select MFD_CORE - select MFD_MC13783 + select MFD_MC13XXX_SPI + tristate "Support for Freescale MC13783 PMIC" help
drivers/mfd/Kconfig config MFD_PCF50633 · line 438
Quoted 10 lines
drivers/mfd/Kconfig +4
-3- Support for the Freescale (Atlas) PMIC and audio CODECs - MC13783 and MC13892. - This driver provides common support for accessing the device, + Support for the Freescale MC13783 PMIC and audio CODEC. + This driver provides common support for accessing the device, additional drivers must be enabled in order to use the functionality of the device. +config MFD_MC13892 + depends on SPI_MASTER || I2C
Actually you don't have that || I2C yet, do you?
Other than that I only wonder if it's worth to split the support for 13892 and 13783 explicitly and move the spi and i2c backends to dedicated files.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v4 3/4 mc13xxx-core: Move spi specific code into separate module.
In reply to Marc ReillyThis patch moves all spi specific code into a new module. The mc13xxx struct moves to the include file by necessity.
--- drivers/mfd/Makefile | 1 + drivers/mfd/mc13xxx-core.c | 166 ------------------------------------------ drivers/mfd/mc13xxx-spi.c | 168 +++++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/mc13xxx.h | 21 ++++++ 4 files changed, 190 insertions(+), 166 deletions(-) create mode 100644 drivers/mfd/mc13xxx-spi.c
drivers/mfd/Makefile +1 -0
@@ -42,6 +42,7 @@ obj-$(CONFIG_TWL4030_CODEC) += twl4030-codec.o obj-$(CONFIG_TWL6030_PWM) += twl6030-pwm.o obj-$(CONFIG_MFD_MC13XXX) += mc13xxx-core.o +obj-$(CONFIG_MFD_MC13XXX_SPI) += mc13xxx-spi.o obj-$(CONFIG_MFD_CORE) += mfd-core.o
drivers/mfd/mc13xxx-core.c +0 -166
199 lines not on this page · raw message
drivers/mfd/mc13xxx-spi.c new file +168 -0
168 lines not on this page · raw message
include/linux/mfd/mc13xxx.h +21 -0
@@ -66,6 +66,27 @@ int mc13xxx_get_flags(struct mc13xxx *mc13xxx);#define MC13XXX_NUM_IRQ 46 +enum mc13xxx_id { +MC13XXX_ID_MC13783 , +MC13XXX_ID_MC13892 , +MC13XXX_ID_INVALID , +}; + +struct mc13xxx { +struct spi_device *spidev; + +struct device *dev; +enum mc13xxx_id ictype; + +struct mutex lock; + +int (*read_dev)(struct mc13xxx *,unsigned int ,u32 *); +int (*write_dev)(struct mc13xxx *,unsigned int ,u32 ); + +irq_handler_t irqhandler[MC13XXX_NUM_IRQ ]; +void *irqdata[MC13XXX_NUM_IRQ ]; +}; +struct regulator_init_data ;struct mc13xxx_regulator_init_data {
Signature · 1 line
1.7.1
PATCH v4 4/4 mc13xxx-core: Add i2c driver
In reply to Marc Reilly--- drivers/mfd/Kconfig | 5 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mc13xxx-i2c.c | 115 +++++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/mc13xxx.h | 5 ++- 4 files changed, 125 insertions(+), 1 deletions(-) create mode 100644 drivers/mfd/mc13xxx-i2c.c
drivers/mfd/Kconfig +5 -0
@@ -455,6 +455,11 @@ config MFD_MC13XXX_SPI select MFD_MC13XXX depends on SPI_MASTER && (MFD_MC13783 || MFD_MC13892) +config MFD_MC13XXX_I2C + tristate "Support Freescale MC13892 via I2C interface" + select MFD_MC13XXX + depends on I2C && MFD_MC13892 + config PCF50633_ADC tristate "Support for NXP PCF50633 ADC" depends on MFD_PCF50633
drivers/mfd/Makefile +1 -0
@@ -43,6 +43,7 @@ obj-$(CONFIG_TWL6030_PWM) += twl6030-pwm.o obj-$(CONFIG_MFD_MC13XXX) += mc13xxx-core.o obj-$(CONFIG_MFD_MC13XXX_SPI) += mc13xxx-spi.o +obj-$(CONFIG_MFD_MC13XXX_I2C) += mc13xxx-i2c.o obj-$(CONFIG_MFD_CORE) += mfd-core.o
drivers/mfd/mc13xxx-i2c.c new file +115 -0
115 lines not on this page · raw message
include/linux/mfd/mc13xxx.h +4 -1
@@ -73,7 +73,10 @@ enum mc13xxx_id { };struct mc13xxx { -struct spi_device *spidev; +union { +struct spi_device *spidev; +struct i2c_client *i2cclient; + };struct device *dev;enum mc13xxx_id ictype;
Signature · 1 line
1.7.1
Quoted 4 lines · Marc Reilly
Hi,
These patches add i2c support for the mc13xxx-core drive. For v4 I've tried to take in all previous comments, hopefully making it better to follow, and bisectable.
This series looks okay to me. Since this is audio drivers, I expect that it would best be taken via the ASoC tree? Have you sent it to Mark Brown and the ALSA list for review?
g.
Hi Grant,
Thanks for your comments,
Quoted 7 lines · Grant Likely
Quoted 5 lines · Marc Reilly
Hi,
These patches add i2c support for the mc13xxx-core drive. For v4 I've tried to take in all previous comments, hopefully making it better to follow, and bisectable.
Quoted 5 lines
This series looks okay to me. Since this is audio drivers, I expect that it would best be taken via the ASoC tree? Have you sent it to Mark Brown and the ALSA list for review?
g.
Actually only the mc13873 has audio support. I think these IC's really fit better under the MFD tree, but silly me didn't add Samuel Ortiz (MFD maintainer) to this series... so included him now.
Samuel, are you the most appropriate to take this series in and would you like me to resend these patches to you? The thread archive is at [1].
Cheers
Marc
[1]
http://lists.arm.linux.org.uk/lurker/message/20110104.053455.45bc5880.en.html
Hi Mark,
Quoted 16 lines · Marc Reilly
Hi Grant,
Thanks for your comments,
Quoted 11 lines · Grant Likely
Quoted 5 lines · Marc Reilly
Hi,
These patches add i2c support for the mc13xxx-core drive. For v4 I've tried to take in all previous comments, hopefully making it better to follow, and bisectable.
This series looks okay to me. Since this is audio drivers, I expect that it would best be taken via the ASoC tree? Have you sent it to Mark Brown and the ALSA list for review?
Quoted 8 lines
Quoted 1 line
g.
Actually only the mc13873 has audio support. I think these IC's really fit better under the MFD tree, but silly me didn't add Samuel Ortiz (MFD maintainer) to this series... so included him now.
Samuel, are you the most appropriate to take this series in and would you like me to resend these patches to you? The thread archive is at [1].
Yes, I would be the one taking those patches. Please resend the patch set to me, and I'll have a look. Has Uwe commented on them yet ?
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/
Hi Samuel,
Quoted 11 lines
Quoted 11 lines
Quoted 6 lines
{Grant wrote}
This series looks okay to me. Since this is audio drivers, I expect that it would best be taken via the ASoC tree? Have you sent it to Mark Brown and the ALSA list for review?g.
Actually only the mc13873 has audio support. I think these IC's really fit better under the MFD tree, but silly me didn't add Samuel Ortiz (MFD maintainer) to this series... so included him now.
Quoted 5 lines
Quoted 2 lines
Samuel, are you the most appropriate to take this series in and would you like me to resend these patches to you? The thread archive is at [1].
Yes, I would be the one taking those patches. Please resend the patch set to me, and I'll have a look.
I don't have the original patch files available to resend the normal way, but attached are the 4 patch files off of patchwork [1]. Apologies if they are not what is required/inconvenient for you.
Quoted 1 line
Has Uwe commented on them yet ?
Uwe was very helpful in the first three versions of this series, but didn't have anything to say about V4.
Cheers
Marc
[1] https://patchwork.kernel.org/patch/449541/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4-1-4-mc13xxx-core-Prepare-for-separate-spi-and-i2c-backends..patch
Type: text/x-patch
Size: 11185 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110222/eec38aa9/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4-2-4-mc13xxx-core-Kconfig-Config-menu-driven-by-specific-IC-type.patch
Type: text/x-patch
Size: 2740 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110222/eec38aa9/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4-3-4-mc13xxx-core-Move-spi-specific-code-into-separate-module..patch
Type: text/x-patch
Size: 10876 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110222/eec38aa9/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4-4-4-mc13xxx-core-Add-i2c-driver.patch
Type: text/x-patch
Size: 5118 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110222/eec38aa9/attachment-0007.bin>
Le samedi, 12 f?vrier 2011 09.40:35, Grant Likely a ?crit :
Quoted 10 lines · Marc Reilly
Quoted 5 lines
Hi,
These patches add i2c support for the mc13xxx-core drive. For v4 I've tried to take in all previous comments, hopefully making it better to follow, and bisectable.
This series looks okay to me. Since this is audio drivers, I expect that it would best be taken via the ASoC tree? Have you sent it to Mark Brown and the ALSA list for review?
AFAIK the audio part of the mc13783 has still not been merged.
Regards,
Philippe
Quoted 1 line · Philippe R?tornaz
AFAIK the audio part of the mc13783 has still not been merged.
No, it hasn't. Sacha posted something ages ago but it had a lot of problems and I've not seen any subsequent spins.