[GIT PULL]
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus
to get regression and bug fixes for 2.6.38.
Thanks,
- Ted
Curt Wohlgemuth (1):
ext4: Fix data corruption with multi-block writepages support
Dan Carpenter (1):
ext4: off by one check in ext4_groupinfo_create_slab()
Eric Sandeen (3):
ext4: fix panic on module unload when stopping lazyinit thread
ext4: make grpinfo slab cache names static
ext4: serialize unaligned asynchronous DIO
Lukas Czerner (1):
ext4: unregister features interface on module unload
Theodore Ts'o (2):
ext4: fix up ext4 error handling
jbd2: call __jbd2_log_start_commit with j_state_lock write locked
fs/ext4/ext4.h | 8 ++++ fs/ext4/extents.c | 10 +++-- fs/ext4/file.c | 60 +++++++++++++++++++++++++++++- fs/ext4/mballoc.c | 100 +++++++++++++++++++++++++++++------------------- fs/ext4/page-io.c | 36 +++++++++-------- fs/ext4/super.c | 66 ++++++++++++++++++++++---------- fs/jbd2/journal.c | 9 +++- fs/jbd2/transaction.c | 21 +++++++--- 8 files changed, 219 insertions(+), 91 deletions(-)
Quoted 9 lines · Ted Ts'o
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
for_linusto get regression and bug fixes for 2.6.38.
Eric Sandeen (3):
ext4: serialize unaligned asynchronous DIO
This is a completely disgusting patch, and it causes warnings like this:
fs/ext4/file.c: In function ‘ext4_aiodio_wait’:
fs/ext4/file.c:60:44: warning: cast from pointer to integer of different size
because that disgusting patch does things like
#define ext4_aio_mutex(v) (&ext4__aio_mutex[((unsigned)v) % EXT4_WQ_HASH_SZ])
which is just terminally broken.
It's terminally broken for multiple reasons, too. It's not just "oh, a warning". It's a case of "oh, THAT CODE IS UTTER CRAP". The warning was just the lucky reason I noticed the totally unacceptable code.
Dammit, don't send sh*t to me this late in the release cycle. This clearly went through _zero_ quality control.
Linus
PS. If people don't understand why that code is utter crap, let me give you a hint: macro argument expansion vs operator precedence.
PPS. And btw, the warning is unacceptable too. Cast the thing to "unsigned long" (or uintptr_t, but quite frankly, in the kernel I'd suggest "unsigned long" rather than the more obscure standard types) after you've fixed the macro argument problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · Linus Torvalds
Quoted 9 lines · Ted Ts'o
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.gitfor_linusto get regression and bug fixes for 2.6.38.
Eric Sandeen (3):
ext4: serialize unaligned asynchronous DIO
Quoted 8 lines
This is a completely disgusting patch, and it causes warnings like this:
fs/ext4/file.c: In function ‘ext4_aiodio_wait’:
fs/ext4/file.c:60:44: warning: cast from pointer to integer of different sizebecause that disgusting patch does things like
#define ext4_aio_mutex(v) (&ext4__aio_mutex[((unsigned)v) % EXT4_WQ_HASH_SZ])
Well crap, the patch I sent Ted did not cause warnings.
OTOH, I eyeballed his changes to my patch and said OK. Didn't test-build it though. Sorry about that.
Will see what's going on here...
-Eric
Quoted 14 lines
which is just terminally broken.
It's terminally broken for multiple reasons, too. It's not just "oh, a warning". It's a case of "oh, THAT CODE IS UTTER CRAP". The warning was just the lucky reason I noticed the totally unacceptable code.
Dammit, don't send sh*t to me this late in the release cycle. This clearly went through _zero_ quality control.
Linus
PS. If people don't understand why that code is utter crap, let me give you a hint: macro argument expansion vs operator precedence.
Quoted 8 lines
PPS. And btw, the warning is unacceptable too. Cast the thing to "unsigned long" (or
uintptr_t, but quite frankly, in the kernel I'd suggest "unsigned long" rather than the more obscure standard types) after you've fixed the macro argument problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 1 line · Linus Torvalds
This is a completely disgusting patch, and it causes warnings like this:
Mea culpa, mea culpa, mea maximum culpa. Yes, sorry, I should have caught the macro expansion bug and the cast warning.
I've fixed up the problems, and repushed the for_linus branch. My post -rc1 push came late due to travel and other business, and that no doubt contributed to the lack of quality control, but I didn't want to wait since they did fix a number of fairly serious regressions. I hope you'll take the pull with these problems fixed?
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus
- Ted
Curt Wohlgemuth (1):
ext4: Fix data corruption with multi-block writepages support
Eric Sandeen (3):
ext4: fix panic on module unload when stopping lazyinit thread
ext4: make grpinfo slab cache names static
ext4: serialize unaligned asynchronous DIO
Lukas Czerner (1):
ext4: unregister features interface on module unload
Theodore Ts'o (2):
ext4: fix up ext4 error handling
jbd2: call __jbd2_log_start_commit with j_state_lock write locked
fs/ext4/ext4.h | 10 +++++ fs/ext4/extents.c | 10 +++-- fs/ext4/file.c | 60 +++++++++++++++++++++++++++++- fs/ext4/mballoc.c | 100 +++++++++++++++++++++++++++++------------------- fs/ext4/page-io.c | 36 +++++++++-------- fs/ext4/super.c | 66 ++++++++++++++++++++++---------- fs/jbd2/journal.c | 9 +++- fs/jbd2/transaction.c | 21 +++++++--- 8 files changed, 221 insertions(+), 91 deletions(-)