Skip to contentSkip to conversation

char/ipmi: cleanup_one_si section mismatch

PATCH In review Sergey Senozhatsky 3 participants 4 messages Feb 14, 2011 – Mar 15, 2011 IPMI

lore
Share & tools
lore

Sergey Senozhatsky

author
#0 lore raw

Hello,

commit d2478521afc20227658a10a8c5c2bf1a2aa615b3

Author: Corey Minyard <[email protected]>
Date:   Thu Feb 10 16:08:38 2011 -0600

char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver

Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit init_ipmi_si. Should we remove __exit annotation then?

---

 drivers/char/ipmi/ipmi_si_intf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +1 -1
index 7855f9f..94cd2ce 100644
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
 	kfree(to_clean);
 }
 
-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
 {
 	struct smi_info *e, *tmp_e;
Acked-by
#1 lore raw

Yeah, I should have noticed this.

Acked-by Corey Minyard <[email protected]>
Quoted 32 lines · Sergey Senozhatsky

Hello,

commit d2478521afc20227658a10a8c5c2bf1a2aa615b3

Author: Corey Minyard<[email protected]>
Date:   Thu Feb 10 16:08:38 2011 -0600

char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver

Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit init_ipmi_si. Should we remove __exit annotation then?

---

  drivers/char/ipmi/ipmi_si_intf.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +1 -1
index 7855f9f..94cd2ce 100644
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
  	kfree(to_clean);
  }
 
-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
  {
  	struct smi_info *e, *tmp_e;
author
#2 lore raw

PATCH 1/1 char/ipmi: fix cleanup_one_si section mismatch

commit d2478521afc20227658a10a8c5c2bf1a2aa615b3

Author: Corey Minyard<[email protected]>
Date:   Thu Feb 10 16:08:38 2011 -0600

char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver

Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit init_ipmi_si. Remove __exit annotation from cleanup_ipmi_si.

Signed-off-by Sergey Senozhatsky <[email protected]>
Acked-by Corey Minyard <[email protected]>

---

 drivers/char/ipmi/ipmi_si_intf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +1 -1
index 7855f9f..94cd2ce 100644
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
 	kfree(to_clean);
 }
 
-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
 {
 	struct smi_info *e, *tmp_e;
Acked-by on v1 1/1
#3 lore raw

Re: [PATCH] char/ipmi: fix cleanup_one_si section mismatch

Quoted 5 lines · On Tue, 15 Feb 2011 11:52:45 +0200 Sergey Senozhatsky wrote:

commit d2478521afc20227658a10a8c5c2bf1a2aa615b3

Author: Corey Minyard<[email protected]>
Date:   Thu Feb 10 16:08:38 2011 -0600
Quoted 8 lines

char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver

Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit init_ipmi_si. Remove __exit annotation from cleanup_ipmi_si.

Signed-off-by Sergey Senozhatsky <[email protected]>
Acked-by Corey Minyard <[email protected]>
Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 10 lines

---

 drivers/char/ipmi/ipmi_si_intf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +0 -0
index 7855f9f..94cd2ce 100644

drivers/char/ipmi/ipmi_si_intf.c static void cleanup_one_si(struct smi_info *to_clean)

Quoted 9 lines
drivers/char/ipmi/ipmi_si_intf.c +1 -2
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
 	kfree(to_clean);
 }
 
-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
 {
 	struct smi_info *e, *tmp_e;
 
--

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***