buildroot:package: Remove configure target parameter in Makefile.autotools.in

PATCH New Sonic Zhang 4 participants 10 messages Feb 1, 2011 – Feb 15, 2011 2 messages not in the archive

lore

Share & tools

lore

Sonic Zhang

author

2011-02-01 03:52 UTC #0 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

From: Sonic Zhang <[email protected]>

configure parameter --target has different meaning from buildroot environment parameter GNU_TARGET_NAME. GNU_TARGET_NAME is actually equal to --host.

  --build=BUILD     configure for building on BUILD [guessed]
  --host=HOST       cross-compile to build programs to run on HOST [BUILD]
  --target=TARGET   configure for building compilers for TARGET [HOST]

--target is rarely used by most packages and is redundant in configure line. If some packages do need --target, they can append it to buildroot environment parameter INETUTILS_CONF_OPT in packages' makefile.

Signed-off-by Sonic Zhang <[email protected]>

---
 package/Makefile.autotools.in |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

package/Makefile.autotools.in +0 -1

index d445348..151e5cf 100644
@@ -87,7 +87,6 @@ define $(2)_CONFIGURE_CMDS
 	$$(TARGET_CONFIGURE_ARGS) \
 	$$($$(PKG)_CONF_ENV) \
 	./configure \
-		--target=$$(GNU_TARGET_NAME) \
 		--host=$$(GNU_TARGET_NAME) \
 		--build=$$(GNU_HOST_NAME) \
 		--prefix=/usr \

Signature · 1 line

1.7.0.4

Mike Frysinger

2011-02-01 04:06 UTC #1 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

Quoted 10 lines · Sonic Zhang

configure parameter --target has different meaning from buildroot environment parameter GNU_TARGET_NAME. GNU_TARGET_NAME is actually equal to --host.
?--build=BUILD ? ? configure for building on BUILD [guessed] ?--host=HOST ? ? ? cross-compile to build programs to run on HOST [BUILD] ?--target=TARGET ? configure for building compilers for TARGET [HOST]
--target is rarely used by most packages and is redundant in configure line. If some packages do need --target, they can append it to buildroot environment parameter INETUTILS_CONF_OPT in packages' makefile.

not really ... the usage is harmless. it might be a little redundant since target tends to default to host, but that's about it. what are you actually trying to address here ?

[resending with buildroot subscription]
-mike

A message that is not in the archive (sent off-list or not yet received): [email protected]

Sonic Zhang

author

2011-02-01 04:43 UTC #3 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

Some autotools based software packages generate prefix name to the binary after running install if you set --target parameter.

For example:

--target=arm

rcp is rename to "linux-arm-rcp" after running install

Sonic

Quoted 17 lines · Mike Frysinger

Quoted 10 lines · Sonic Zhang
configure parameter --target has different meaning from buildroot environment parameter GNU_TARGET_NAME. GNU_TARGET_NAME is actually equal to --host.
?--build=BUILD ? ? configure for building on BUILD [guessed] ?--host=HOST ? ? ? cross-compile to build programs to run on HOST [BUILD] ?--target=TARGET ? configure for building compilers for TARGET [HOST]
--target is rarely used by most packages and is redundant in configure line. If some packages do need --target, they can append it to buildroot environment parameter INETUTILS_CONF_OPT in packages' makefile.
not really ... the usage is harmless. ?it might be a little redundant since target tends to default to host, but that's about it. ?what are you actually trying to address here ?
-mike

Mike Frysinger

2011-02-01 06:59 UTC #4 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

On Mon, Jan 31, 2011 at 23:43, Sonic Zhang wrote:

please dont top post

Quoted 8 lines

Some autotools based software packages generate prefix name to the binary after running install if you set --target parameter.
For example:
--target=arm
rcp is rename to "linux-arm-rcp" after running install

this is due to program_transform_name which is easily disabled:
program_transform_name=

alternatively, inetutils should be fixed to not have a --target in the first place. a "target" makes no sense for applications that dont generate anything, and since inetutils falls into that category, it should have AC_CANONICAL_SYSTEM changed to AC_CANONICAL_HOST in its configure.ac.
-mike

A message that is not in the archive (sent off-list or not yet received): DB904C5425BA6F4E8424B3B51A1414D165B430B838@NWD2CMBX1.ad.analog.com

Mike Frysinger

2011-02-01 07:50 UTC #6 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

Quoted 5 lines · Sonic

Mike Frysinger:
Quoted 4 lines · Sonic Zhang
Quoted 3 lines
Some autotools based software packages generate prefix name to the binary after running install if you set --target parameter.

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
For example:
--target=arm
rcp is rename to "linux-arm-rcp" after running install
this is due to program_transform_name which is easily disabled:
? ?program_transform_name=
Not only inetutils, but many other packages need "program_transform_name=" in this case. Because rare packages require --target to be set, why not do something to ease many?

personally, i prefer the route of fixing the underlying problem -- these packages should not have a --target unless they actually need it.
-mike

Peter Korsgaard

2011-02-01 07:45 UTC #7 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

In reply to Sonic Zhang

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sonic" == Sonic Zhang <[email protected]> writes:

Sonic> Some autotools based software packages generate prefix name to the Sonic> binary after running install if you set --target parameter.

Sonic> For example:

Sonic> --target=arm

Sonic> rcp is rename to "linux-arm-rcp" after running install

These packages typically accept the configure options --program-transform-name to make them not do that.

Signature · 1 line

Bye, Peter Korsgaard

Sonic Zhang

author

2011-02-02 04:49 UTC #8 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

Quoted 5 lines · Peter Korsgaard

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sonic" == Sonic Zhang <[email protected]> writes:
?Sonic> Some autotools based software packages generate prefix name to the ?Sonic> binary after running install if you set --target parameter.

Quoted 9 lines

?Sonic> For example:
?Sonic> --target=arm
?Sonic> rcp is rename to "linux-arm-rcp" after running install
These packages typically accept the configure options --program-transform-name to make them not do that.

Yes, but for some packages, --host and --target are not the same as defined in buildroot.

For example, to build on x86, run on arm and generate binary for mips.

Sonic

Quoted 3 lines

--
Bye, Peter Korsgaard

Mike Frysinger

2011-02-02 06:40 UTC #9 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

Quoted 10 lines · Sonic Zhang

Quoted 9 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sonic" == Sonic Zhang writes:
?Sonic> Some autotools based software packages generate prefix name to the ?Sonic> binary after running install if you set --target parameter.
?Sonic> For example:
?Sonic> --target=arm

Quoted 7 lines

Quoted 4 lines
?Sonic> rcp is rename to "linux-arm-rcp" after running install
These packages typically accept the configure options --program-transform-name to make them not do that.
Yes, but for some packages, --host and --target are not the same as defined in buildroot.

yes they are

Quoted 1 line

For example, to build on x86, run on arm and generate binary for mips.

but that is what we're doing. we build on x86, run on arm, and generate for arm.
-mike

Sonic Zhang

author

2011-02-09 03:01 UTC #10 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

Quoted 19 lines · Mike Frysinger

Quoted 10 lines · Sonic Zhang
Quoted 9 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sonic" == Sonic Zhang writes:
?Sonic> Some autotools based software packages generate prefix name to the ?Sonic> binary after running install if you set --target parameter.
?Sonic> For example:
?Sonic> --target=arm
Quoted 7 lines
Quoted 4 lines
?Sonic> rcp is rename to "linux-arm-rcp" after running install
These packages typically accept the configure options --program-transform-name to make them not do that.
Yes, but for some packages, --host and --target are not the same as defined in buildroot.

Quoted 8 lines

yes they are
Quoted 1 line
For example, to build on x86, run on arm and generate binary for mips.
but that is what we're doing. ?we build on x86, run on arm, and generate for arm.
-mike

Are you sure buildroot should be limited to the same --host and --target only?

Sonic

Mike Frysinger

2011-02-15 08:17 UTC #11 lore raw

PATCH 1/1 buildroot:package: Remove configure target parameter in Makefile.autotools.in

Quoted 21 lines · On Tuesday, February 08, 2011 22:01:52 Sonic Zhang wrote:

Quoted 20 lines · Mike Frysinger
Quoted 9 lines · Sonic Zhang
Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sonic" == Sonic Zhang writes:
Sonic> Some autotools based software packages generate prefix name to
the Sonic> binary after running install if you set --target parameter.
Sonic> For example:
Sonic> --target=arm
Quoted 7 lines
Quoted 4 lines
Sonic> rcp is rename to "linux-arm-rcp" after running install
These packages typically accept the configure options --program-transform-name to make them not do that.
Yes, but for some packages, --host and --target are not the same as defined in buildroot.
yes they are

Quoted 7 lines

Quoted 4 lines
Quoted 1 line
For example, to build on x86, run on arm and generate binary for mips.
but that is what we're doing. we build on x86, run on arm, and generate for arm.
Are you sure buildroot should be limited to the same --host and --target only?

until buildroot grows support to let users specify a --target, it is already limited to that.

i already sent a patch to upstream inetutils to fix their autoconf and they accepted it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110215/af62dc0c/attachment.asc>