Skip to contentSkip to conversation

spi/pl022: remove dangling status check

PATCH New Linus Walleij 2 participants 2 messages Feb 8, 2011 – Feb 15, 2011 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 spi/pl022: remove dangling status check

From: Virupax Sadashivpetimath <[email protected]>

---
 drivers/spi/amba-pl022.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/spi/amba-pl022.c +0 -2
index 8fdf530..2b591f0 100644
@@ -1906,8 +1906,6 @@ static int pl022_setup(struct spi_device *spi)
 	    && ((pl022->master_info)->enable_dma)) {
 		chip->enable_dma = true;
 		dev_dbg(&spi->dev, "DMA mode set in controller state\n");
-		if (status < 0)
-			goto err_config_params;
 		SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
 			       SSP_DMACR_MASK_RXDMAE, 0);
 		SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
Signature · 1 line
1.7.3.2
Applied
#1 lore raw

PATCH 3/4 spi/pl022: remove dangling status check

Quoted 4 lines · Linus Walleij

From: Virupax Sadashivpetimath <[email protected]>

Applied, thanks.

g.

Quoted 20 lines
---
 drivers/spi/amba-pl022.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/spi/amba-pl022.c +0 -2
index 8fdf530..2b591f0 100644
@@ -1906,8 +1906,6 @@ static int pl022_setup(struct spi_device *spi)
 	    && ((pl022->master_info)->enable_dma)) {
 		chip->enable_dma = true;
 		dev_dbg(&spi->dev, "DMA mode set in controller state\n");
-		if (status < 0)
-			goto err_config_params;
 		SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
 			       SSP_DMACR_MASK_RXDMAE, 0);
 		SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
Signature · 1 line
1.7.3.2