mpt2sas: use pci_dev->revision

PATCH New Sergei Shtylyov 1 participant 1 message Feb 16, 2011 SCSI

Share & tools

Sergei Shtylyov

author

2011-02-16 16:38 UTC #0 lore raw

PATCH 1/1 mpt2sas: use pci_dev->revision

The driver reads PCI revision ID from the PCI configuration register while it's already stored by PCI subsystem in the 'revision' field of 'struct pci_dev'...

Signed-off-by Sergei Shtylyov <[email protected]>

---
The patch is against the recent Linus' tree.

 drivers/scsi/mpt2sas/mpt2sas_base.c |    4 +---
 drivers/scsi/mpt2sas/mpt2sas_ctl.c  |    4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

drivers/scsi/mpt2sas/mpt2sas_base.c +1 -3

Index: linux-2.6/drivers/scsi/mpt2sas/mpt2sas_base.c
===================================================================
@@ -1735,10 +1735,8 @@ _base_display_ioc_capabilities(struct MP
 {
 	int i = 0;
 	char desc[16];
-	u8 revision;
 	u32 iounit_pg1_flags;
 
-	pci_read_config_byte(ioc->pdev, PCI_CLASS_REVISION, &revision);
 	strncpy(desc, ioc->manu_pg0.ChipName, 16);
 	printk(MPT2SAS_INFO_FMT "%s: FWVersion(%02d.%02d.%02d.%02d), "
 	   "ChipRevision(0x%02x), BiosVersion(%02d.%02d.%02d.%02d)\n",

@@ -1747,7 +1745,7 @@ _base_display_ioc_capabilities(struct MP
 	   (ioc->facts.FWVersion.Word & 0x00FF0000) >> 16,
 	   (ioc->facts.FWVersion.Word & 0x0000FF00) >> 8,
 	   ioc->facts.FWVersion.Word & 0x000000FF,
-	   revision,
+	   ioc->pdev->revision,
 	   (ioc->bios_pg3.BiosVersion & 0xFF000000) >> 24,
 	   (ioc->bios_pg3.BiosVersion & 0x00FF0000) >> 16,
 	   (ioc->bios_pg3.BiosVersion & 0x0000FF00) >> 8,

drivers/scsi/mpt2sas/mpt2sas_ctl.c +1 -3

Index: linux-2.6/drivers/scsi/mpt2sas/mpt2sas_ctl.c
===================================================================
@@ -1020,7 +1020,6 @@ _ctl_getiocinfo(void __user *arg)
 {
 	struct mpt2_ioctl_iocinfo karg;
 	struct MPT2SAS_ADAPTER *ioc;
-	u8 revision;
 
 	if (copy_from_user(&karg, arg, sizeof(karg))) {
 		printk(KERN_ERR "failure at %s:%d/%s()!\n",

@@ -1037,8 +1036,7 @@ _ctl_getiocinfo(void __user *arg)
 	karg.adapter_type = MPT2_IOCTL_INTERFACE_SAS2;
 	if (ioc->pfacts)
 		karg.port_number = ioc->pfacts[0].PortNumber;
-	pci_read_config_byte(ioc->pdev, PCI_CLASS_REVISION, &revision);
-	karg.hw_rev = revision;
+	karg.hw_rev = ioc->pdev->revision;
 	karg.pci_id = ioc->pdev->device;
 	karg.subsystem_device = ioc->pdev->subsystem_device;
 	karg.subsystem_vendor = ioc->pdev->subsystem_vendor;