Skip to contentSkip to conversation

omap iommu: print module name on error messages

PATCH New David Cohen 3 participants 3 messages Feb 12, 2011 – Feb 17, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

David Cohen

author
#0 lore raw

PATCH 1/1 omap iommu: print module name on error messages

OMAP IOMMU generic layer doesn't need ot print function name during error messages. Print module name instead which is more useful.

Signed-off-by David Cohen <[email protected]>
---
 arch/arm/plat-omap/iommu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/iommu.c +2 -2
index b1107c0..f55f458 100644
@@ -806,7 +806,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data)
 	iopgd = iopgd_offset(obj, da);
 
 	if (!iopgd_is_table(*iopgd)) {
-		dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x\n", __func__,
+		dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x\n", obj->name,
 			da, iopgd, *iopgd);
 		return IRQ_NONE;
 	}

@@ -814,7 +814,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data)
 	iopte = iopte_offset(iopgd, da);
 
 	dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x pte:%p *pte:%08x\n",
-		__func__, da, iopgd, *iopgd, iopte, *iopte);
+		obj->name, da, iopgd, *iopgd, iopte, *iopte);
 
 	return IRQ_NONE;
 }
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 omap iommu: print module name on error messages

From: ext David Cohen <[email protected]>
Subject: [PATCH] omap iommu: print module name on error messages
Date: Sat, 12 Feb 2011 12:02:29 +0200

Quoted 2 lines

OMAP IOMMU generic layer doesn't need ot print function name during error messages. Print module name instead which is more useful.

Agree. This makes more sense.

Quoted 4 lines
Signed-off-by David Cohen <[email protected]>
---
 arch/arm/plat-omap/iommu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
#2 lore raw

PATCH 1/1 omap iommu: print module name on error messages

Quoted 8 lines · Hiroshi DOYU

From: ext David Cohen <[email protected]>
Subject: [PATCH] omap iommu: print module name on error messages
Date: Sat, 12 Feb 2011 12:02:29 +0200

Quoted 2 lines

OMAP IOMMU generic layer doesn't need ot print function name during error messages. Print module name instead which is more useful.

Agree. This makes more sense.

Applying to devel-iommu-mailbox for the upcoming merge window.

Tony