Input: uinput - reversed test in uinput_setup_device()
Subsystems (3)
PATCH 1/1 Input: uinput - reversed test in uinput_setup_device()
The test here is reversed. It should be if (IS_ERR()) instead of if (!IS_ERR()).
Signed-off-by Dan Carpenter <[email protected]>
drivers/input/misc/uinput.c +1 -1
@@ -362,7 +362,7 @@ static int uinput_setup_device(struct uinput_device *udev, const char __user *bu dev = udev->dev; user_dev =memdup_user (buffer,sizeof (struct uinput_user_dev )); -if (!IS_ERR (user_dev)) +if (IS_ERR (user_dev))return PTR_ERR (user_dev); udev->ff_effects_max = user_dev->ff_effects_max;
Quoted 3 lines · Dan Carpenter
The test here is reversed. It should be if (
IS_ERR()) instead of if (!IS_ERR()).
Awww, crap...
Applied, thanks Dan.
Quoted 15 lines
Signed-off-by Dan Carpenter <[email protected]>drivers/input/misc/uinput.c +1
-1@@ -362,7 +362,7 @@ static int uinput_setup_device(struct uinput_device *udev, const char __user *bu dev = udev->dev; user_dev =memdup_user (buffer,sizeof (struct uinput_user_dev )); -if (!IS_ERR (user_dev)) +if (IS_ERR (user_dev))return PTR_ERR (user_dev); udev->ff_effects_max = user_dev->ff_effects_max;
Signature · 1 line
Dmitry