Skip to contentSkip to conversation

Input: uinput - reversed test in uinput_setup_device()

PATCH Applied Dan Carpenter 2 participants 2 messages Feb 18, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: uinput - reversed test in uinput_setup_device()

The test here is reversed. It should be if (IS_ERR()) instead of if (!IS_ERR()).

drivers/input/misc/uinput.c +1 -1
index 7f8331f..364bdf4 100644
@@ -362,7 +362,7 @@ static int uinput_setup_device(struct uinput_device *udev, const char __user *bu
 	dev = udev->dev;
 
 	user_dev = memdup_user(buffer, sizeof(struct uinput_user_dev));
-	if (!IS_ERR(user_dev))
+	if (IS_ERR(user_dev))
 		return PTR_ERR(user_dev);
 
 	udev->ff_effects_max = user_dev->ff_effects_max;
maintainer Applied
#1 lore raw
Quoted 3 lines · Dan Carpenter

The test here is reversed. It should be if (IS_ERR()) instead of if (!IS_ERR()).

Awww, crap...

Applied, thanks Dan.

Quoted 15 lines
drivers/input/misc/uinput.c +1 -1
index 7f8331f..364bdf4 100644
@@ -362,7 +362,7 @@ static int uinput_setup_device(struct uinput_device *udev, const char __user *bu
 	dev = udev->dev;
 
 	user_dev = memdup_user(buffer, sizeof(struct uinput_user_dev));
-	if (!IS_ERR(user_dev))
+	if (IS_ERR(user_dev))
 		return PTR_ERR(user_dev);
 
 	udev->ff_effects_max = user_dev->ff_effects_max;
Signature · 1 line
Dmitry