bug in arm_kprobe_decode_insn
Hi
In arch/arm/kernel/kprobes-decode.c there's a function arm_kprobe_decode_insn which does:
} else if ((insn & 0x0e000000) == 0x0c400000) {
...
This is always false, so code below is dead.
I'm not sure about what was intended here, but I think this change might be correct:
arch/arm/kernel/kprobes-decode.c +1 -1
@@ -1437,7 +1437,7 @@ arm_kprobe_decode_insn(kprobe_opcode_t insn, struct arch_specific_insn *asi)return space_cccc_1100_010x (insn, asi); - }else if ((insn &0x0e000000 ) ==0x0c400000 ) { + }else if ((insn &0x0e000000 ) ==0x0c000000 ) {return space_cccc_110x (insn, asi);
--
I found this bug by coccinelle (http://coccinelle.lip6.fr/).
(The script is ugly, so I'm not attaching it here)
Marcin Slusarz
Quoted 9 lines · Marcin Slusarz
Hi
In
arch/arm/kernel/kprobes-decode.cthere's a functionarm_kprobe_decode_insnwhich does:} else if ((insn &
0x0e000000) ==0x0c400000) {
...This is always false, so code below is dead.
Good catch, thanks.
Nicolas